New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 720553 link

Starred by 2 users
Status: Available
Owner: ----
Cc:
dcheng@chromium.org
█ wkorman@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

rework enum to enum class

Project Member Reported by xidac...@chromium.org, May 10 2017 
in our code base, we have different styles of using enum, I believe there are discussions along this direction to rework them to be "enum class".

An example is this CL: (see the comments)
https://codereview.chromium.org/2863693003/

Comment 1 by sashab@chromium.org, May 11 2017

Cc: dcheng@chromium.org
+dcheng

I would be in favour of an effort to change all enums in blink to enum class, with the exception of things that are used only as array indexes or similar and the auto-type-cast is useful. I don't even know if we have any cases like this at all, maybe it just makes sense for all enums to be enum classes (enforcing the nice namespace-ness).

Comment 2 by sashab@chromium.org, Feb 2 2018

Cc: -sashab@chromium.org

Comment 3 by mustaq@google.com, Nov 29

Components: Blink>Input
Labels: Hotlist-CodeHealth
►

Sign in to add a comment