New issue
Advanced search Search tips

Issue 720550 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Report frequency of single page app navigations to UMA.

Project Member Reported by tdres...@chromium.org, May 10 2017

Issue description

We currently output a trace event for each single page app navigation.

Record an UMA as well. 

https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/loader/FrameLoader.cpp?rcl=77346d2ec5bd54cfcb9cdebe97127b725af60db5&l=529

https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/loader/FrameLoaderTypes.h?l=35&gsn=FrameLoadType

Lets add an UMA histogram counting the number of calls to UpdateForSameDocumentNavigation, per FrameLoadType.

See https://chromium.googlesource.com/chromium/src.git/+/HEAD/tools/metrics/histograms/README.md#Enum-Histograms for details on what this looks like.
 

Comment 1 by maxlg@chromium.org, Jun 26 2017

As discussed in https://codereview.chromium.org/2936723002/, we want to count the number of calls to UpdateForSameDocumentNavigation according to SinglePageAppNavigationType instead.

Depending on same_document_navigation_source and FrameLoadType, single page app navigation types can be split into SameDocumentBackwardOrForward, HistoryApi and HistoryPushStateOrReplaceState. 

Comment 3 by maxlg@chromium.org, Jul 10 2017

Status: Fixed (was: Assigned)

Sign in to add a comment