"xhtml-mathml-dtd-entity" web platform tests trigger DCHECK fail in XMLDocumentParser |
|||||
Issue descriptionExample results: https://storage.googleapis.com/chromium-layout-test-archives/mac_chromium_rel_ng/449362/layout-test-results/results.html# Example stderr: https://storage.googleapis.com/chromium-layout-test-archives/win_chromium_rel_ng/440148/layout-test-results/external/wpt/html/the-xhtml-syntax/parsing-xhtml-documents/xhtml-mathml-dtd-entity-7-crash-log.txt Location of DCHECK: https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp?l=1418 The tests in question: https://github.com/w3c/web-platform-tests/tree/master/html/the-xhtml-syntax/parsing-xhtml-documents These are web-platform-tests which are being imported in https://chromium-review.googlesource.com/c/499507/.
,
May 11 2017
Thanks for all the links. I wonder if the string is empty and hence the DCHECK is confused or the caller is confused or something. Will take a look.
,
Aug 22 2017
Bulk disowning per sshruthi's email about bug triage best practices.
,
Aug 25 2017
,
Aug 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3ad7ae1fa15072d13d29d0e1adc7600e572500b5 commit 3ad7ae1fa15072d13d29d0e1adc7600e572500b5 Author: Kent Tamura <tkent@chromium.org> Date: Mon Aug 28 03:28:17 2017 Fix DCHECK failures in ConvertUTF16EntityToUTF8(). This DCHECK condition was wrong. |target| can have only a single byte. e.g. & is 0x26 in UTF-8. Bug: 720545 Change-Id: I84d59e526b75aae83caf051409e7b15662706ec8 Reviewed-on: https://chromium-review.googlesource.com/635106 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by: Dominic Cooney <dominicc@chromium.org> Cr-Commit-Position: refs/heads/master@{#497692} [modify] https://crrev.com/3ad7ae1fa15072d13d29d0e1adc7600e572500b5/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/3ad7ae1fa15072d13d29d0e1adc7600e572500b5/third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp
,
Aug 28 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by esprehn@chromium.org
, May 10 2017