New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 720534 link

Starred by 1 user
Status: Fixed
Owner:
█ bmcquade@chromium.org
Last visit > 30 days ago
Closed: May 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Fix broken DocumentWriteAsync browsertest

Project Member Reported by bmcquade@chromium.org, May 10 2017 
Turns out that the URL passed to this test points to a nonexistent page, and since the test just asserts that no histograms are recorded, it passes. We should fix the URL to point to the right page, and verify that at least one other histogram is recorded to confirm that a valid page was loaded.
Project Member

Comment 1 by bugdroid1@chromium.org, May 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1692d2da9038b8515e47f4590f24df81b56c521

commit a1692d2da9038b8515e47f4590f24df81b56c521
Author: bmcquade <bmcquade@chromium.org>
Date: Thu May 11 17:56:51 2017

Various cleanups for page_load_metrics_browsertest

* clean up and generalize PageLoadMetricsWaiter
* where possible, switch tests from calling NavigateToUntrackedUrl() to using PageLoadMetricsWaiter
* add support for monitoring both main and child frame updates
* fix broken DocumentWriteAsync test

BUG= 720534 

Review-Url: https://codereview.chromium.org/2868213003
Cr-Commit-Position: refs/heads/master@{#471005}

[modify] https://crrev.com/a1692d2da9038b8515e47f4590f24df81b56c521/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
[modify] https://crrev.com/a1692d2da9038b8515e47f4590f24df81b56c521/chrome/browser/page_load_metrics/metrics_web_contents_observer.h
[modify] https://crrev.com/a1692d2da9038b8515e47f4590f24df81b56c521/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
[modify] https://crrev.com/a1692d2da9038b8515e47f4590f24df81b56c521/chrome/test/data/page_load_metrics/document_write_async_script.html

Comment 2 by bmcquade@chromium.org, May 25 2017

Status: Fixed (was: Started)
►

Sign in to add a comment