New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 720525 link

Starred by 1 user
Status: Fixed
Owner:
█ warx@chromium.org
Last visit > 30 days ago
Closed: Sep 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

cleanup subclasses of WidgetObserver for test

Project Member Reported by warx@chromium.org, May 10 2017 
Currently code base has several duplicate subclasses of WidgetObserver used for test, for example code search on OnWidgetClosing and OnWidgetDestorying, etc.

We need to eliminate duplicates by making them into one class for ease of writing tests for future.
Project Member

Comment 1 by bugdroid1@chromium.org, May 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8362f111408e8ec8bfe8a34c77fa7ef13645cf99

commit 8362f111408e8ec8bfe8a34c77fa7ef13645cf99
Author: warx <warx@chromium.org>
Date: Fri May 12 18:35:48 2017

cleanup: make WidgetClosingObserver as test support

changes:
(1) eliminate duplicates of WidgetClosingObserver into widget_test.h.
(2) several other cleanup into the current file.

BUG= 720525 
TEST=covered by tests

Review-Url: https://codereview.chromium.org/2875513003
Cr-Commit-Position: refs/heads/master@{#471374}

[modify] https://crrev.com/8362f111408e8ec8bfe8a34c77fa7ef13645cf99/chrome/browser/ui/views/first_run_bubble_unittest.cc
[modify] https://crrev.com/8362f111408e8ec8bfe8a34c77fa7ef13645cf99/chrome/browser/ui/views/passwords/password_dialog_view_browsertest.cc
[modify] https://crrev.com/8362f111408e8ec8bfe8a34c77fa7ef13645cf99/ui/views/test/widget_test.cc
[modify] https://crrev.com/8362f111408e8ec8bfe8a34c77fa7ef13645cf99/ui/views/test/widget_test.h

Comment 2 by warx@chromium.org, May 24 2017

Owner: warx@chromium.org
Status: Assigned (was: Untriaged)

Comment 3 by warx@chromium.org, Sep 1 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment