V8 garbage collection requires too many passes over global handles |
||
Issue descriptionGlobal handles iteration can take a considerable amount of time during all sorts of GCs (Scavenge, MC, minor MC). Since we don't have young generation object grouping anymore we should re-evaluate whether all phases and states are actually required.
,
May 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/58020872dce50cb53dcc8ce5be8cc0243c759e0c commit 58020872dce50cb53dcc8ce5be8cc0243c759e0c Author: Deepti Gandluri <gdeepti@chromium.org> Date: Wed May 10 21:52:59 2017 Revert "[global-handles] Remove dead code" This reverts commit e2890c19a70376686f025119082cfad6676a2f7b. Reason for revert: Looks like this CL causes slowdown on multiple builders, Check tests timeout and raise exceptions on the bot. Possible it is a bot issue as well, see tracking bug - https://bugs.chromium.org/p/chromium/issues/detail?id=720606 Original change's description: > [global-handles] Remove dead code > > Bug: chromium:720477 > Change-Id: I090168c575c41b7038af5dfba6cd8973d1154c51 > Reviewed-on: https://chromium-review.googlesource.com/501790 > Reviewed-by: Hannes Payer <hpayer@chromium.org> > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#45241} TBR=hpayer@chromium.org,mlippautz@chromium.org,jochen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Bug: chromium:720477 Change-Id: I92f40d8c4dbfdb5208b3068648612e8c5b97fb20 Reviewed-on: https://chromium-review.googlesource.com/502029 Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#45243} [modify] https://crrev.com/58020872dce50cb53dcc8ce5be8cc0243c759e0c/src/global-handles.cc [modify] https://crrev.com/58020872dce50cb53dcc8ce5be8cc0243c759e0c/src/global-handles.h [modify] https://crrev.com/58020872dce50cb53dcc8ce5be8cc0243c759e0c/src/heap/heap.cc [modify] https://crrev.com/58020872dce50cb53dcc8ce5be8cc0243c759e0c/src/heap/mark-compact.cc
,
May 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/c836a95e87a9d8a13b057a3acf90c75650906a3e commit c836a95e87a9d8a13b057a3acf90c75650906a3e Author: Deepti Gandluri <gdeepti@chromium.org> Date: Wed May 10 21:55:39 2017 Revert "Revert "[global-handles] Remove dead code"" This reverts commit 58020872dce50cb53dcc8ce5be8cc0243c759e0c. Reason for revert: Turned out to be a bot issue, reverting the revert. Original change's description: > Revert "[global-handles] Remove dead code" > > This reverts commit e2890c19a70376686f025119082cfad6676a2f7b. > > Reason for revert: Looks like this CL causes slowdown on multiple builders, Check tests timeout and raise exceptions on the bot. Possible it is a bot issue as well, see tracking bug - https://bugs.chromium.org/p/chromium/issues/detail?id=720606 > > Original change's description: > > [global-handles] Remove dead code > > > > Bug: chromium:720477 > > Change-Id: I090168c575c41b7038af5dfba6cd8973d1154c51 > > Reviewed-on: https://chromium-review.googlesource.com/501790 > > Reviewed-by: Hannes Payer <hpayer@chromium.org> > > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#45241} > > TBR=hpayer@chromium.org,mlippautz@chromium.org,jochen@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > Bug: chromium:720477 > > Change-Id: I92f40d8c4dbfdb5208b3068648612e8c5b97fb20 > Reviewed-on: https://chromium-review.googlesource.com/502029 > Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> > Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> > Cr-Commit-Position: refs/heads/master@{#45243} TBR=hpayer@chromium.org,gdeepti@chromium.org,mlippautz@chromium.org,jochen@chromium.org,v8-reviews@googlegroups.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Bug: chromium:720477 Change-Id: I70e190e0c27074228a8128aa849e5a419af915e8 Reviewed-on: https://chromium-review.googlesource.com/502030 Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#45244} [modify] https://crrev.com/c836a95e87a9d8a13b057a3acf90c75650906a3e/src/global-handles.cc [modify] https://crrev.com/c836a95e87a9d8a13b057a3acf90c75650906a3e/src/global-handles.h [modify] https://crrev.com/c836a95e87a9d8a13b057a3acf90c75650906a3e/src/heap/heap.cc [modify] https://crrev.com/c836a95e87a9d8a13b057a3acf90c75650906a3e/src/heap/mark-compact.cc
,
May 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/682d5369b810929d0fbd3d7704742400b0e95559 commit 682d5369b810929d0fbd3d7704742400b0e95559 Author: Michael Lippautz <mlippautz@chromium.org> Date: Thu May 11 05:59:00 2017 Revert "Revert "Revert "[global-handles] Remove dead code""" This reverts commit c836a95e87a9d8a13b057a3acf90c75650906a3e. Reason for revert: I don't think this was related. Original change's description: > Revert "Revert "[global-handles] Remove dead code"" > > This reverts commit 58020872dce50cb53dcc8ce5be8cc0243c759e0c. > > Reason for revert: Turned out to be a bot issue, reverting the revert. > > Original change's description: > > Revert "[global-handles] Remove dead code" > > > > This reverts commit e2890c19a70376686f025119082cfad6676a2f7b. > > > > Reason for revert: Looks like this CL causes slowdown on multiple builders, Check tests timeout and raise exceptions on the bot. Possible it is a bot issue as well, see tracking bug - https://bugs.chromium.org/p/chromium/issues/detail?id=720606 > > > > Original change's description: > > > [global-handles] Remove dead code > > > > > > Bug: chromium:720477 > > > Change-Id: I090168c575c41b7038af5dfba6cd8973d1154c51 > > > Reviewed-on: https://chromium-review.googlesource.com/501790 > > > Reviewed-by: Hannes Payer <hpayer@chromium.org> > > > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#45241} > > > > TBR=hpayer@chromium.org,mlippautz@chromium.org,jochen@chromium.org > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > Bug: chromium:720477 > > > > Change-Id: I92f40d8c4dbfdb5208b3068648612e8c5b97fb20 > > Reviewed-on: https://chromium-review.googlesource.com/502029 > > Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> > > Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#45243} > > TBR=hpayer@chromium.org,gdeepti@chromium.org,mlippautz@chromium.org,jochen@chromium.org,v8-reviews@googlegroups.com > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > Bug: chromium:720477 > > Change-Id: I70e190e0c27074228a8128aa849e5a419af915e8 > Reviewed-on: https://chromium-review.googlesource.com/502030 > Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> > Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> > Cr-Commit-Position: refs/heads/master@{#45244} TBR=hpayer@chromium.org,gdeepti@chromium.org,mlippautz@chromium.org,jochen@chromium.org,v8-reviews@googlegroups.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Bug: chromium:720477 Change-Id: If3e4abea51d87546e25076b906a4c91e5ccf947b Reviewed-on: https://chromium-review.googlesource.com/503007 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#45246} [modify] https://crrev.com/682d5369b810929d0fbd3d7704742400b0e95559/src/global-handles.cc [modify] https://crrev.com/682d5369b810929d0fbd3d7704742400b0e95559/src/global-handles.h [modify] https://crrev.com/682d5369b810929d0fbd3d7704742400b0e95559/src/heap/heap.cc [modify] https://crrev.com/682d5369b810929d0fbd3d7704742400b0e95559/src/heap/mark-compact.cc
,
May 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/682d5369b810929d0fbd3d7704742400b0e95559 commit 682d5369b810929d0fbd3d7704742400b0e95559 Author: Michael Lippautz <mlippautz@chromium.org> Date: Thu May 11 05:59:00 2017 Revert "Revert "Revert "[global-handles] Remove dead code""" This reverts commit c836a95e87a9d8a13b057a3acf90c75650906a3e. Reason for revert: I don't think this was related. Original change's description: > Revert "Revert "[global-handles] Remove dead code"" > > This reverts commit 58020872dce50cb53dcc8ce5be8cc0243c759e0c. > > Reason for revert: Turned out to be a bot issue, reverting the revert. > > Original change's description: > > Revert "[global-handles] Remove dead code" > > > > This reverts commit e2890c19a70376686f025119082cfad6676a2f7b. > > > > Reason for revert: Looks like this CL causes slowdown on multiple builders, Check tests timeout and raise exceptions on the bot. Possible it is a bot issue as well, see tracking bug - https://bugs.chromium.org/p/chromium/issues/detail?id=720606 > > > > Original change's description: > > > [global-handles] Remove dead code > > > > > > Bug: chromium:720477 > > > Change-Id: I090168c575c41b7038af5dfba6cd8973d1154c51 > > > Reviewed-on: https://chromium-review.googlesource.com/501790 > > > Reviewed-by: Hannes Payer <hpayer@chromium.org> > > > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#45241} > > > > TBR=hpayer@chromium.org,mlippautz@chromium.org,jochen@chromium.org > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > Bug: chromium:720477 > > > > Change-Id: I92f40d8c4dbfdb5208b3068648612e8c5b97fb20 > > Reviewed-on: https://chromium-review.googlesource.com/502029 > > Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> > > Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#45243} > > TBR=hpayer@chromium.org,gdeepti@chromium.org,mlippautz@chromium.org,jochen@chromium.org,v8-reviews@googlegroups.com > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > Bug: chromium:720477 > > Change-Id: I70e190e0c27074228a8128aa849e5a419af915e8 > Reviewed-on: https://chromium-review.googlesource.com/502030 > Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> > Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> > Cr-Commit-Position: refs/heads/master@{#45244} TBR=hpayer@chromium.org,gdeepti@chromium.org,mlippautz@chromium.org,jochen@chromium.org,v8-reviews@googlegroups.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Bug: chromium:720477 Change-Id: If3e4abea51d87546e25076b906a4c91e5ccf947b Reviewed-on: https://chromium-review.googlesource.com/503007 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#45246} [modify] https://crrev.com/682d5369b810929d0fbd3d7704742400b0e95559/src/global-handles.cc [modify] https://crrev.com/682d5369b810929d0fbd3d7704742400b0e95559/src/global-handles.h [modify] https://crrev.com/682d5369b810929d0fbd3d7704742400b0e95559/src/heap/heap.cc [modify] https://crrev.com/682d5369b810929d0fbd3d7704742400b0e95559/src/heap/mark-compact.cc
,
May 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/682d5369b810929d0fbd3d7704742400b0e95559 commit 682d5369b810929d0fbd3d7704742400b0e95559 Author: Michael Lippautz <mlippautz@chromium.org> Date: Thu May 11 05:59:00 2017 Revert "Revert "Revert "[global-handles] Remove dead code""" This reverts commit c836a95e87a9d8a13b057a3acf90c75650906a3e. Reason for revert: I don't think this was related. Original change's description: > Revert "Revert "[global-handles] Remove dead code"" > > This reverts commit 58020872dce50cb53dcc8ce5be8cc0243c759e0c. > > Reason for revert: Turned out to be a bot issue, reverting the revert. > > Original change's description: > > Revert "[global-handles] Remove dead code" > > > > This reverts commit e2890c19a70376686f025119082cfad6676a2f7b. > > > > Reason for revert: Looks like this CL causes slowdown on multiple builders, Check tests timeout and raise exceptions on the bot. Possible it is a bot issue as well, see tracking bug - https://bugs.chromium.org/p/chromium/issues/detail?id=720606 > > > > Original change's description: > > > [global-handles] Remove dead code > > > > > > Bug: chromium:720477 > > > Change-Id: I090168c575c41b7038af5dfba6cd8973d1154c51 > > > Reviewed-on: https://chromium-review.googlesource.com/501790 > > > Reviewed-by: Hannes Payer <hpayer@chromium.org> > > > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#45241} > > > > TBR=hpayer@chromium.org,mlippautz@chromium.org,jochen@chromium.org > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > Bug: chromium:720477 > > > > Change-Id: I92f40d8c4dbfdb5208b3068648612e8c5b97fb20 > > Reviewed-on: https://chromium-review.googlesource.com/502029 > > Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> > > Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#45243} > > TBR=hpayer@chromium.org,gdeepti@chromium.org,mlippautz@chromium.org,jochen@chromium.org,v8-reviews@googlegroups.com > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > Bug: chromium:720477 > > Change-Id: I70e190e0c27074228a8128aa849e5a419af915e8 > Reviewed-on: https://chromium-review.googlesource.com/502030 > Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> > Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> > Cr-Commit-Position: refs/heads/master@{#45244} TBR=hpayer@chromium.org,gdeepti@chromium.org,mlippautz@chromium.org,jochen@chromium.org,v8-reviews@googlegroups.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Bug: chromium:720477 Change-Id: If3e4abea51d87546e25076b906a4c91e5ccf947b Reviewed-on: https://chromium-review.googlesource.com/503007 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#45246} [modify] https://crrev.com/682d5369b810929d0fbd3d7704742400b0e95559/src/global-handles.cc [modify] https://crrev.com/682d5369b810929d0fbd3d7704742400b0e95559/src/global-handles.h [modify] https://crrev.com/682d5369b810929d0fbd3d7704742400b0e95559/src/heap/heap.cc [modify] https://crrev.com/682d5369b810929d0fbd3d7704742400b0e95559/src/heap/mark-compact.cc
,
May 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/7a88f72946b28a45f04d5a9b53e348af2eef69d5 commit 7a88f72946b28a45f04d5a9b53e348af2eef69d5 Author: Michael Lippautz <mlippautz@chromium.org> Date: Thu May 11 14:26:37 2017 Revert "Revert "Revert "Revert "[global-handles] Remove dead code"""" This reverts commit 682d5369b810929d0fbd3d7704742400b0e95559. Reason for revert: Didn't see that this was the Reland... now we should be in good state. Original change's description: > Revert "Revert "Revert "[global-handles] Remove dead code""" > > This reverts commit c836a95e87a9d8a13b057a3acf90c75650906a3e. > > Reason for revert: I don't think this was related. > > Original change's description: > > Revert "Revert "[global-handles] Remove dead code"" > > > > This reverts commit 58020872dce50cb53dcc8ce5be8cc0243c759e0c. > > > > Reason for revert: Turned out to be a bot issue, reverting the revert. > > > > Original change's description: > > > Revert "[global-handles] Remove dead code" > > > > > > This reverts commit e2890c19a70376686f025119082cfad6676a2f7b. > > > > > > Reason for revert: Looks like this CL causes slowdown on multiple builders, Check tests timeout and raise exceptions on the bot. Possible it is a bot issue as well, see tracking bug - https://bugs.chromium.org/p/chromium/issues/detail?id=720606 > > > > > > Original change's description: > > > > [global-handles] Remove dead code > > > > > > > > Bug: chromium:720477 > > > > Change-Id: I090168c575c41b7038af5dfba6cd8973d1154c51 > > > > Reviewed-on: https://chromium-review.googlesource.com/501790 > > > > Reviewed-by: Hannes Payer <hpayer@chromium.org> > > > > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#45241} > > > > > > TBR=hpayer@chromium.org,mlippautz@chromium.org,jochen@chromium.org > > > NOPRESUBMIT=true > > > NOTREECHECKS=true > > > NOTRY=true > > > Bug: chromium:720477 > > > > > > Change-Id: I92f40d8c4dbfdb5208b3068648612e8c5b97fb20 > > > Reviewed-on: https://chromium-review.googlesource.com/502029 > > > Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> > > > Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#45243} > > > > TBR=hpayer@chromium.org,gdeepti@chromium.org,mlippautz@chromium.org,jochen@chromium.org,v8-reviews@googlegroups.com > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > Bug: chromium:720477 > > > > Change-Id: I70e190e0c27074228a8128aa849e5a419af915e8 > > Reviewed-on: https://chromium-review.googlesource.com/502030 > > Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> > > Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#45244} > > TBR=hpayer@chromium.org,gdeepti@chromium.org,mlippautz@chromium.org,jochen@chromium.org,v8-reviews@googlegroups.com > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > Bug: chromium:720477 > > Change-Id: If3e4abea51d87546e25076b906a4c91e5ccf947b > Reviewed-on: https://chromium-review.googlesource.com/503007 > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#45246} TBR=hpayer@chromium.org,gdeepti@chromium.org,mlippautz@chromium.org,jochen@chromium.org,v8-reviews@googlegroups.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Bug: chromium:720477 Change-Id: Id7dc886cc20b3b36ca5bb643686fe4fe2e98a3a7 Reviewed-on: https://chromium-review.googlesource.com/503008 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#45261} [modify] https://crrev.com/7a88f72946b28a45f04d5a9b53e348af2eef69d5/src/global-handles.cc [modify] https://crrev.com/7a88f72946b28a45f04d5a9b53e348af2eef69d5/src/global-handles.h [modify] https://crrev.com/7a88f72946b28a45f04d5a9b53e348af2eef69d5/src/heap/heap.cc [modify] https://crrev.com/7a88f72946b28a45f04d5a9b53e348af2eef69d5/src/heap/mark-compact.cc
,
May 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/652c9522d3116faf9e8ba260dbc215462f380bd1 commit 652c9522d3116faf9e8ba260dbc215462f380bd1 Author: Michael Lippautz <mlippautz@chromium.org> Date: Mon May 22 13:31:41 2017 [heap] MinorMC: Identify unmodified global handles on the fly For the Scavenger we require a first pass over global handles for identifying unmodified nodes because the Scavenger might have already written forwarding pointers during scanning, making it hard to perform the proper checks. The minor MC does not mutate the object graph during marking and can thus merge this phase into the regular phase executed during marking roots. Furthermore, moves processing into the parallel marking phase of the minor MC collector. Bug: chromium:720477 , chromium:651354 Change-Id: Id33552124264e3ab0bdf34d22ac30c19c1522707 Reviewed-on: https://chromium-review.googlesource.com/509550 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#45461} [modify] https://crrev.com/652c9522d3116faf9e8ba260dbc215462f380bd1/src/global-handles.cc [modify] https://crrev.com/652c9522d3116faf9e8ba260dbc215462f380bd1/src/global-handles.h [modify] https://crrev.com/652c9522d3116faf9e8ba260dbc215462f380bd1/src/globals.h [modify] https://crrev.com/652c9522d3116faf9e8ba260dbc215462f380bd1/src/heap/gc-tracer.cc [modify] https://crrev.com/652c9522d3116faf9e8ba260dbc215462f380bd1/src/heap/gc-tracer.h [modify] https://crrev.com/652c9522d3116faf9e8ba260dbc215462f380bd1/src/heap/heap.cc [modify] https://crrev.com/652c9522d3116faf9e8ba260dbc215462f380bd1/src/heap/heap.h [modify] https://crrev.com/652c9522d3116faf9e8ba260dbc215462f380bd1/src/heap/mark-compact.cc [modify] https://crrev.com/652c9522d3116faf9e8ba260dbc215462f380bd1/src/objects.cc [modify] https://crrev.com/652c9522d3116faf9e8ba260dbc215462f380bd1/src/objects.h
,
Nov 30
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, May 10 2017