Remove DataLog / PrintStream |
|||||||||
Issue descriptionWTF has a PrintStream abstraction that isn't used a lot. Its main use seems to be in DataLog via the FilePrintStream subclass, but dataLog() isn't used very much either. It can probably be replaced just via fprintf() or maybe base's LOG stuff. This would allow us to delete ~450 lines of code for PrintStream/FilePrintStream/DataLog.
,
May 10 2017
BTW, [1] says "keep" for DataLog. [1] https://docs.google.com/spreadsheets/d/1-OyE2MgypFI5B-GfqFGRLgPtpa_aBaFC_uyh9rdIq3g/edit#gid=0 yutak@, what do you think?
,
May 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f4097d86ffef927e2d617a07e4bee2ad9ec31cbc commit f4097d86ffef927e2d617a07e4bee2ad9ec31cbc Author: thakis <thakis@chromium.org> Date: Thu May 11 22:49:50 2017 Remove dead macros BUG=675877, 720442 Review-Url: https://codereview.chromium.org/2872273004 Cr-Commit-Position: refs/heads/master@{#471100} [modify] https://crrev.com/f4097d86ffef927e2d617a07e4bee2ad9ec31cbc/third_party/WebKit/Source/platform/wtf/PrintStream.h
,
May 12 2017
Well, I don't precisely remember why I said KEEP for this, but if we can remove all the call sites, I'm actually happy to get them removed. DataLog/PrintStream is a weird form of logging, and we really should use DVLOG() or similar for this.
,
Jan 5 2018
I'll take a look at this :) Removing things from WTF sounds good.
,
Jan 5 2018
,
Feb 2 2018
Had some WIP patches, but shifting focus now to work on ChromeOS: https://chromium-review.googlesource.com/866280 https://chromium-review.googlesource.com/866281 https://chromium-review.googlesource.com/866282
,
Feb 2 2018
,
Mar 19 2018
,
Mar 19 2018
PrintStream is now gone (and DataLogF just forwards to vfprintf): https://chromium.googlesource.com/chromium/src/+/eb319ef351f3b12ff5d1456ea84c8c000437704c Not clear to me how valuable the remainder of DataLog is (though it's not too hard to rig up again after killing it if someone wants to).
,
Mar 20 2018
We should replace the remainder of DataLog with base/logging.h, and remove it. Add Blink>MemoryAllocator>GC because platform/heap/ uses DataLog a lot.
,
Mar 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8da8c0ec223b33963b389ab3ed08be226adcadcc commit 8da8c0ec223b33963b389ab3ed08be226adcadcc Author: Kent Tamura <tkent@chromium.org> Date: Thu Mar 22 07:24:42 2018 Deprecate platform/wtf/DataLog.* - Rename DataLogF() to DeprecatedDataLogF(). - Remove commented-out code in Heap.cpp - Prevent us from adding new dependencies on DataLog.h This CL has no behavior changes. Bug: 720442 Change-Id: I188ef5a69f3426b8b49eea508e50f68fa744f7a0 Reviewed-on: https://chromium-review.googlesource.com/974807 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#545001} [modify] https://crrev.com/8da8c0ec223b33963b389ab3ed08be226adcadcc/third_party/WebKit/Source/DEPS [modify] https://crrev.com/8da8c0ec223b33963b389ab3ed08be226adcadcc/third_party/WebKit/Source/platform/heap/Heap.cpp [modify] https://crrev.com/8da8c0ec223b33963b389ab3ed08be226adcadcc/third_party/WebKit/Source/platform/heap/HeapCompact.h [modify] https://crrev.com/8da8c0ec223b33963b389ab3ed08be226adcadcc/third_party/WebKit/Source/platform/wtf/DataLog.cpp [modify] https://crrev.com/8da8c0ec223b33963b389ab3ed08be226adcadcc/third_party/WebKit/Source/platform/wtf/DataLog.h [modify] https://crrev.com/8da8c0ec223b33963b389ab3ed08be226adcadcc/third_party/WebKit/Source/platform/wtf/HashTable.cpp [modify] https://crrev.com/8da8c0ec223b33963b389ab3ed08be226adcadcc/third_party/WebKit/Source/platform/wtf/text/WTFString.cpp
,
Mar 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/93bd4f78e543d50840216a05553d9513d470c101 commit 93bd4f78e543d50840216a05553d9513d470c101 Author: Kent Tamura <tkent@chromium.org> Date: Fri Mar 23 04:24:35 2018 Remove DeprecatedDataLogF() usage in HashTable.cpp. This CL replaces DeprecatedDataLogF() in HashTable.cpp with DLOG(INFO). The output of DumpStats() will be changed as follows: Before this CL: ---------------------------------------------------------------- WTF::HashTable statistics 31 accesses 2 total collisions, average 1.06 probes per access longest collision chain: 2 1 lookups with exactly 1 collisions (0.00% , 3.23% with this many or more) 1 lookups with exactly 2 collisions (3.23% , 3.23% with this many or more) 2 rehashes 4 reinserts ---------------------------------------------------------------- After this CL: ---------------------------------------------------------------- [2685:85251:0323/103901.981197:INFO:HashTable.cpp(84)] WTF::HashTable statistics: 31 accesses 2 total collisions, average 1.06 probes per access longest collision chain: 2 1 lookups with exactly 1 collisions (0.00% , 3.23% with this many or more) 1 lookups with exactly 2 collisions (3.23% , 3.23% with this many or more) 2 rehashes 4 reinserts ---------------------------------------------------------------- Bug: 720442 Change-Id: Idc2bee40a770e50a552cbb84d84722ece0630b52 Reviewed-on: https://chromium-review.googlesource.com/977182 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#545366} [modify] https://crrev.com/93bd4f78e543d50840216a05553d9513d470c101/third_party/WebKit/Source/platform/wtf/HashTable.cpp
,
Mar 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/de039a5206d1ff4a0cf9ab2ee2ae639d67ca19e7 commit de039a5206d1ff4a0cf9ab2ee2ae639d67ca19e7 Author: Kent Tamura <tkent@chromium.org> Date: Fri Mar 23 04:25:01 2018 Remove DeprecatedDataLogF() usage in WTFString.cpp. String::Show() uses operator<< instead. Bug: 720442 Change-Id: I2053f3c12f81bd0f30c164cda3b409f0cb1fd593 Reviewed-on: https://chromium-review.googlesource.com/977185 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#545367} [modify] https://crrev.com/de039a5206d1ff4a0cf9ab2ee2ae639d67ca19e7/third_party/WebKit/Source/platform/wtf/text/WTFString.cpp
,
Mar 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/95767e0e0acab6579466b07cd8003185cc892253 commit 95767e0e0acab6579466b07cd8003185cc892253 Author: Kent Tamura <tkent@chromium.org> Date: Mon Mar 26 00:57:02 2018 Remove wtf/DataLog.* Remove DeprecatedDataLogF() usage from platform/heap/. Bug: 720442 Change-Id: Iac1a3ca91c932001ecb7f0e6beee3842108668c1 Reviewed-on: https://chromium-review.googlesource.com/977843 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#545719} [modify] https://crrev.com/95767e0e0acab6579466b07cd8003185cc892253/third_party/WebKit/Source/DEPS [modify] https://crrev.com/95767e0e0acab6579466b07cd8003185cc892253/third_party/WebKit/Source/platform/heap/HeapCompact.cpp [modify] https://crrev.com/95767e0e0acab6579466b07cd8003185cc892253/third_party/WebKit/Source/platform/heap/HeapCompact.h [modify] https://crrev.com/95767e0e0acab6579466b07cd8003185cc892253/third_party/WebKit/Source/platform/heap/HeapPage.cpp [modify] https://crrev.com/95767e0e0acab6579466b07cd8003185cc892253/third_party/WebKit/Source/platform/wtf/BUILD.gn [delete] https://crrev.com/90eb1cdab80ae3e7d0d3b1391f574fd04b30f249/third_party/WebKit/Source/platform/wtf/DataLog.cpp [delete] https://crrev.com/90eb1cdab80ae3e7d0d3b1391f574fd04b30f249/third_party/WebKit/Source/platform/wtf/DataLog.h
,
Mar 26 2018
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by tkent@chromium.org
, May 10 2017