New issue
Advanced search Search tips

Issue 720386 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 705974



Sign in to add a comment

VEA unittest: VP8 EncoderPerf failing on veyrons

Project Member Reported by wuchengli@chromium.org, May 10 2017

Issue description

VP8 EncoderPerf has a high failing rate on veyrons. The FPS is only around 26-30. Let's disable EncoderPerf for veyrons in video_VideoEncodeAccelerator because we don't have time to fix it and it may hide new failures. 

veyron_minnie-release/R60-9465.0.0/video/video_VideoEncodeAccelerator.vp8

  [----------] 1 test from EncoderPerf/VideoEncodeAcceleratorTest
  [ RUN      ] EncoderPerf/VideoEncodeAcceleratorTest.TestSimpleEncode/0
  ../../../../../../../home/chrome-bot/chrome_root/src/media/gpu/video_encode_accelerator_unittest.cc:1754: Failure
  Expected: (frames_per_second()) >= (kMinPerfFPS), actual: 26.5828 vs 30
  [  FAILED  ] EncoderPerf/VideoEncodeAcceleratorTest.TestSimpleEncode/0, where GetParam() = (1, false, 0, false, true, false, false, false, false) (7589 ms)

Expected: (frames_per_second()) >= (kMinPerfFPS), actual: 29.3232 vs 30
Expected: (frames_per_second()) >= (kMinPerfFPS), actual: 27.059 vs 30
Expected: (frames_per_second()) >= (kMinPerfFPS), actual: 26.4476 vs 30
 
CL is waiting for commit-queue
https://chromium-review.googlesource.com/c/503329/
Project Member

Comment 2 by bugdroid1@chromium.org, May 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/908ed547567c6c2a4ce41e704a4dfa7f1b8b61ff

commit 908ed547567c6c2a4ce41e704a4dfa7f1b8b61ff
Author: Pin-chih Lin <johnylin@google.com>
Date: Fri May 19 20:57:48 2017

video_VideoEncodeAccelerator: disable EncoderPerf for veyron vp8

Add more functions for the blacklist. Use a pair (board, profile) to
indicate the key of blacklist.

Board key can now use Unix shell-type wildcards.

BUG= chromium:720386 
TEST=tested by veyron_minnie

Change-Id: Ic3b748fb1c5dd36a7ad0739303591cf2d5efa73a
Reviewed-on: https://chromium-review.googlesource.com/503329
Commit-Ready: Pin-chih Lin <johnylin@chromium.org>
Tested-by: Pin-chih Lin <johnylin@chromium.org>
Reviewed-by: Kuang-che Wu <kcwu@chromium.org>

[modify] https://crrev.com/908ed547567c6c2a4ce41e704a4dfa7f1b8b61ff/client/site_tests/video_VideoEncodeAccelerator/video_VideoEncodeAccelerator.py

Status: Fixed (was: Assigned)

Comment 4 by kcwu@chromium.org, May 22 2017

Status: Assigned (was: Fixed)
Keep open. Need to merge to older milestones later.

Comment 5 by kcwu@chromium.org, Jun 2 2017

Blocking: 705974
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 2 2017

Labels: merge-merged-release-R59-9460.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/4574afb754382f5d144aefe74a801c49162737f9

commit 4574afb754382f5d144aefe74a801c49162737f9
Author: Pin-chih Lin <johnylin@google.com>
Date: Fri Jun 02 12:58:34 2017

video_VideoEncodeAccelerator: disable EncoderPerf for veyron vp8

Add more functions for the blacklist. Use a pair (board, profile) to
indicate the key of blacklist.

Board key can now use Unix shell-type wildcards.

BUG= chromium:720386 
TEST=tested by veyron_minnie

Change-Id: Ic3b748fb1c5dd36a7ad0739303591cf2d5efa73a
Reviewed-on: https://chromium-review.googlesource.com/503329
Commit-Ready: Pin-chih Lin <johnylin@chromium.org>
Tested-by: Pin-chih Lin <johnylin@chromium.org>
Reviewed-by: Kuang-che Wu <kcwu@chromium.org>
(cherry picked from commit 908ed547567c6c2a4ce41e704a4dfa7f1b8b61ff)
Reviewed-on: https://chromium-review.googlesource.com/522272
Commit-Queue: Pin-chih Lin <johnylin@chromium.org>
Trybot-Ready: Pin-chih Lin <johnylin@chromium.org>

[modify] https://crrev.com/4574afb754382f5d144aefe74a801c49162737f9/client/site_tests/video_VideoEncodeAccelerator/video_VideoEncodeAccelerator.py

Status: Fixed (was: Assigned)

Sign in to add a comment