README in chromeos-hwid seems to be out of date? |
||||
Issue descriptionThis does not seem to mention v3 HWIDs. The instructions for creating a hardware id do not work since this script does not exist: ~/trunk/src/platform/factory_test_tools/hwid_tool It is now in a different place. But it seems that the arguments have changed also. bin/hwid generate But it is not clear from the help how to run it. This documentation should be updated.
,
May 10 2017
hwid_tool is v2. hwid is v3. And yes, the README should be updated.
,
May 10 2017
OK thanks. Please let me know when there are instructions, as I want to add a hwid for reef-uni (the unified-build version of reef)
,
May 10 2017
The usage of hwid utility and how to write HWID config file is now covered in https://chromium.googlesource.com/chromiumos/platform/factory/+/master/py/hwid/ . There's probably not too much to update in chromeos-hwid/README except explaining that to create the bundle you have to use ./create_bundle BOARD.
,
May 11 2017
I cannot see anything in the docs about how to create a new hardware ID. What am I missing? I would like to make reef-uni which is a copy of reef. The instructions in chromeos-hwid/README talk about versions of hardware ID but I cannot see info about what a version is. It tells me to use v2 but I can see v3 things in places. Should I use version 2? It says to run this, but it doesn't exist: ~/trunk/src/platform/factory_test_tools/hwid_tool I tried: $ ../factory/bin/hwid_tool -p v2 board_create REEFUNI usage: hwid_tool [-h] <sub-command> $ ./create_bundle REEFUNI ERROR: /mnt/host/source/src/platform/chromeos-hwid/v3/REEFUNI is not a valid package. I tried creating this CL but cannot generate the bundle, so I think that is wrong also: https://chrome-internal-review.googlesource.com/c/374329/
,
May 11 2017
> how to create a new hardware ID Do you mean you want a new HWID config file? Currently the process is to probe then generate with the database file, as the link I've given > I would like to make reef-uni which is a copy of reef. Is it just for testing, or will there be any real projects using it? We've come to the conclusion that HWID should be project-specific instead of overlay-specific, so we're planning to not merging multiple projects to it. > use version 2? Reef is v3. The process of creating v3 is described in https://chromium.googlesource.com/chromiumos/platform/factory/+/master/py/hwid/ > cros.factory.tools.build_board.BuildBoardException: Unknown board 'reefuni' Well that's probably due to how hwid utility finds boards today - using overlay. Definitely something we have to fix as well, for the incoming HWID split for projects.
,
May 11 2017
reef-uni is the unified-build version of reef, so I plan to migrate reef/pyro/snapper over to use this build. I am wondering whether I should just not have a hardware ID in this case (for overlay-reef-uni-private)? Is that allowed? GoldenEye expects one, but in fact each model in the build will have its own hardware ID.
,
May 11 2017
Re#8 I think for long term plan, we do want electro, basking, pyro, snappy to have their own HWID files - i.e., 4 different HWID files, because we've found that being easier to control and maintain, across different projects, OEMs and ODMs. That implies overlays should accept "having no HWID file". If you see problems (not sure where Golden eye expects one) feel free to file issues and either us or peng team should fix it.
,
May 11 2017
Perfect, thank you. I will try that.
,
May 13 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/chromeos-hwid/+/5a9d161193b1d6fcf3d371ed76821be876244c30 commit 5a9d161193b1d6fcf3d371ed76821be876244c30 Author: Hung-Te Lin <hungte@chromium.org> Date: Sat May 13 22:25:43 2017 |
||||
►
Sign in to add a comment |
||||
Comment 1 by sjg@chromium.org
, May 10 2017