New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 720360 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: ----

Blocked on:
issue 620323
issue 642600
issue 730711



Sign in to add a comment

Convert anonymous classes to lambdas

Project Member Reported by zpeng@chromium.org, May 10 2017

Issue description

At the moment each conversion adds about 20 bytes and 1100+ conversions also add 310 methods.

Waiting on crbug.com/620323
 

Comment 1 by zpeng@chromium.org, May 10 2017

Blocking: 642600

Comment 2 by zpeng@chromium.org, May 10 2017

Blockedon: 642600

Comment 3 by zpeng@chromium.org, May 10 2017

Components: Build

Comment 4 by zpeng@chromium.org, Jun 7 2017

Blockedon: 730711
Blocking: -642600
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94e3b77fc15953748807ce8df2e7e024cd4ff9cf

commit 94e3b77fc15953748807ce8df2e7e024cd4ff9cf
Author: Felix <zpeng@chromium.org>
Date: Wed Aug 09 14:46:58 2017

Convert Java anonymous classes to Java 8 lambdas (CL#1)

This CL converts some Java anonymous classes to Java 8 lambdas.

Bug:  720360 
Change-Id: I61cd857d7823857df882ec1c2c07592e3e3b2f72
Reviewed-on: https://chromium-review.googlesource.com/607307
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Felix <zpeng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492975}
[modify] https://crrev.com/94e3b77fc15953748807ce8df2e7e024cd4ff9cf/chrome/android/java/src/org/chromium/chrome/browser/download/ChromeDownloadDelegate.java
[modify] https://crrev.com/94e3b77fc15953748807ce8df2e7e024cd4ff9cf/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadController.java
[modify] https://crrev.com/94e3b77fc15953748807ce8df2e7e024cd4ff9cf/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
[modify] https://crrev.com/94e3b77fc15953748807ce8df2e7e024cd4ff9cf/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadPage.java
[modify] https://crrev.com/94e3b77fc15953748807ce8df2e7e024cd4ff9cf/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSheetContent.java
[modify] https://crrev.com/94e3b77fc15953748807ce8df2e7e024cd4ff9cf/chrome/android/java/src/org/chromium/chrome/browser/download/OMADownloadHandler.java
[modify] https://crrev.com/94e3b77fc15953748807ce8df2e7e024cd4ff9cf/chrome/android/javatests/src/org/chromium/chrome/browser/download/ChromeDownloadDelegateTest.java
[modify] https://crrev.com/94e3b77fc15953748807ce8df2e7e024cd4ff9cf/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadActivityTest.java
[modify] https://crrev.com/94e3b77fc15953748807ce8df2e7e024cd4ff9cf/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java
[modify] https://crrev.com/94e3b77fc15953748807ce8df2e7e024cd4ff9cf/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadNotificationServiceTest.java
[modify] https://crrev.com/94e3b77fc15953748807ce8df2e7e024cd4ff9cf/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadTest.java
[modify] https://crrev.com/94e3b77fc15953748807ce8df2e7e024cd4ff9cf/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadTestRule.java
[modify] https://crrev.com/94e3b77fc15953748807ce8df2e7e024cd4ff9cf/chrome/android/javatests/src/org/chromium/chrome/browser/download/MockDownloadNotificationService.java
[modify] https://crrev.com/94e3b77fc15953748807ce8df2e7e024cd4ff9cf/chrome/android/javatests/src/org/chromium/chrome/browser/download/SystemDownloadNotifierTest.java

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f55e3bdccce90e5750337d00ceb73964ab05e730

commit f55e3bdccce90e5750337d00ceb73964ab05e730
Author: Felix <zpeng@chromium.org>
Date: Fri Aug 11 19:57:18 2017

Convert Java anonymous classes to Java 8 lambdas (CL#3)

This CL converts some Java anonymous classes to Java 8 lambdas.

Java package:
org.chromium.chrome.browser.accessibility
org.chromium.chrome.browser.appmenu
org.chromium.chrome.browser.autofill

Bug:  720360 
Change-Id: I6081adf8c7069fda9ca82432805d4ae048383265
Reviewed-on: https://chromium-review.googlesource.com/608511
Commit-Queue: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493835}
[modify] https://crrev.com/f55e3bdccce90e5750337d00ceb73964ab05e730/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java
[modify] https://crrev.com/f55e3bdccce90e5750337d00ceb73964ab05e730/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java
[modify] https://crrev.com/f55e3bdccce90e5750337d00ceb73964ab05e730/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuDragHelper.java
[modify] https://crrev.com/f55e3bdccce90e5750337d00ceb73964ab05e730/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopupBridge.java
[modify] https://crrev.com/f55e3bdccce90e5750337d00ceb73964ab05e730/chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskBridge.java
[modify] https://crrev.com/f55e3bdccce90e5750337d00ceb73964ab05e730/chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskPrompt.java
[modify] https://crrev.com/f55e3bdccce90e5750337d00ceb73964ab05e730/chrome/android/java/src/org/chromium/chrome/browser/autofill/PasswordGenerationPopupBridge.java
[modify] https://crrev.com/f55e3bdccce90e5750337d00ceb73964ab05e730/chrome/android/javatests/src/org/chromium/chrome/browser/accessibility/FontSizePrefsTest.java
[modify] https://crrev.com/f55e3bdccce90e5750337d00ceb73964ab05e730/chrome/android/javatests/src/org/chromium/chrome/browser/appmenu/AppMenuTest.java
[modify] https://crrev.com/f55e3bdccce90e5750337d00ceb73964ab05e730/chrome/android/javatests/src/org/chromium/chrome/browser/appmenu/ChromeHomeAppMenuTest.java
[modify] https://crrev.com/f55e3bdccce90e5750337d00ceb73964ab05e730/chrome/android/javatests/src/org/chromium/chrome/browser/appmenu/DataSaverAppMenuTest.java
[modify] https://crrev.com/f55e3bdccce90e5750337d00ceb73964ab05e730/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillKeyboardAccessoryTest.java
[modify] https://crrev.com/f55e3bdccce90e5750337d00ceb73964ab05e730/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillPopupTest.java
[modify] https://crrev.com/f55e3bdccce90e5750337d00ceb73964ab05e730/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillPopupWithKeyboardTest.java
[modify] https://crrev.com/f55e3bdccce90e5750337d00ceb73964ab05e730/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTest.java
[modify] https://crrev.com/f55e3bdccce90e5750337d00ceb73964ab05e730/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTestHelper.java

Project Member

Comment 7 by bugdroid1@chromium.org, Aug 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07b03a34b3c4351687e742c743f89dce80fe815d

commit 07b03a34b3c4351687e742c743f89dce80fe815d
Author: Felix <zpeng@chromium.org>
Date: Fri Aug 11 20:00:14 2017

Convert Java anonymous classes to Java 8 lambdas (CL#2)

This CL converts some Java anonymous classes to Java 8 lambdas.

Java package:
org.chromium.chrome.browser.payments

Bug:  720360 
Change-Id: Ia230f33f54ea32a470da95a8186af7ba10dfb2de
Reviewed-on: https://chromium-review.googlesource.com/608510
Commit-Queue: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493837}
[modify] https://crrev.com/07b03a34b3c4351687e742c743f89dce80fe815d/chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java
[modify] https://crrev.com/07b03a34b3c4351687e742c743f89dce80fe815d/chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java
[modify] https://crrev.com/07b03a34b3c4351687e742c743f89dce80fe815d/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentApp.java
[modify] https://crrev.com/07b03a34b3c4351687e742c743f89dce80fe815d/chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java
[modify] https://crrev.com/07b03a34b3c4351687e742c743f89dce80fe815d/chrome/android/java/src/org/chromium/chrome/browser/payments/ContactEditor.java
[modify] https://crrev.com/07b03a34b3c4351687e742c743f89dce80fe815d/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/07b03a34b3c4351687e742c743f89dce80fe815d/chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentApp.java
[modify] https://crrev.com/07b03a34b3c4351687e742c743f89dce80fe815d/chrome/android/javatests/src/org/chromium/chrome/browser/payments/AndroidPaymentAppFinderTest.java
[modify] https://crrev.com/07b03a34b3c4351687e742c743f89dce80fe815d/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentManifestDownloaderTest.java
[modify] https://crrev.com/07b03a34b3c4351687e742c743f89dce80fe815d/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentManifestParserTest.java
[modify] https://crrev.com/07b03a34b3c4351687e742c743f89dce80fe815d/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCanMakePaymentMetricsTest.java
[modify] https://crrev.com/07b03a34b3c4351687e742c743f89dce80fe815d/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCardEditorAutoAdvanceTest.java
[modify] https://crrev.com/07b03a34b3c4351687e742c743f89dce80fe815d/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsTest.java
[modify] https://crrev.com/07b03a34b3c4351687e742c743f89dce80fe815d/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestDynamicShippingSingleAddressTest.java
[modify] https://crrev.com/07b03a34b3c4351687e742c743f89dce80fe815d/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestFreeShippingTest.java
[modify] https://crrev.com/07b03a34b3c4351687e742c743f89dce80fe815d/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMetricsTest.java
[modify] https://crrev.com/07b03a34b3c4351687e742c743f89dce80fe815d/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNoShippingTest.java
[modify] https://crrev.com/07b03a34b3c4351687e742c743f89dce80fe815d/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPaymentAppTest.java
[modify] https://crrev.com/07b03a34b3c4351687e742c743f89dce80fe815d/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPaymentAppsSortingTest.java
[modify] https://crrev.com/07b03a34b3c4351687e742c743f89dce80fe815d/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestServiceWorkerPaymentAppTest.java
[modify] https://crrev.com/07b03a34b3c4351687e742c743f89dce80fe815d/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTabTest.java
[modify] https://crrev.com/07b03a34b3c4351687e742c743f89dce80fe815d/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestCommon.java

Project Member

Comment 8 by bugdroid1@chromium.org, Aug 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee8a184e09aaff705228fd0c3f831d03aff6ac6d

commit ee8a184e09aaff705228fd0c3f831d03aff6ac6d
Author: Felix <zpeng@chromium.org>
Date: Tue Aug 15 15:10:14 2017

Convert Java anonymous classes to Java 8 lambdas (CL#4)

This CL converts some Java anonymous classes to Java 8 lambdas.

Java package:
org.chromium.android_webview
org.chromium.android_webview.crash
org.chromium.android_webview.shell
org.chromium.android_webview.test.crash
org.chromium.android_webview.test.util

Bug:  720360 
Change-Id: Ia46e1b9545dd8a9eef161a14e66e119172fa4577
Reviewed-on: https://chromium-review.googlesource.com/612428
Commit-Queue: Felix <zpeng@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494381}
[modify] https://crrev.com/ee8a184e09aaff705228fd0c3f831d03aff6ac6d/android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java
[modify] https://crrev.com/ee8a184e09aaff705228fd0c3f831d03aff6ac6d/android_webview/java/src/org/chromium/android_webview/AwContents.java
[modify] https://crrev.com/ee8a184e09aaff705228fd0c3f831d03aff6ac6d/android_webview/java/src/org/chromium/android_webview/AwContentsClientBridge.java
[modify] https://crrev.com/ee8a184e09aaff705228fd0c3f831d03aff6ac6d/android_webview/java/src/org/chromium/android_webview/AwContentsStatics.java
[modify] https://crrev.com/ee8a184e09aaff705228fd0c3f831d03aff6ac6d/android_webview/java/src/org/chromium/android_webview/AwCookieManager.java
[modify] https://crrev.com/ee8a184e09aaff705228fd0c3f831d03aff6ac6d/android_webview/java/src/org/chromium/android_webview/AwGLFunctor.java
[modify] https://crrev.com/ee8a184e09aaff705228fd0c3f831d03aff6ac6d/android_webview/java/src/org/chromium/android_webview/AwGeolocationPermissions.java
[modify] https://crrev.com/ee8a184e09aaff705228fd0c3f831d03aff6ac6d/android_webview/java/src/org/chromium/android_webview/AwPrintDocumentAdapter.java
[modify] https://crrev.com/ee8a184e09aaff705228fd0c3f831d03aff6ac6d/android_webview/java/src/org/chromium/android_webview/AwSafeBrowsingConfigHelper.java
[modify] https://crrev.com/ee8a184e09aaff705228fd0c3f831d03aff6ac6d/android_webview/java/src/org/chromium/android_webview/AwSettings.java
[modify] https://crrev.com/ee8a184e09aaff705228fd0c3f831d03aff6ac6d/android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java
[modify] https://crrev.com/ee8a184e09aaff705228fd0c3f831d03aff6ac6d/android_webview/java/src/org/chromium/android_webview/AwWebContentsObserver.java
[modify] https://crrev.com/ee8a184e09aaff705228fd0c3f831d03aff6ac6d/android_webview/java/src/org/chromium/android_webview/DefaultVideoPosterRequestHandler.java
[modify] https://crrev.com/ee8a184e09aaff705228fd0c3f831d03aff6ac6d/android_webview/java/src/org/chromium/android_webview/JsResultHandler.java
[modify] https://crrev.com/ee8a184e09aaff705228fd0c3f831d03aff6ac6d/android_webview/java/src/org/chromium/android_webview/PopupTouchHandleDrawable.java
[modify] https://crrev.com/ee8a184e09aaff705228fd0c3f831d03aff6ac6d/android_webview/java/src/org/chromium/android_webview/crash/AwMinidumpUploaderDelegate.java
[modify] https://crrev.com/ee8a184e09aaff705228fd0c3f831d03aff6ac6d/android_webview/javatests/src/org/chromium/android_webview/test/crash/VisualStateCallbackTest.java
[modify] https://crrev.com/ee8a184e09aaff705228fd0c3f831d03aff6ac6d/android_webview/javatests/src/org/chromium/android_webview/test/util/AwQuotaManagerBridgeTestUtil.java
[modify] https://crrev.com/ee8a184e09aaff705228fd0c3f831d03aff6ac6d/android_webview/javatests/src/org/chromium/android_webview/test/util/AwTestTouchUtils.java
[modify] https://crrev.com/ee8a184e09aaff705228fd0c3f831d03aff6ac6d/android_webview/javatests/src/org/chromium/android_webview/test/util/CookieUtils.java
[modify] https://crrev.com/ee8a184e09aaff705228fd0c3f831d03aff6ac6d/android_webview/javatests/src/org/chromium/android_webview/test/util/GraphicsTestUtils.java
[modify] https://crrev.com/ee8a184e09aaff705228fd0c3f831d03aff6ac6d/android_webview/javatests/src/org/chromium/android_webview/test/util/JSUtils.java
[modify] https://crrev.com/ee8a184e09aaff705228fd0c3f831d03aff6ac6d/android_webview/javatests/src/org/chromium/android_webview/test/util/VideoSurfaceViewUtils.java
[modify] https://crrev.com/ee8a184e09aaff705228fd0c3f831d03aff6ac6d/android_webview/javatests/src/org/chromium/android_webview/test/util/VideoTestUtil.java
[modify] https://crrev.com/ee8a184e09aaff705228fd0c3f831d03aff6ac6d/android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellActivity.java

Project Member

Comment 9 by bugdroid1@chromium.org, Aug 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7faf2e7a5e949ac708dbab8e1874c86a3e5a1c94

commit 7faf2e7a5e949ac708dbab8e1874c86a3e5a1c94
Author: Andrew Grieve <agrieve@chromium.org>
Date: Wed Aug 16 15:54:38 2017

Make org.chromium.base.Callback work with lambdas

TBR=xhwang

Bug:  720360 
Change-Id: I5938a2638c3d611b8c38da6a1277c3fd87e6b67c
Reviewed-on: https://chromium-review.googlesource.com/616007
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494801}
[modify] https://crrev.com/7faf2e7a5e949ac708dbab8e1874c86a3e5a1c94/base/android/callback_android.cc
[modify] https://crrev.com/7faf2e7a5e949ac708dbab8e1874c86a3e5a1c94/base/android/java/src/org/chromium/base/Callback.java
[modify] https://crrev.com/7faf2e7a5e949ac708dbab8e1874c86a3e5a1c94/base/android/java/src/org/chromium/base/Promise.java
[modify] https://crrev.com/7faf2e7a5e949ac708dbab8e1874c86a3e5a1c94/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageViewHolder.java
[modify] https://crrev.com/7faf2e7a5e949ac708dbab8e1874c86a3e5a1c94/chrome/android/java/src/org/chromium/chrome/browser/services/AndroidEduAndChildAccountHelper.java
[modify] https://crrev.com/7faf2e7a5e949ac708dbab8e1874c86a3e5a1c94/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsBinder.java
[modify] https://crrev.com/7faf2e7a5e949ac708dbab8e1874c86a3e5a1c94/chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileGroup.java
[modify] https://crrev.com/7faf2e7a5e949ac708dbab8e1874c86a3e5a1c94/media/base/android/java/src/org/chromium/media/MediaDrmBridge.java

Project Member

Comment 10 by bugdroid1@chromium.org, Aug 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a706aeff8a3c379324eaed653087f558a7cf9bb

commit 0a706aeff8a3c379324eaed653087f558a7cf9bb
Author: Felix <zpeng@chromium.org>
Date: Thu Aug 17 20:48:29 2017

Convert Java anonymous classes to Java 8 lambdas (CL#6)

This CL converts some Java anonymous classes to Java 8 lambdas.

Java package:
org.chromium.chrome.browser

Bug:  720360 
Change-Id: Ibbd5e4e031da7908fea188e2370d594f60d99b88
Reviewed-on: https://chromium-review.googlesource.com/619011
Commit-Queue: Felix <zpeng@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495310}
[modify] https://crrev.com/0a706aeff8a3c379324eaed653087f558a7cf9bb/chrome/android/java/src/org/chromium/chrome/browser/ActivityTabTaskDescriptionHelper.java
[modify] https://crrev.com/0a706aeff8a3c379324eaed653087f558a7cf9bb/chrome/android/java/src/org/chromium/chrome/browser/AppHooks.java
[modify] https://crrev.com/0a706aeff8a3c379324eaed653087f558a7cf9bb/chrome/android/java/src/org/chromium/chrome/browser/BackgroundSyncLauncher.java
[modify] https://crrev.com/0a706aeff8a3c379324eaed653087f558a7cf9bb/chrome/android/java/src/org/chromium/chrome/browser/ChromeActionModeCallback.java
[modify] https://crrev.com/0a706aeff8a3c379324eaed653087f558a7cf9bb/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
[modify] https://crrev.com/0a706aeff8a3c379324eaed653087f558a7cf9bb/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivitySessionTracker.java
[modify] https://crrev.com/0a706aeff8a3c379324eaed653087f558a7cf9bb/chrome/android/java/src/org/chromium/chrome/browser/ChromeBackupAgent.java
[modify] https://crrev.com/0a706aeff8a3c379324eaed653087f558a7cf9bb/chrome/android/java/src/org/chromium/chrome/browser/ChromeBackupWatcher.java
[modify] https://crrev.com/0a706aeff8a3c379324eaed653087f558a7cf9bb/chrome/android/java/src/org/chromium/chrome/browser/ChromeStrictMode.java
[modify] https://crrev.com/0a706aeff8a3c379324eaed653087f558a7cf9bb/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
[modify] https://crrev.com/0a706aeff8a3c379324eaed653087f558a7cf9bb/chrome/android/java/src/org/chromium/chrome/browser/DeferredStartupHandler.java
[modify] https://crrev.com/0a706aeff8a3c379324eaed653087f558a7cf9bb/chrome/android/java/src/org/chromium/chrome/browser/DelayedScreenLockIntentHandler.java
[modify] https://crrev.com/0a706aeff8a3c379324eaed653087f558a7cf9bb/chrome/android/java/src/org/chromium/chrome/browser/FullscreenActivity.java
[modify] https://crrev.com/0a706aeff8a3c379324eaed653087f558a7cf9bb/chrome/android/java/src/org/chromium/chrome/browser/ItemChooserDialog.java
[modify] https://crrev.com/0a706aeff8a3c379324eaed653087f558a7cf9bb/chrome/android/java/src/org/chromium/chrome/browser/JavascriptAppModalDialog.java
[modify] https://crrev.com/0a706aeff8a3c379324eaed653087f558a7cf9bb/chrome/android/java/src/org/chromium/chrome/browser/LoginPrompt.java
[modify] https://crrev.com/0a706aeff8a3c379324eaed653087f558a7cf9bb/chrome/android/java/src/org/chromium/chrome/browser/NavigationPopup.java
[modify] https://crrev.com/0a706aeff8a3c379324eaed653087f558a7cf9bb/chrome/android/java/src/org/chromium/chrome/browser/RepostFormWarningDialog.java
[modify] https://crrev.com/0a706aeff8a3c379324eaed653087f558a7cf9bb/chrome/android/java/src/org/chromium/chrome/browser/SSLClientCertificateRequest.java
[modify] https://crrev.com/0a706aeff8a3c379324eaed653087f558a7cf9bb/chrome/android/java/src/org/chromium/chrome/browser/ServiceTabLauncher.java
[modify] https://crrev.com/0a706aeff8a3c379324eaed653087f558a7cf9bb/chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java
[modify] https://crrev.com/0a706aeff8a3c379324eaed653087f558a7cf9bb/chrome/android/java/src/org/chromium/chrome/browser/SwipeRefreshHandler.java
[modify] https://crrev.com/0a706aeff8a3c379324eaed653087f558a7cf9bb/chrome/android/java/src/org/chromium/chrome/browser/TabState.java
[modify] https://crrev.com/0a706aeff8a3c379324eaed653087f558a7cf9bb/chrome/android/java/src/org/chromium/chrome/browser/TtsPlatformImpl.java
[modify] https://crrev.com/0a706aeff8a3c379324eaed653087f558a7cf9bb/chrome/android/javatests/src/org/chromium/chrome/browser/BackgroundSyncLauncherTest.java
[modify] https://crrev.com/0a706aeff8a3c379324eaed653087f558a7cf9bb/chrome/android/javatests/src/org/chromium/chrome/browser/BindingManagerIntegrationTest.java
[modify] https://crrev.com/0a706aeff8a3c379324eaed653087f558a7cf9bb/chrome/android/javatests/src/org/chromium/chrome/browser/BluetoothChooserDialogTest.java
[modify] https://crrev.com/0a706aeff8a3c379324eaed653087f558a7cf9bb/chrome/android/javatests/src/org/chromium/chrome/browser/ChromeActivityTest.java
[modify] https://crrev.com/0a706aeff8a3c379324eaed653087f558a7cf9bb/chrome/android/javatests/src/org/chromium/chrome/browser/ChromeBackgroundServiceTest.java
[modify] https://crrev.com/0a706aeff8a3c379324eaed653087f558a7cf9bb/chrome/android/javatests/src/org/chromium/chrome/browser/ContentViewFocusTest.java
[modify] https://crrev.com/0a706aeff8a3c379324eaed653087f558a7cf9bb/chrome/android/javatests/src/org/chromium/chrome/browser/CopylessPasteTest.java
[modify] https://crrev.com/0a706aeff8a3c379324eaed653087f558a7cf9bb/chrome/android/javatests/src/org/chromium/chrome/browser/FullscreenActivityTest.java
[modify] https://crrev.com/0a706aeff8a3c379324eaed653087f558a7cf9bb/chrome/android/javatests/src/org/chromium/chrome/browser/ItemChooserDialogTest.java
[modify] https://crrev.com/0a706aeff8a3c379324eaed653087f558a7cf9bb/chrome/android/javatests/src/org/chromium/chrome/browser/ModalDialogTest.java
[modify] https://crrev.com/0a706aeff8a3c379324eaed653087f558a7cf9bb/chrome/android/javatests/src/org/chromium/chrome/browser/NavigateTest.java
[modify] https://crrev.com/0a706aeff8a3c379324eaed653087f558a7cf9bb/chrome/android/javatests/src/org/chromium/chrome/browser/NavigationPopupTest.java
[modify] https://crrev.com/0a706aeff8a3c379324eaed653087f558a7cf9bb/chrome/android/javatests/src/org/chromium/chrome/browser/OSKOverscrollTest.java
[modify] https://crrev.com/0a706aeff8a3c379324eaed653087f558a7cf9bb/chrome/android/javatests/src/org/chromium/chrome/browser/PopularUrlsTest.java
[modify] https://crrev.com/0a706aeff8a3c379324eaed653087f558a7cf9bb/chrome/android/javatests/src/org/chromium/chrome/browser/PopupTest.java
[modify] https://crrev.com/0a706aeff8a3c379324eaed653087f558a7cf9bb/chrome/android/javatests/src/org/chromium/chrome/browser/PowerBroadcastReceiverTest.java
[modify] https://crrev.com/0a706aeff8a3c379324eaed653087f558a7cf9bb/chrome/android/javatests/src/org/chromium/chrome/browser/PrerenderTest.java
[modify] https://crrev.com/0a706aeff8a3c379324eaed653087f558a7cf9bb/chrome/android/javatests/src/org/chromium/chrome/browser/RepostFormWarningTest.java
[modify] https://crrev.com/0a706aeff8a3c379324eaed653087f558a7cf9bb/chrome/android/javatests/src/org/chromium/chrome/browser/SelectFileDialogTest.java
[modify] https://crrev.com/0a706aeff8a3c379324eaed653087f558a7cf9bb/chrome/android/javatests/src/org/chromium/chrome/browser/ShareIntentTest.java
[modify] https://crrev.com/0a706aeff8a3c379324eaed653087f558a7cf9bb/chrome/android/javatests/src/org/chromium/chrome/browser/SmartClipProviderTest.java
[modify] https://crrev.com/0a706aeff8a3c379324eaed653087f558a7cf9bb/chrome/android/javatests/src/org/chromium/chrome/browser/TabTest.java
[modify] https://crrev.com/0a706aeff8a3c379324eaed653087f558a7cf9bb/chrome/android/javatests/src/org/chromium/chrome/browser/TabThemeTest.java
[modify] https://crrev.com/0a706aeff8a3c379324eaed653087f558a7cf9bb/chrome/android/javatests/src/org/chromium/chrome/browser/TabsOpenedFromExternalAppTest.java
[modify] https://crrev.com/0a706aeff8a3c379324eaed653087f558a7cf9bb/chrome/android/javatests/src/org/chromium/chrome/browser/TabsTest.java
[modify] https://crrev.com/0a706aeff8a3c379324eaed653087f558a7cf9bb/chrome/android/javatests/src/org/chromium/chrome/browser/UrlSchemeTest.java
[modify] https://crrev.com/0a706aeff8a3c379324eaed653087f558a7cf9bb/chrome/android/javatests/src/org/chromium/chrome/browser/UsbChooserDialogTest.java
[modify] https://crrev.com/0a706aeff8a3c379324eaed653087f558a7cf9bb/chrome/android/javatests/src/org/chromium/chrome/browser/VideoFullscreenOrientationLockChromeTest.java
[modify] https://crrev.com/0a706aeff8a3c379324eaed653087f558a7cf9bb/chrome/android/javatests/src/org/chromium/chrome/browser/WarmupManagerTest.java

Project Member

Comment 11 by bugdroid1@chromium.org, Aug 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e958be64e48aa2c2f681cb513202c9c99ecf8808

commit e958be64e48aa2c2f681cb513202c9c99ecf8808
Author: Felix <zpeng@chromium.org>
Date: Fri Aug 18 18:54:29 2017

Convert Java anonymous classes to Java 8 lambdas (CL#9)

This CL converts some Java anonymous classes to Java 8 lambdas.

Java package:
org.chromium.android_webview.test

Bug:  720360 
Change-Id: I698118b816fb86ac6213d4d0aa78acf02c31bd9b
Reviewed-on: https://chromium-review.googlesource.com/621487
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Felix <zpeng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495633}
[modify] https://crrev.com/e958be64e48aa2c2f681cb513202c9c99ecf8808/android_webview/javatests/src/org/chromium/android_webview/test/AndroidScrollIntegrationTest.java
[modify] https://crrev.com/e958be64e48aa2c2f681cb513202c9c99ecf8808/android_webview/javatests/src/org/chromium/android_webview/test/AndroidViewIntegrationTest.java
[modify] https://crrev.com/e958be64e48aa2c2f681cb513202c9c99ecf8808/android_webview/javatests/src/org/chromium/android_webview/test/ArchiveTest.java
[modify] https://crrev.com/e958be64e48aa2c2f681cb513202c9c99ecf8808/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientCallbackHelperTest.java
[modify] https://crrev.com/e958be64e48aa2c2f681cb513202c9c99ecf8808/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFaviconTest.java
[modify] https://crrev.com/e958be64e48aa2c2f681cb513202c9c99ecf8808/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFullScreenTest.java
[modify] https://crrev.com/e958be64e48aa2c2f681cb513202c9c99ecf8808/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientOnFormResubmissionTest.java
[modify] https://crrev.com/e958be64e48aa2c2f681cb513202c9c99ecf8808/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientOnScaleChangedTest.java
[modify] https://crrev.com/e958be64e48aa2c2f681cb513202c9c99ecf8808/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientOnUnhandledKeyEventTest.java
[modify] https://crrev.com/e958be64e48aa2c2f681cb513202c9c99ecf8808/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldInterceptRequestTest.java
[modify] https://crrev.com/e958be64e48aa2c2f681cb513202c9c99ecf8808/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldOverrideUrlLoadingTest.java
[modify] https://crrev.com/e958be64e48aa2c2f681cb513202c9c99ecf8808/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsGarbageCollectionTest.java
[modify] https://crrev.com/e958be64e48aa2c2f681cb513202c9c99ecf8808/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsLifecycleNotifierTest.java
[modify] https://crrev.com/e958be64e48aa2c2f681cb513202c9c99ecf8808/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsRenderTest.java
[modify] https://crrev.com/e958be64e48aa2c2f681cb513202c9c99ecf8808/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsStaticsTest.java
[modify] https://crrev.com/e958be64e48aa2c2f681cb513202c9c99ecf8808/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java
[modify] https://crrev.com/e958be64e48aa2c2f681cb513202c9c99ecf8808/android_webview/javatests/src/org/chromium/android_webview/test/AwFormDatabaseTest.java
[modify] https://crrev.com/e958be64e48aa2c2f681cb513202c9c99ecf8808/android_webview/javatests/src/org/chromium/android_webview/test/AwImeTest.java
[modify] https://crrev.com/e958be64e48aa2c2f681cb513202c9c99ecf8808/android_webview/javatests/src/org/chromium/android_webview/test/AwJavaBridgeTest.java
[modify] https://crrev.com/e958be64e48aa2c2f681cb513202c9c99ecf8808/android_webview/javatests/src/org/chromium/android_webview/test/AwLegacyQuirksTest.java
[modify] https://crrev.com/e958be64e48aa2c2f681cb513202c9c99ecf8808/android_webview/javatests/src/org/chromium/android_webview/test/AwPermissionManagerTest.java
[modify] https://crrev.com/e958be64e48aa2c2f681cb513202c9c99ecf8808/android_webview/javatests/src/org/chromium/android_webview/test/AwQuotaManagerBridgeTest.java
[modify] https://crrev.com/e958be64e48aa2c2f681cb513202c9c99ecf8808/android_webview/javatests/src/org/chromium/android_webview/test/AwSecondBrowserProcessTest.java
[modify] https://crrev.com/e958be64e48aa2c2f681cb513202c9c99ecf8808/android_webview/javatests/src/org/chromium/android_webview/test/AwServiceWorkerClientTest.java
[modify] https://crrev.com/e958be64e48aa2c2f681cb513202c9c99ecf8808/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java
[modify] https://crrev.com/e958be64e48aa2c2f681cb513202c9c99ecf8808/android_webview/javatests/src/org/chromium/android_webview/test/AwStrictModeTest.java
[modify] https://crrev.com/e958be64e48aa2c2f681cb513202c9c99ecf8808/android_webview/javatests/src/org/chromium/android_webview/test/AwTestCommon.java
[modify] https://crrev.com/e958be64e48aa2c2f681cb513202c9c99ecf8808/android_webview/javatests/src/org/chromium/android_webview/test/AwWebContentsObserverTest.java
[modify] https://crrev.com/e958be64e48aa2c2f681cb513202c9c99ecf8808/android_webview/javatests/src/org/chromium/android_webview/test/AwZoomTest.java
[modify] https://crrev.com/e958be64e48aa2c2f681cb513202c9c99ecf8808/android_webview/javatests/src/org/chromium/android_webview/test/CleanupReferenceTest.java
[modify] https://crrev.com/e958be64e48aa2c2f681cb513202c9c99ecf8808/android_webview/javatests/src/org/chromium/android_webview/test/ClientAddMessageToConsoleTest.java
[modify] https://crrev.com/e958be64e48aa2c2f681cb513202c9c99ecf8808/android_webview/javatests/src/org/chromium/android_webview/test/ClientOnPageFinishedTest.java
[modify] https://crrev.com/e958be64e48aa2c2f681cb513202c9c99ecf8808/android_webview/javatests/src/org/chromium/android_webview/test/ClientOnReceivedError2Test.java
[modify] https://crrev.com/e958be64e48aa2c2f681cb513202c9c99ecf8808/android_webview/javatests/src/org/chromium/android_webview/test/ContentViewMiscTest.java
[modify] https://crrev.com/e958be64e48aa2c2f681cb513202c9c99ecf8808/android_webview/javatests/src/org/chromium/android_webview/test/CookieManagerStartupTest.java
[modify] https://crrev.com/e958be64e48aa2c2f681cb513202c9c99ecf8808/android_webview/javatests/src/org/chromium/android_webview/test/CookieManagerTest.java
[modify] https://crrev.com/e958be64e48aa2c2f681cb513202c9c99ecf8808/android_webview/javatests/src/org/chromium/android_webview/test/GeolocationTest.java
[modify] https://crrev.com/e958be64e48aa2c2f681cb513202c9c99ecf8808/android_webview/javatests/src/org/chromium/android_webview/test/KeySystemTest.java
[modify] https://crrev.com/e958be64e48aa2c2f681cb513202c9c99ecf8808/android_webview/javatests/src/org/chromium/android_webview/test/LoadDataWithBaseUrlTest.java
[modify] https://crrev.com/e958be64e48aa2c2f681cb513202c9c99ecf8808/android_webview/javatests/src/org/chromium/android_webview/test/LoadUrlTest.java
[modify] https://crrev.com/e958be64e48aa2c2f681cb513202c9c99ecf8808/android_webview/javatests/src/org/chromium/android_webview/test/MediaAccessPermissionRequestTest.java
[modify] https://crrev.com/e958be64e48aa2c2f681cb513202c9c99ecf8808/android_webview/javatests/src/org/chromium/android_webview/test/NavigationHistoryTest.java
[modify] https://crrev.com/e958be64e48aa2c2f681cb513202c9c99ecf8808/android_webview/javatests/src/org/chromium/android_webview/test/PlatformMediaCodecTest.java
[modify] https://crrev.com/e958be64e48aa2c2f681cb513202c9c99ecf8808/android_webview/javatests/src/org/chromium/android_webview/test/PolicyUrlFilteringTest.java
[modify] https://crrev.com/e958be64e48aa2c2f681cb513202c9c99ecf8808/android_webview/javatests/src/org/chromium/android_webview/test/PopupWindowTest.java
[modify] https://crrev.com/e958be64e48aa2c2f681cb513202c9c99ecf8808/android_webview/javatests/src/org/chromium/android_webview/test/PostMessageTest.java
[modify] https://crrev.com/e958be64e48aa2c2f681cb513202c9c99ecf8808/android_webview/javatests/src/org/chromium/android_webview/test/SafeBrowsingTest.java
[modify] https://crrev.com/e958be64e48aa2c2f681cb513202c9c99ecf8808/android_webview/javatests/src/org/chromium/android_webview/test/SaveRestoreStateTest.java
[modify] https://crrev.com/e958be64e48aa2c2f681cb513202c9c99ecf8808/android_webview/javatests/src/org/chromium/android_webview/test/VisualStateTest.java
[modify] https://crrev.com/e958be64e48aa2c2f681cb513202c9c99ecf8808/android_webview/javatests/src/org/chromium/android_webview/test/WebKitHitTestTest.java
[modify] https://crrev.com/e958be64e48aa2c2f681cb513202c9c99ecf8808/android_webview/javatests/src/org/chromium/android_webview/test/WebViewAsynchronousFindApisTest.java
[modify] https://crrev.com/e958be64e48aa2c2f681cb513202c9c99ecf8808/android_webview/javatests/src/org/chromium/android_webview/test/WebViewFindApisTestBase.java
[modify] https://crrev.com/e958be64e48aa2c2f681cb513202c9c99ecf8808/android_webview/javatests/src/org/chromium/android_webview/test/WebViewWebVrTest.java
[modify] https://crrev.com/e958be64e48aa2c2f681cb513202c9c99ecf8808/android_webview/test/shell/src/org/chromium/android_webview/test/AwTestContainerView.java

Cc: nyquist@chromium.org yfried...@chromium.org boliu@chromium.org
Forgive me for being late to the party here, but why are we doing this?

Doing this mass conversion makes git blame pretty annoying for a large chunk of our code base.  When Chrome has updated their style guide, added support for new c++ 11 features, I don't think it was terribly common to go and do these massive updates.

I also argue that the readability of lambdas isn't always the best so doing complete conversions of all anonymous classes seems like a bit overreaching.  Since we've already landed non-trivial amounts of this, I guess I can't really reverse this, but I feel we should have gotten a more broad agreement about this before starting this.
Status: WontFix (was: Assigned)

Sign in to add a comment