New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 720345 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
EstimatedDays: 30
NextAction: ----
OS: Linux , Android , Windows , Mac
Pri: 3
Type: Bug

Blocking:
issue 596161



Sign in to add a comment

Clean up notification delegates

Project Member Reported by miguelg@chromium.org, May 10 2017

Issue description

A NotificationDelegate is only really needed when dealing with the message center, native notifications should not need to require delegates in their notification objects
 
Blocking: 596161
EstimatedDays: 30
Here is our high level strategy for this:

Phase 1: Native notifications
1: Split extension and non persistent handlers 
https://codereview.chromium.org/2875673002/

2: Upgrade https://cs.chromium.org/chromium/src/content/public/browser/notification_event_dispatcher.h to handle IPCs also for non persistent notifications. It will require keeping the a list of active renderers. At that point refactor the non_persistent notification handler to use the upgrade event dispatcher so that delegates are no longer needed for native notifications.

Phase 2: Message Center notifications:

We will not be able to fully get rid of delegates there but they can be created by the display service right before sending them to the message center so that none of the client code needs to use them.

1. Move the existing logic (including the handlers) from https://cs.chromium.org/chromium/src/chrome/browser/notifications/native_notification_display_service.h to the super class (which is now pure virtual but it will stop being so)

2. Get rid of message_center_display_service and make it implement the bridge interface instead. This will be the piece that creates the artificial delegates on demand when displaying right before sending them to the message center.




 
Project Member

Comment 3 by bugdroid1@chromium.org, May 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dcc699ff151393a7d2fa29314befd57d194b0f60

commit dcc699ff151393a7d2fa29314befd57d194b0f60
Author: miguelg <miguelg@chromium.org>
Date: Sat May 20 08:34:35 2017

Minimize the delegate dependencies for native extension notifications.

Support for events like click, close etc is now fully handled by the
ExtensionNotificationHandler like persistent web notifications.

The delegate is now just a little shim to hold the delegate id since it
is still required by the Notification class.

BUG=720345

Review-Url: https://codereview.chromium.org/2875673002
Cr-Commit-Position: refs/heads/master@{#473427}

[modify] https://crrev.com/dcc699ff151393a7d2fa29314befd57d194b0f60/chrome/browser/extensions/api/notifications/extension_notification_handler.cc
[modify] https://crrev.com/dcc699ff151393a7d2fa29314befd57d194b0f60/chrome/browser/extensions/api/notifications/extension_notification_handler.h
[add] https://crrev.com/dcc699ff151393a7d2fa29314befd57d194b0f60/chrome/browser/extensions/api/notifications/extension_notification_handler_unittest.cc
[modify] https://crrev.com/dcc699ff151393a7d2fa29314befd57d194b0f60/chrome/browser/extensions/api/notifications/notifications_api.cc
[modify] https://crrev.com/dcc699ff151393a7d2fa29314befd57d194b0f60/chrome/browser/extensions/api/notifications/notifications_apitest.cc
[modify] https://crrev.com/dcc699ff151393a7d2fa29314befd57d194b0f60/chrome/browser/notifications/native_notification_display_service.cc
[modify] https://crrev.com/dcc699ff151393a7d2fa29314befd57d194b0f60/chrome/test/BUILD.gn

Project Member

Comment 4 by bugdroid1@chromium.org, May 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/126e33d8b030ec43e0d1fe3a458da747c30bb7ab

commit 126e33d8b030ec43e0d1fe3a458da747c30bb7ab
Author: miguelg <miguelg@chromium.org>
Date: Wed May 31 20:34:07 2017

Remove unused method in the native display service

This is in preparation for moving all the handler related methods from
the native display service to the super class.

BUG=720345

Review-Url: https://codereview.chromium.org/2911653002
Cr-Commit-Position: refs/heads/master@{#476002}

[modify] https://crrev.com/126e33d8b030ec43e0d1fe3a458da747c30bb7ab/chrome/browser/notifications/native_notification_display_service.cc
[modify] https://crrev.com/126e33d8b030ec43e0d1fe3a458da747c30bb7ab/chrome/browser/notifications/native_notification_display_service.h

Project Member

Comment 5 by bugdroid1@chromium.org, Jun 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26f0196082493c3d5109f196828a8c5baf16005a

commit 26f0196082493c3d5109f196828a8c5baf16005a
Author: miguelg <miguelg@chromium.org>
Date: Fri Jun 02 14:51:09 2017

Minimize the delegate dependencies for non persistent notifications.

Upgrade NotificationEventDispatcher to support IPCs for non persistent notifications
as well as persistent ones.

Use the dispatcher directly from the handler.

After this patch land we will be able to use the same path for non native notifications and
get rid of the delegate #ifdefs

This work is happening in
https://codereview.chromium.org/2906913002#ps1
and
https://codereview.chromium.org/2906883003#ps1

BUG=720345

Review-Url: https://codereview.chromium.org/2888303004
Cr-Commit-Position: refs/heads/master@{#476646}

[modify] https://crrev.com/26f0196082493c3d5109f196828a8c5baf16005a/chrome/browser/BUILD.gn
[modify] https://crrev.com/26f0196082493c3d5109f196828a8c5baf16005a/chrome/browser/extensions/api/notifications/extension_notification_handler.cc
[modify] https://crrev.com/26f0196082493c3d5109f196828a8c5baf16005a/chrome/browser/extensions/api/notifications/extension_notification_handler.h
[modify] https://crrev.com/26f0196082493c3d5109f196828a8c5baf16005a/chrome/browser/extensions/api/notifications/notifications_api.cc
[add] https://crrev.com/26f0196082493c3d5109f196828a8c5baf16005a/chrome/browser/notifications/native_notification_delegate.cc
[add] https://crrev.com/26f0196082493c3d5109f196828a8c5baf16005a/chrome/browser/notifications/native_notification_delegate.h
[modify] https://crrev.com/26f0196082493c3d5109f196828a8c5baf16005a/chrome/browser/notifications/native_notification_display_service.cc
[modify] https://crrev.com/26f0196082493c3d5109f196828a8c5baf16005a/chrome/browser/notifications/non_persistent_notification_handler.cc
[modify] https://crrev.com/26f0196082493c3d5109f196828a8c5baf16005a/chrome/browser/notifications/non_persistent_notification_handler.h
[modify] https://crrev.com/26f0196082493c3d5109f196828a8c5baf16005a/chrome/browser/notifications/notification_handler.h
[modify] https://crrev.com/26f0196082493c3d5109f196828a8c5baf16005a/chrome/browser/notifications/notification_interactive_uitest_support.cc
[modify] https://crrev.com/26f0196082493c3d5109f196828a8c5baf16005a/chrome/browser/notifications/persistent_notification_handler.cc
[modify] https://crrev.com/26f0196082493c3d5109f196828a8c5baf16005a/chrome/browser/notifications/persistent_notification_handler.h
[modify] https://crrev.com/26f0196082493c3d5109f196828a8c5baf16005a/chrome/browser/notifications/platform_notification_service_impl.cc
[modify] https://crrev.com/26f0196082493c3d5109f196828a8c5baf16005a/chrome/browser/notifications/platform_notification_service_interactive_uitest.cc
[modify] https://crrev.com/26f0196082493c3d5109f196828a8c5baf16005a/chrome/browser/notifications/platform_notification_service_unittest.cc
[modify] https://crrev.com/26f0196082493c3d5109f196828a8c5baf16005a/content/browser/notifications/notification_event_dispatcher_impl.cc
[modify] https://crrev.com/26f0196082493c3d5109f196828a8c5baf16005a/content/browser/notifications/notification_event_dispatcher_impl.h
[modify] https://crrev.com/26f0196082493c3d5109f196828a8c5baf16005a/content/browser/notifications/notification_message_filter.cc
[modify] https://crrev.com/26f0196082493c3d5109f196828a8c5baf16005a/content/browser/notifications/notification_message_filter.h
[modify] https://crrev.com/26f0196082493c3d5109f196828a8c5baf16005a/content/public/browser/notification_event_dispatcher.h

Project Member

Comment 6 by bugdroid1@chromium.org, Jun 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/abf610aeffb664c95e67be217928d47f9f2ef3d0

commit abf610aeffb664c95e67be217928d47f9f2ef3d0
Author: miguelg <miguelg@chromium.org>
Date: Fri Jun 02 17:31:43 2017

Move handler processing to NotificationDisplayService.
Also added an OnShow event to the handler to propagate Display events

BUG=720345

Review-Url: https://codereview.chromium.org/2906913002
Cr-Commit-Position: refs/heads/master@{#476707}

[modify] https://crrev.com/abf610aeffb664c95e67be217928d47f9f2ef3d0/chrome/browser/BUILD.gn
[modify] https://crrev.com/abf610aeffb664c95e67be217928d47f9f2ef3d0/chrome/browser/extensions/api/notifications/extension_notification_handler.cc
[modify] https://crrev.com/abf610aeffb664c95e67be217928d47f9f2ef3d0/chrome/browser/extensions/api/notifications/extension_notification_handler.h
[modify] https://crrev.com/abf610aeffb664c95e67be217928d47f9f2ef3d0/chrome/browser/notifications/message_center_display_service.cc
[modify] https://crrev.com/abf610aeffb664c95e67be217928d47f9f2ef3d0/chrome/browser/notifications/native_notification_display_service.cc
[modify] https://crrev.com/abf610aeffb664c95e67be217928d47f9f2ef3d0/chrome/browser/notifications/native_notification_display_service.h
[modify] https://crrev.com/abf610aeffb664c95e67be217928d47f9f2ef3d0/chrome/browser/notifications/non_persistent_notification_handler.cc
[modify] https://crrev.com/abf610aeffb664c95e67be217928d47f9f2ef3d0/chrome/browser/notifications/non_persistent_notification_handler.h
[add] https://crrev.com/abf610aeffb664c95e67be217928d47f9f2ef3d0/chrome/browser/notifications/notification_display_service.cc
[modify] https://crrev.com/abf610aeffb664c95e67be217928d47f9f2ef3d0/chrome/browser/notifications/notification_display_service.h
[modify] https://crrev.com/abf610aeffb664c95e67be217928d47f9f2ef3d0/chrome/browser/notifications/notification_handler.h
[modify] https://crrev.com/abf610aeffb664c95e67be217928d47f9f2ef3d0/chrome/browser/notifications/notification_platform_bridge_android.cc
[modify] https://crrev.com/abf610aeffb664c95e67be217928d47f9f2ef3d0/chrome/browser/notifications/notification_platform_bridge_linux.cc
[modify] https://crrev.com/abf610aeffb664c95e67be217928d47f9f2ef3d0/chrome/browser/notifications/notification_platform_bridge_mac.mm
[modify] https://crrev.com/abf610aeffb664c95e67be217928d47f9f2ef3d0/chrome/browser/notifications/persistent_notification_handler.cc
[modify] https://crrev.com/abf610aeffb664c95e67be217928d47f9f2ef3d0/chrome/browser/notifications/persistent_notification_handler.h
[modify] https://crrev.com/abf610aeffb664c95e67be217928d47f9f2ef3d0/chrome/browser/notifications/stub_notification_display_service.cc
[modify] https://crrev.com/abf610aeffb664c95e67be217928d47f9f2ef3d0/chrome/browser/notifications/stub_notification_display_service.h

Project Member

Comment 7 by bugdroid1@chromium.org, Jun 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/40b10fd5dcb862ce08df81ef5c55c629f64c6394

commit 40b10fd5dcb862ce08df81ef5c55c629f64c6394
Author: miguelg <miguelg@chromium.org>
Date: Fri Jun 09 13:54:09 2017

Deprecate per notification type delegates.

Both persistent and non persistent notifications can now be served from
the same delegate which in turn proxies all requests to the handlers.

BUG=720345

Review-Url: https://codereview.chromium.org/2906883003
Cr-Commit-Position: refs/heads/master@{#478263}

[modify] https://crrev.com/40b10fd5dcb862ce08df81ef5c55c629f64c6394/chrome/browser/BUILD.gn
[modify] https://crrev.com/40b10fd5dcb862ce08df81ef5c55c629f64c6394/chrome/browser/notifications/message_center_display_service.cc
[delete] https://crrev.com/fc202b2b1174f5732f7b9e63a6c46fd01ac2be02/chrome/browser/notifications/notification_object_proxy.cc
[delete] https://crrev.com/fc202b2b1174f5732f7b9e63a6c46fd01ac2be02/chrome/browser/notifications/notification_object_proxy.h
[modify] https://crrev.com/40b10fd5dcb862ce08df81ef5c55c629f64c6394/chrome/browser/notifications/notification_platform_bridge_android.cc
[modify] https://crrev.com/40b10fd5dcb862ce08df81ef5c55c629f64c6394/chrome/browser/notifications/notification_platform_bridge_mac.mm
[delete] https://crrev.com/fc202b2b1174f5732f7b9e63a6c46fd01ac2be02/chrome/browser/notifications/persistent_notification_delegate.cc
[delete] https://crrev.com/fc202b2b1174f5732f7b9e63a6c46fd01ac2be02/chrome/browser/notifications/persistent_notification_delegate.h
[modify] https://crrev.com/40b10fd5dcb862ce08df81ef5c55c629f64c6394/chrome/browser/notifications/platform_notification_service_impl.cc
[modify] https://crrev.com/40b10fd5dcb862ce08df81ef5c55c629f64c6394/chrome/browser/notifications/platform_notification_service_impl.h
[modify] https://crrev.com/40b10fd5dcb862ce08df81ef5c55c629f64c6394/chrome/browser/notifications/platform_notification_service_unittest.cc
[modify] https://crrev.com/40b10fd5dcb862ce08df81ef5c55c629f64c6394/chrome/browser/notifications/web_notification_delegate.cc
[modify] https://crrev.com/40b10fd5dcb862ce08df81ef5c55c629f64c6394/chrome/browser/notifications/web_notification_delegate.h
[modify] https://crrev.com/40b10fd5dcb862ce08df81ef5c55c629f64c6394/content/browser/BUILD.gn
[modify] https://crrev.com/40b10fd5dcb862ce08df81ef5c55c629f64c6394/content/browser/notifications/notification_event_dispatcher_impl.cc
[modify] https://crrev.com/40b10fd5dcb862ce08df81ef5c55c629f64c6394/content/browser/notifications/notification_message_filter.cc
[delete] https://crrev.com/fc202b2b1174f5732f7b9e63a6c46fd01ac2be02/content/browser/notifications/page_notification_delegate.cc
[delete] https://crrev.com/fc202b2b1174f5732f7b9e63a6c46fd01ac2be02/content/browser/notifications/page_notification_delegate.h
[modify] https://crrev.com/40b10fd5dcb862ce08df81ef5c55c629f64c6394/content/public/browser/BUILD.gn
[delete] https://crrev.com/fc202b2b1174f5732f7b9e63a6c46fd01ac2be02/content/public/browser/desktop_notification_delegate.h
[modify] https://crrev.com/40b10fd5dcb862ce08df81ef5c55c629f64c6394/content/public/browser/platform_notification_service.h
[modify] https://crrev.com/40b10fd5dcb862ce08df81ef5c55c629f64c6394/content/test/mock_platform_notification_service.cc
[modify] https://crrev.com/40b10fd5dcb862ce08df81ef5c55c629f64c6394/content/test/mock_platform_notification_service.h

Project Member

Comment 8 by bugdroid1@chromium.org, Jun 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d95830c60e22fa695f0521004149caf03bcc2f77

commit d95830c60e22fa695f0521004149caf03bcc2f77
Author: miguelg <miguelg@chromium.org>
Date: Wed Jun 14 11:01:20 2017

Deprecate native and extension notification delegates.

WebNotificationDelegate can now handle extensions and all web
notifications as a result.

TBR=avi@chromium.org
BUG=720345

Review-Url: https://codereview.chromium.org/2928303002
Cr-Commit-Position: refs/heads/master@{#479347}

[modify] https://crrev.com/d95830c60e22fa695f0521004149caf03bcc2f77/chrome/browser/BUILD.gn
[modify] https://crrev.com/d95830c60e22fa695f0521004149caf03bcc2f77/chrome/browser/extensions/api/notifications/extension_notification_handler.cc
[modify] https://crrev.com/d95830c60e22fa695f0521004149caf03bcc2f77/chrome/browser/extensions/api/notifications/extension_notification_handler.h
[modify] https://crrev.com/d95830c60e22fa695f0521004149caf03bcc2f77/chrome/browser/extensions/api/notifications/notifications_api.cc
[modify] https://crrev.com/d95830c60e22fa695f0521004149caf03bcc2f77/chrome/browser/extensions/api/notifications/notifications_api.h
[modify] https://crrev.com/d95830c60e22fa695f0521004149caf03bcc2f77/chrome/browser/extensions/api/notifications/notifications_apitest.cc
[delete] https://crrev.com/be89d3153d2c173742d473cc3e5b04e12770c507/chrome/browser/notifications/native_notification_delegate.cc
[delete] https://crrev.com/be89d3153d2c173742d473cc3e5b04e12770c507/chrome/browser/notifications/native_notification_delegate.h
[modify] https://crrev.com/d95830c60e22fa695f0521004149caf03bcc2f77/chrome/browser/notifications/non_persistent_notification_handler.cc
[modify] https://crrev.com/d95830c60e22fa695f0521004149caf03bcc2f77/chrome/browser/notifications/non_persistent_notification_handler.h
[modify] https://crrev.com/d95830c60e22fa695f0521004149caf03bcc2f77/chrome/browser/notifications/notification_common.cc
[modify] https://crrev.com/d95830c60e22fa695f0521004149caf03bcc2f77/chrome/browser/notifications/notification_common.h
[modify] https://crrev.com/d95830c60e22fa695f0521004149caf03bcc2f77/chrome/browser/notifications/notification_delegate.h
[modify] https://crrev.com/d95830c60e22fa695f0521004149caf03bcc2f77/chrome/browser/notifications/notification_display_service.cc
[modify] https://crrev.com/d95830c60e22fa695f0521004149caf03bcc2f77/chrome/browser/notifications/notification_display_service.h
[modify] https://crrev.com/d95830c60e22fa695f0521004149caf03bcc2f77/chrome/browser/notifications/notification_handler.h
[modify] https://crrev.com/d95830c60e22fa695f0521004149caf03bcc2f77/chrome/browser/notifications/persistent_notification_handler.cc
[modify] https://crrev.com/d95830c60e22fa695f0521004149caf03bcc2f77/chrome/browser/notifications/persistent_notification_handler.h
[modify] https://crrev.com/d95830c60e22fa695f0521004149caf03bcc2f77/chrome/browser/notifications/platform_notification_service_impl.cc
[modify] https://crrev.com/d95830c60e22fa695f0521004149caf03bcc2f77/chrome/browser/notifications/platform_notification_service_interactive_uitest.cc
[modify] https://crrev.com/d95830c60e22fa695f0521004149caf03bcc2f77/chrome/browser/notifications/platform_notification_service_unittest.cc
[modify] https://crrev.com/d95830c60e22fa695f0521004149caf03bcc2f77/chrome/browser/notifications/stub_notification_display_service.cc
[modify] https://crrev.com/d95830c60e22fa695f0521004149caf03bcc2f77/chrome/browser/notifications/stub_notification_display_service.h
[modify] https://crrev.com/d95830c60e22fa695f0521004149caf03bcc2f77/chrome/browser/notifications/web_notification_delegate.cc
[modify] https://crrev.com/d95830c60e22fa695f0521004149caf03bcc2f77/chrome/browser/notifications/web_notification_delegate.h
[modify] https://crrev.com/d95830c60e22fa695f0521004149caf03bcc2f77/content/test/mock_platform_notification_service.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Jun 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b960aca0d0a3938b7400d508128eadf3951fc00d

commit b960aca0d0a3938b7400d508128eadf3951fc00d
Author: grunell <grunell@chromium.org>
Date: Wed Jun 14 12:32:44 2017

Revert of Deprecate native and extension notification delegates. (patchset #2 id:20001 of https://codereview.chromium.org/2928303002/ )

Reason for revert:
Breaks https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20ASAN.

Original issue's description:
> Deprecate native and extension notification delegates.
>
> WebNotificationDelegate can now handle extensions and all web
> notifications as a result.
>
> TBR=avi@chromium.org
> BUG=720345
>
> Review-Url: https://codereview.chromium.org/2928303002
> Cr-Commit-Position: refs/heads/master@{#479347}
> Committed: https://chromium.googlesource.com/chromium/src/+/d95830c60e22fa695f0521004149caf03bcc2f77

TBR=peter@chromium.org,avi@chromium.org,miguelg@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=720345

Review-Url: https://codereview.chromium.org/2941743002
Cr-Commit-Position: refs/heads/master@{#479357}

[modify] https://crrev.com/b960aca0d0a3938b7400d508128eadf3951fc00d/chrome/browser/BUILD.gn
[modify] https://crrev.com/b960aca0d0a3938b7400d508128eadf3951fc00d/chrome/browser/extensions/api/notifications/extension_notification_handler.cc
[modify] https://crrev.com/b960aca0d0a3938b7400d508128eadf3951fc00d/chrome/browser/extensions/api/notifications/extension_notification_handler.h
[modify] https://crrev.com/b960aca0d0a3938b7400d508128eadf3951fc00d/chrome/browser/extensions/api/notifications/notifications_api.cc
[modify] https://crrev.com/b960aca0d0a3938b7400d508128eadf3951fc00d/chrome/browser/extensions/api/notifications/notifications_api.h
[modify] https://crrev.com/b960aca0d0a3938b7400d508128eadf3951fc00d/chrome/browser/extensions/api/notifications/notifications_apitest.cc
[add] https://crrev.com/b960aca0d0a3938b7400d508128eadf3951fc00d/chrome/browser/notifications/native_notification_delegate.cc
[add] https://crrev.com/b960aca0d0a3938b7400d508128eadf3951fc00d/chrome/browser/notifications/native_notification_delegate.h
[modify] https://crrev.com/b960aca0d0a3938b7400d508128eadf3951fc00d/chrome/browser/notifications/non_persistent_notification_handler.cc
[modify] https://crrev.com/b960aca0d0a3938b7400d508128eadf3951fc00d/chrome/browser/notifications/non_persistent_notification_handler.h
[modify] https://crrev.com/b960aca0d0a3938b7400d508128eadf3951fc00d/chrome/browser/notifications/notification_common.cc
[modify] https://crrev.com/b960aca0d0a3938b7400d508128eadf3951fc00d/chrome/browser/notifications/notification_common.h
[modify] https://crrev.com/b960aca0d0a3938b7400d508128eadf3951fc00d/chrome/browser/notifications/notification_delegate.h
[modify] https://crrev.com/b960aca0d0a3938b7400d508128eadf3951fc00d/chrome/browser/notifications/notification_display_service.cc
[modify] https://crrev.com/b960aca0d0a3938b7400d508128eadf3951fc00d/chrome/browser/notifications/notification_display_service.h
[modify] https://crrev.com/b960aca0d0a3938b7400d508128eadf3951fc00d/chrome/browser/notifications/notification_handler.h
[modify] https://crrev.com/b960aca0d0a3938b7400d508128eadf3951fc00d/chrome/browser/notifications/persistent_notification_handler.cc
[modify] https://crrev.com/b960aca0d0a3938b7400d508128eadf3951fc00d/chrome/browser/notifications/persistent_notification_handler.h
[modify] https://crrev.com/b960aca0d0a3938b7400d508128eadf3951fc00d/chrome/browser/notifications/platform_notification_service_impl.cc
[modify] https://crrev.com/b960aca0d0a3938b7400d508128eadf3951fc00d/chrome/browser/notifications/platform_notification_service_interactive_uitest.cc
[modify] https://crrev.com/b960aca0d0a3938b7400d508128eadf3951fc00d/chrome/browser/notifications/platform_notification_service_unittest.cc
[modify] https://crrev.com/b960aca0d0a3938b7400d508128eadf3951fc00d/chrome/browser/notifications/stub_notification_display_service.cc
[modify] https://crrev.com/b960aca0d0a3938b7400d508128eadf3951fc00d/chrome/browser/notifications/stub_notification_display_service.h
[modify] https://crrev.com/b960aca0d0a3938b7400d508128eadf3951fc00d/chrome/browser/notifications/web_notification_delegate.cc
[modify] https://crrev.com/b960aca0d0a3938b7400d508128eadf3951fc00d/chrome/browser/notifications/web_notification_delegate.h
[modify] https://crrev.com/b960aca0d0a3938b7400d508128eadf3951fc00d/content/test/mock_platform_notification_service.cc

Project Member

Comment 10 by bugdroid1@chromium.org, Jun 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/30dfc2e872643debcbd686c4ef47832adc2ac7be

commit 30dfc2e872643debcbd686c4ef47832adc2ac7be
Author: miguelg <miguelg@chromium.org>
Date: Wed Jun 14 18:18:09 2017

Reland reverted patch once the webkit tests that were failing are
fixed (by reverting an unintended change).

Revert "Revert of Deprecate native and extension notification delegates.
(patchset #2 id:20001 of https://codereview.chromium.org/2928303002/ )"

This reverts commit b960aca0d0a3938b7400d508128eadf3951fc00d.

TBR=peter@chromium.org
BUG=720345

Review-Url: https://codereview.chromium.org/2938883002
Cr-Commit-Position: refs/heads/master@{#479445}

[modify] https://crrev.com/30dfc2e872643debcbd686c4ef47832adc2ac7be/chrome/browser/BUILD.gn
[modify] https://crrev.com/30dfc2e872643debcbd686c4ef47832adc2ac7be/chrome/browser/extensions/api/notifications/extension_notification_handler.cc
[modify] https://crrev.com/30dfc2e872643debcbd686c4ef47832adc2ac7be/chrome/browser/extensions/api/notifications/extension_notification_handler.h
[modify] https://crrev.com/30dfc2e872643debcbd686c4ef47832adc2ac7be/chrome/browser/extensions/api/notifications/notifications_api.cc
[modify] https://crrev.com/30dfc2e872643debcbd686c4ef47832adc2ac7be/chrome/browser/extensions/api/notifications/notifications_api.h
[modify] https://crrev.com/30dfc2e872643debcbd686c4ef47832adc2ac7be/chrome/browser/extensions/api/notifications/notifications_apitest.cc
[delete] https://crrev.com/b2a8eef9c69cb5cccd0fabd74a3f2b7a7862a603/chrome/browser/notifications/native_notification_delegate.cc
[delete] https://crrev.com/b2a8eef9c69cb5cccd0fabd74a3f2b7a7862a603/chrome/browser/notifications/native_notification_delegate.h
[modify] https://crrev.com/30dfc2e872643debcbd686c4ef47832adc2ac7be/chrome/browser/notifications/non_persistent_notification_handler.cc
[modify] https://crrev.com/30dfc2e872643debcbd686c4ef47832adc2ac7be/chrome/browser/notifications/non_persistent_notification_handler.h
[modify] https://crrev.com/30dfc2e872643debcbd686c4ef47832adc2ac7be/chrome/browser/notifications/notification_common.cc
[modify] https://crrev.com/30dfc2e872643debcbd686c4ef47832adc2ac7be/chrome/browser/notifications/notification_common.h
[modify] https://crrev.com/30dfc2e872643debcbd686c4ef47832adc2ac7be/chrome/browser/notifications/notification_delegate.h
[modify] https://crrev.com/30dfc2e872643debcbd686c4ef47832adc2ac7be/chrome/browser/notifications/notification_display_service.cc
[modify] https://crrev.com/30dfc2e872643debcbd686c4ef47832adc2ac7be/chrome/browser/notifications/notification_display_service.h
[modify] https://crrev.com/30dfc2e872643debcbd686c4ef47832adc2ac7be/chrome/browser/notifications/notification_handler.h
[modify] https://crrev.com/30dfc2e872643debcbd686c4ef47832adc2ac7be/chrome/browser/notifications/persistent_notification_handler.cc
[modify] https://crrev.com/30dfc2e872643debcbd686c4ef47832adc2ac7be/chrome/browser/notifications/persistent_notification_handler.h
[modify] https://crrev.com/30dfc2e872643debcbd686c4ef47832adc2ac7be/chrome/browser/notifications/platform_notification_service_impl.cc
[modify] https://crrev.com/30dfc2e872643debcbd686c4ef47832adc2ac7be/chrome/browser/notifications/platform_notification_service_interactive_uitest.cc
[modify] https://crrev.com/30dfc2e872643debcbd686c4ef47832adc2ac7be/chrome/browser/notifications/platform_notification_service_unittest.cc
[modify] https://crrev.com/30dfc2e872643debcbd686c4ef47832adc2ac7be/chrome/browser/notifications/stub_notification_display_service.cc
[modify] https://crrev.com/30dfc2e872643debcbd686c4ef47832adc2ac7be/chrome/browser/notifications/stub_notification_display_service.h
[modify] https://crrev.com/30dfc2e872643debcbd686c4ef47832adc2ac7be/chrome/browser/notifications/web_notification_delegate.cc
[modify] https://crrev.com/30dfc2e872643debcbd686c4ef47832adc2ac7be/chrome/browser/notifications/web_notification_delegate.h

Sign in to add a comment