Issue metadata
Sign in to add a comment
|
Regression : Weird black patches are seen in header tab in Google excel sheets.
Reported by
rp...@etouch.net,
May 10 2017
|
||||||||||||||||||||||
Issue descriptionChrome Version : 60.0.3095.0 b553e926d6cc3f7d4fa5963d0d25d2d02eacd983-refs/heads/master@{#470437} OS : Windows 7 URL: https://community.tableau.com/docs/DOC-1236 Pre condition : Sign in with valid credential in google drive What steps will reproduce the problem? 1. Launch chrome, navigate to above url,download the sample excel file and upload it into your Google Drive. 2. Now in Google Drive right click on uploaded file and choose 'Open with Google sheets' and observe header tab of sheet. Actual : Weird black patches are seen in header tab in excel sheets. Expected : Weird black patches should not be seen in header tab in excel sheets. This is a regression issue broken in ‘M-60’ and will soon update other info. Good build :60.0.3094.0 Bad build :60.0.3095.0 Note : Issue is not seen on Windows 8,10 and Linux OS.
,
May 10 2017
,
May 10 2017
,
May 10 2017
Something that is Windows 7 only is presumably somewhere in the GPU process. We do not have any custom Blink code for Windows 7.
,
May 11 2017
Narrow Bisect info : https://chromium.googlesource.com/chromium/src/+log/b0ec883fdeea4c3b2b13900650c744d22e0b0f22..f41443c03b03d8e2d83314ae4690f402beada8b4?pretty=fuller&n=100 Skia URL : https://skia.googlesource.com/skia.git/+log/05814de6ba50..6410d29e1173?pretty=fuller&n=100 Suspecting: 6410d29e1173b49b7319d7389db7c533e27bb3d2 from Skia URL @robertphillips : Could you please help to reassign if your change is not the cause for this change.
,
May 11 2017
Adding RB Label as this is a recent Regression. Please feel free to remove if not required. Thank You.
,
May 12 2017
I cannot reproduce the bug at all on my Win7 laptop both on a local build and in the bisect between 60.0.3094.0 and 60.0.3095.0. Could you, the OP, please post the gpu information for the machine you were seeing this on? You should be able to copy & paste the information from chrome://gpu.
,
May 15 2017
rpise@, can you please update chrome://gpu info as per c#7? Thank you!
,
May 16 2017
With response to comment #7 : Kindly refer the attached screenshot of chrome://gpu information. Narrow Bisect info : https://chromium.googlesource.com/chromium/src/+log/b0ec883fdeea4c3b2b13900650c744d22e0b0f22..f41443c03b03d8e2d83314ae4690f402beada8b4?pretty=fuller&n=100 Suspecting: r470318 from Narrow bisect @cjgrant : Could you please help to reassign if your change is not the cause for this change.
,
May 16 2017
@rpise@, sorry, but r470318 could not be the cause of this regression - it's local to VR-specific code. Punting back.
,
May 16 2017
I was finally able to reproduce the bug locally by passing "--use-angle=d3d9" on startup. I will keep looking into the issue but it would be good to get some ANGLE expertise involved.
,
May 17 2017
,
May 18 2017
What appears to be going on is that the creation of Alpha_8 renderable surfaces is failing with ANGLE.
,
May 18 2017
,
May 18 2017
I wonder if this could be reproduced in dm by running with our angle_d3d9_es2 config
,
May 22 2017
Just to update M-60 will be branched in 3 days time and would be good to have this fixed before M-60 is branched. Cc'ing geofflang@ as well for inputs as per C#11.
,
May 22 2017
I have a Skia fix brewing here: https://skia-review.googlesource.com/c/17387/ (Add fixes & test for isConfigTexturable and isConfigRenderable). It is just stuck (Skia-side) on the NexusPlayer Vulkan config.
,
May 22 2017
The following revision refers to this bug: https://skia.googlesource.com/skia/+/b7b7e5fba08399c76fa0763ec3ed49ae120b64d8 commit b7b7e5fba08399c76fa0763ec3ed49ae120b64d8 Author: Robert Phillips <robertphillips@google.com> Date: Mon May 22 17:55:48 2017 Add fixes & test for isConfigTexturable and isConfigRenderable This CL fixes: isConfigTexturable was returning true for: kRG_float for ANGLE ES2 configs isConfigRenderable was returning true for: kAlpha_8 for ANGLE ES2 configs isConfigTexturable and isConfigRenderable were returning true for: SBGRA on ES2 The NexusPlayer was marking RGBA & RG float configs as renderable but not textureable Bug: 720325 Change-Id: If21361870dbdde8f3e09bc9dff3a394f2a329157 Reviewed-on: https://skia-review.googlesource.com/17387 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> [modify] https://crrev.com/b7b7e5fba08399c76fa0763ec3ed49ae120b64d8/src/gpu/GrGpu.cpp [modify] https://crrev.com/b7b7e5fba08399c76fa0763ec3ed49ae120b64d8/tests/GrSurfaceTest.cpp [modify] https://crrev.com/b7b7e5fba08399c76fa0763ec3ed49ae120b64d8/src/gpu/gl/GrGLCaps.cpp [modify] https://crrev.com/b7b7e5fba08399c76fa0763ec3ed49ae120b64d8/tools/gpu/GrTest.cpp [modify] https://crrev.com/b7b7e5fba08399c76fa0763ec3ed49ae120b64d8/include/gpu/GrCaps.h [modify] https://crrev.com/b7b7e5fba08399c76fa0763ec3ed49ae120b64d8/tests/IntTextureTest.cpp [modify] https://crrev.com/b7b7e5fba08399c76fa0763ec3ed49ae120b64d8/src/gpu/vk/GrVkCaps.cpp
,
May 23 2017
The Skia CL https://skia-review.googlesource.com/c/17387/ (Add fixes & test for isConfigTexturable and isConfigRenderable) rolled into Chrome at 473665 in https://chromium-review.googlesource.com/c/510744/. This made it into the 60.0.3108.0 Canary.
,
May 23 2017
I do not seem to be able to reproduce it locally with the 60.0.3108.0 Canary and "--use-angle=d3d9" on my Windows 7 machine. OP would you be willing to verify on your machine?
,
May 24 2017
I am also no longer able to repro on my local build. I'm marking this as 'fixed' until told different.
,
May 29 2017
With response to comment #20 : Rechecked the above issue on Windows 7 OS with latest canary chrome version : 61.0.3114.0 and the issue is still reproducible.Kindly refer the attached screen cast for reference.
,
May 30 2017
,
May 30 2017
This issue is tagged as Release Block Beta. M60 will be promoted to Beta on June 8. So please have a fix ASAP.
,
May 31 2017
The following revision refers to this bug: https://skia.googlesource.com/skia/+/8bf1f9ffcf4b0168a1a05399eb0ed4e5e04eab80 commit 8bf1f9ffcf4b0168a1a05399eb0ed4e5e04eab80 Author: Robert Phillips <robertphillips@google.com> Date: Wed May 31 23:12:39 2017 Disable deferred proxies for M60 branch Bug: 720325 Change-Id: I0529bbcd592bdc5d5a741731af8a66971e485649 Reviewed-on: https://skia-review.googlesource.com/18239 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com> [modify] https://crrev.com/8bf1f9ffcf4b0168a1a05399eb0ed4e5e04eab80/tests/DetermineDomainModeTest.cpp [modify] https://crrev.com/8bf1f9ffcf4b0168a1a05399eb0ed4e5e04eab80/src/gpu/GrSurfaceProxy.cpp [modify] https://crrev.com/8bf1f9ffcf4b0168a1a05399eb0ed4e5e04eab80/tests/ProxyTest.cpp [modify] https://crrev.com/8bf1f9ffcf4b0168a1a05399eb0ed4e5e04eab80/include/private/GrSurfaceProxy.h [modify] https://crrev.com/8bf1f9ffcf4b0168a1a05399eb0ed4e5e04eab80/tests/ProxyRefTest.cpp
,
Jun 2 2017
The following revision refers to this bug: https://skia.googlesource.com/skia/+/bc712740bda0b78ba909894eed7aa6feeb9efe34 commit bc712740bda0b78ba909894eed7aa6feeb9efe34 Author: Robert Phillips <robertphillips@google.com> Date: Fri Jun 02 16:51:49 2017 Disable single channel renderability for ANGLE ES2 Bug: 720325 Change-Id: Ib55c7a0c59a23b8dc012e04b626010de7da2921b Reviewed-on: https://skia-review.googlesource.com/18485 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com> [modify] https://crrev.com/bc712740bda0b78ba909894eed7aa6feeb9efe34/src/gpu/gl/GrGLUtil.cpp [modify] https://crrev.com/bc712740bda0b78ba909894eed7aa6feeb9efe34/src/gpu/gl/GrGLUtil.h [modify] https://crrev.com/bc712740bda0b78ba909894eed7aa6feeb9efe34/src/gpu/gl/GrGLCaps.cpp
,
Jun 2 2017
Thanks Robert for the quick turnaround. rpise@ Please verify in the canary once the CL is picked up.
,
Jun 2 2017
https://skia-review.googlesource.com/c/18239/ (Disable deferred proxies for M60 branch) rolled into Chrome on 6/1/2017 in https://chromium-review.googlesource.com/c/520713/ at 476287. This made it into the 61.0.3118.0 Canary.
,
Jun 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/angle/angle/+/8d4db1fa5fa743eb931be3b257142f5ccb0ed9e9 commit 8d4db1fa5fa743eb931be3b257142f5ccb0ed9e9 Author: Geoff Lang <geofflang@chromium.org> Date: Fri Jun 02 19:47:37 2017 Fix format info for unsized RG texture formats. The unsized GL_RED and GL_RG formats are only usable with the EXT_texture_rg extension and are always renderable. BUG= 720325 Change-Id: I813662f6c90f1a6a640be747ae40b81727e58cdc Reviewed-on: https://chromium-review.googlesource.com/523023 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> [modify] https://crrev.com/8d4db1fa5fa743eb931be3b257142f5ccb0ed9e9/src/libANGLE/formatutils.cpp
,
Jun 5 2017
The Skia-fix in question (https://skia-review.googlesource.com/c/18239/ (Disable deferred proxies for M60 branch)) has been in Chrome for 4 days. I would like to cherry pick it back to M60. Although the ANGLE-fix (https://chromium-review.googlesource.com/523023 (Fix format info for unsized RG texture formats)) will also probably fix the bug (and is cleaner), the Skia-side fix is a surer bet.
,
Jun 5 2017
With response to comment #27 : Rechecked the above issue on Windows 7 OS with latest canary chrome version : 61.0.3119.0 and the issue is not reproduced.
,
Jun 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c3dd368e8a690ec92564583b0b008d8541043d3f commit c3dd368e8a690ec92564583b0b008d8541043d3f Author: jmadill <jmadill@chromium.org> Date: Mon Jun 05 16:17:42 2017 Roll ANGLE b7d5e30..5978e28 https://chromium.googlesource.com/angle/angle.git/+log/b7d5e30..5978e28 BUG= 720325 TBR=geofflang@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2917413002 Cr-Commit-Position: refs/heads/master@{#476993} [modify] https://crrev.com/c3dd368e8a690ec92564583b0b008d8541043d3f/DEPS
,
Jun 5 2017
I think the ANGLE-side fix is is very safe because the validation only becomes more lenient and skia would continue to follow the same code paths instead of using different formats.
,
Jun 6 2017
This bug requires manual review: DEPS changes referenced in bugdroid comments. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 6 2017
rpise@ Please verify in latest canary. Robert, feel free to merge if looks good and once merge is approved.
,
Jun 7 2017
With response to comment #35 : Rechecked the above issue on Windows 7 OS with latest canary chrome version : 61.0.3122.0 and the issue is not reproduced.
,
Jun 7 2017
,
Jun 7 2017
Approving for merge into M60
,
Jun 7 2017
Robert, please merge the patch to M60 branch(3112),Beta RC cut is scheduled @ 4.00 PM PST today(06/07)
,
Jun 7 2017
The following revision refers to this bug: https://skia.googlesource.com/skia/+/2fabc4f82ca8cd15f9b8f376377eba27bef59f6d commit 2fabc4f82ca8cd15f9b8f376377eba27bef59f6d Author: Robert Phillips <robertphillips@google.com> Date: Wed Jun 07 17:44:37 2017 [M60 cherry-pick] Disable deferred proxies for M60 branch No-Tree-Checks: true No-Try: true No-Presubmit: true Bug: 720325 Change-Id: I215af7db2536a27c941f5f1ff6f2af8cf41f4189 Reviewed-on: https://skia-review.googlesource.com/18592 Reviewed-by: Brian Salomon <bsalomon@google.com> [modify] https://crrev.com/2fabc4f82ca8cd15f9b8f376377eba27bef59f6d/tests/DetermineDomainModeTest.cpp [modify] https://crrev.com/2fabc4f82ca8cd15f9b8f376377eba27bef59f6d/src/gpu/GrSurfaceProxy.cpp [modify] https://crrev.com/2fabc4f82ca8cd15f9b8f376377eba27bef59f6d/tests/ProxyTest.cpp [modify] https://crrev.com/2fabc4f82ca8cd15f9b8f376377eba27bef59f6d/include/private/GrSurfaceProxy.h [modify] https://crrev.com/2fabc4f82ca8cd15f9b8f376377eba27bef59f6d/tests/ProxyRefTest.cpp
,
Jun 7 2017
,
Jun 7 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by rp...@etouch.net
, May 10 2017