New issue
Advanced search Search tips

Issue 720289 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature

Blocking:
issue 690383



Sign in to add a comment

Extend WebContents to reflect HTTP status code for Web Manifest downloads

Project Member Reported by mastiz@chromium.org, May 10 2017

Issue description

WebContents::GetManifest() or GetManifestCallback return an empty manifest if the download attempt fails.

It would be desirable to distinguish temporary errors (e.g. 5xx) from the rest (e.g. 404). This would allow client code to avoid repeated attempts, for example for the purpose of fetching favicons from manifests on page load (which we're working on, see blocking bug).

404s are particularly bad because they tend to be rather big responses, leading to unnecessary cellular data consumption.

dominickn@ assigning to you to follow up but please reassign (if needed, by to myself).
 
(FYI I'm OOO for the next week).

I'd like to know how often this case might come up. Longer term I'd rather remove the GetManifest callback from WebContents and shift that to a WebContentsUserData, so if we don't need to add more to the API surface right now that's preferable.

Comment 2 by mastiz@chromium.org, May 11 2017

Labels: -Pri-2 Pri-3
There's no clear evidence that this is a real issue for manifests but:
1. We've come across 404 examples anecdotally during testing.
2. We have reasonable evidence (UMA, flywheel) that the 404 case is non-negligible for favicons (which doesn't proof the same holds for manifests, for that's all we have).

I don't have a good estimate as per how common 5xx errors are, which means I can't claim what the real impact would be of a smarter solution (as proposed in this bug), vs treating all empty manifests equally (i.e. don't distinguish 404s, 5xx or actual empty manifests).

Decreasing priority until we know better or have stronger belief.
Cc: dominickn@chromium.org
Owner: ----
Status: Available (was: Assigned)
SYD is moving off of this work, so marking as available.

Sign in to add a comment