New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 720288 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: 2
NextAction: ----
OS: Android
Pri: 2
Type: ----

Blocking:
issue 720285



Sign in to add a comment

Implement hide article summaries in content suggestions

Project Member Reported by mvanouwe...@chromium.org, May 10 2017

Issue description

Content suggestions: do not show article summaries. See launch bug for details.
 
Status: Started (was: Assigned)
See screenshots with and without summaries.
phone_chrome_home_portrait_with_summaries.png
443 KB View Download
phone_chrome_home_portrait_no_summaries.png
441 KB View Download
Status: Fixed (was: Started)
Status: Started (was: Fixed)
Summary: Implement hide article summaries in content suggestions (was: Implement "do not show article summaries")
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/032e2b23f44081983a42658ea5551acca8ca1cd2

commit 032e2b23f44081983a42658ea5551acca8ca1cd2
Author: mvanouwerkerk <mvanouwerkerk@chromium.org>
Date: Thu Jun 15 15:00:27 2017

Hide content suggestion summaries by default.

BUG= 720288 

Review-Url: https://codereview.chromium.org/2937223002
Cr-Commit-Position: refs/heads/master@{#479700}

[modify] https://crrev.com/032e2b23f44081983a42658ea5551acca8ca1cd2/chrome/browser/android/chrome_feature_list.cc

Status: Fixed (was: Started)
Labels: -M-60 M-61
Project Member

Comment 10 by bugdroid1@chromium.org, Sep 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f328741e77ec44b6d44ad3926147bbf719a7bc1c

commit f328741e77ec44b6d44ad3926147bbf719a7bc1c
Author: Nicolas Dossou-gbete <dgn@chromium.org>
Date: Thu Sep 28 10:35:33 2017

📰 Remove support for article summaries from the UI

Bug:  720288 
Change-Id: I63eb502efd9713bd02ffa09f0721b3d914b474d1
Reviewed-on: https://chromium-review.googlesource.com/647887
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504957}
[modify] https://crrev.com/f328741e77ec44b6d44ad3926147bbf719a7bc1c/chrome/android/java/res/layout/content_suggestions_card_modern.xml
[modify] https://crrev.com/f328741e77ec44b6d44ad3926147bbf719a7bc1c/chrome/android/java/res/layout/contextual_suggestions_card.xml
[modify] https://crrev.com/f328741e77ec44b6d44ad3926147bbf719a7bc1c/chrome/android/java/res/layout/new_tab_page_snippets_card.xml
[modify] https://crrev.com/f328741e77ec44b6d44ad3926147bbf719a7bc1c/chrome/android/java/res/layout/new_tab_page_snippets_card_large_thumbnail.xml
[modify] https://crrev.com/f328741e77ec44b6d44ad3926147bbf719a7bc1c/chrome/android/java/res/values/dimens.xml
[modify] https://crrev.com/f328741e77ec44b6d44ad3926147bbf719a7bc1c/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java
[modify] https://crrev.com/f328741e77ec44b6d44ad3926147bbf719a7bc1c/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java
[modify] https://crrev.com/f328741e77ec44b6d44ad3926147bbf719a7bc1c/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java
[modify] https://crrev.com/f328741e77ec44b6d44ad3926147bbf719a7bc1c/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java
[modify] https://crrev.com/f328741e77ec44b6d44ad3926147bbf719a7bc1c/chrome/android/java/src/org/chromium/chrome/browser/suggestions/ContextualSuggestionsCardViewHolder.java
[modify] https://crrev.com/f328741e77ec44b6d44ad3926147bbf719a7bc1c/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsBinder.java
[modify] https://crrev.com/f328741e77ec44b6d44ad3926147bbf719a7bc1c/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NtpUiCaptureTestData.java
[modify] https://crrev.com/f328741e77ec44b6d44ad3926147bbf719a7bc1c/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerViewTest.java
[modify] https://crrev.com/f328741e77ec44b6d44ad3926147bbf719a7bc1c/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/snippets/ArticleSnippetsTest.java
[modify] https://crrev.com/f328741e77ec44b6d44ad3926147bbf719a7bc1c/chrome/android/javatests/src/org/chromium/chrome/browser/suggestions/ContextualSuggestionsTest.java
[modify] https://crrev.com/f328741e77ec44b6d44ad3926147bbf719a7bc1c/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java
[modify] https://crrev.com/f328741e77ec44b6d44ad3926147bbf719a7bc1c/chrome/browser/about_flags.cc
[modify] https://crrev.com/f328741e77ec44b6d44ad3926147bbf719a7bc1c/chrome/browser/android/chrome_feature_list.cc
[modify] https://crrev.com/f328741e77ec44b6d44ad3926147bbf719a7bc1c/chrome/browser/android/chrome_feature_list.h
[modify] https://crrev.com/f328741e77ec44b6d44ad3926147bbf719a7bc1c/chrome/browser/android/ntp/ntp_snippets_bridge.cc
[modify] https://crrev.com/f328741e77ec44b6d44ad3926147bbf719a7bc1c/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/f328741e77ec44b6d44ad3926147bbf719a7bc1c/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/f328741e77ec44b6d44ad3926147bbf719a7bc1c/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/suggestions/ContentSuggestionsTestUtils.java
[modify] https://crrev.com/f328741e77ec44b6d44ad3926147bbf719a7bc1c/testing/variations/fieldtrial_testing_config.json

Sign in to add a comment