New issue
Advanced search Search tips

Issue 720279 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: May 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 688900



Sign in to add a comment

Dircrypto migrator calls g_signal_emit on cryptohome's mount thread

Project Member Reported by hashimoto@chromium.org, May 10 2017

Issue description

dbus-glib is not thread-safe so all D-Bus operations should be done on the main thread.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/1b1e65cfe23ea71e0f24cdafead7dabeea5252f9

commit 1b1e65cfe23ea71e0f24cdafead7dabeea5252f9
Author: Ryo Hashimoto <hashimoto@google.com>
Date: Thu May 11 03:58:06 2017

cryptohome: Emit dircrypto migration signal on the main thread

dbus-glib is not guaranteed to be thread-safe.

BUG= chromium:720279 
TEST=manually

Change-Id: I3acfb9c12010b7d43b6cbd8ea8c87c0c7bcbf191
Reviewed-on: https://chromium-review.googlesource.com/501630
Commit-Ready: Ryo Hashimoto <hashimoto@chromium.org>
Tested-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Andrey Pronin <apronin@chromium.org>

[modify] https://crrev.com/1b1e65cfe23ea71e0f24cdafead7dabeea5252f9/cryptohome/service.cc

Labels: Merge-Request-59
Project Member

Comment 3 by sheriffbot@chromium.org, May 12 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, May 12 2017

Labels: merge-merged-release-R59-9460.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/9a797b06eaa1e8ea5e94844fe6dda2f7f6d75a02

commit 9a797b06eaa1e8ea5e94844fe6dda2f7f6d75a02
Author: Ryo Hashimoto <hashimoto@google.com>
Date: Fri May 12 07:01:09 2017

cryptohome: Emit dircrypto migration signal on the main thread

dbus-glib is not guaranteed to be thread-safe.

BUG= chromium:720279 
TEST=manually

Change-Id: I3acfb9c12010b7d43b6cbd8ea8c87c0c7bcbf191
Reviewed-on: https://chromium-review.googlesource.com/501630
Commit-Ready: Ryo Hashimoto <hashimoto@chromium.org>
Tested-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Andrey Pronin <apronin@chromium.org>
(cherry picked from commit 1b1e65cfe23ea71e0f24cdafead7dabeea5252f9)
Reviewed-on: https://chromium-review.googlesource.com/503890
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org>

[modify] https://crrev.com/9a797b06eaa1e8ea5e94844fe6dda2f7f6d75a02/cryptohome/service.cc

Labels: -Hotlist-Merge-Approved -Merge-Approved-59
Status: Fixed (was: Started)

Comment 6 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 7 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment