New issue
Advanced search Search tips

Issue 720277 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Feb 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

Detect issues on browser process start in case when another process already exists.

Reported by ase...@yandex-team.ru, May 10 2017

Issue description

Browser process can start even if another browser process already exists or profile is locked. 
There are a lot of possible reasons for that. For example this can happen if remote process is hung and we cannot connect to it.
Running of 2 separate browser process on the same profile can lead to many problems such as locking of login database etc.

In order to detect such issues we need to add histograms for ProcessSingleton start.
Also we can detect remote process termination error codes.
 
This issue is not platform specific.
Labels: Needs-Milestone
Project Member

Comment 3 by bugdroid1@chromium.org, May 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/028ea15d88db7e9bfb4303698ae52fbf75fc55ca

commit 028ea15d88db7e9bfb4303698ae52fbf75fc55ca
Author: aseren <aseren@yandex-team.ru>
Date: Tue May 16 17:22:43 2017

Added histograms on process singleton create when remote process exists and we cannot notify it

Currently we have no information about starting of browser process when other
remote processes exist. This CL adds some histograms that will track following:
- how we have interacted with remote process before start we cannot notify them
(i.e. unlocked profile or terminated)
- reason of remote process termination
- error codes for remote process termination

BUG= 720277 

Review-Url: https://codereview.chromium.org/2871793003
Cr-Commit-Position: refs/heads/master@{#472144}

[modify] https://crrev.com/028ea15d88db7e9bfb4303698ae52fbf75fc55ca/chrome/browser/process_singleton.h
[modify] https://crrev.com/028ea15d88db7e9bfb4303698ae52fbf75fc55ca/chrome/browser/process_singleton_posix.cc
[modify] https://crrev.com/028ea15d88db7e9bfb4303698ae52fbf75fc55ca/chrome/browser/process_singleton_posix_unittest.cc
[modify] https://crrev.com/028ea15d88db7e9bfb4303698ae52fbf75fc55ca/chrome/browser/process_singleton_win.cc
[modify] https://crrev.com/028ea15d88db7e9bfb4303698ae52fbf75fc55ca/chrome/browser/process_singleton_win_unittest.cc
[modify] https://crrev.com/028ea15d88db7e9bfb4303698ae52fbf75fc55ca/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/028ea15d88db7e9bfb4303698ae52fbf75fc55ca/tools/metrics/histograms/histograms.xml

Cc: kkaluri@chromium.org
Labels: Needs-Feedback
aseren@ Could you please let us know the steps to verify this issue from TE-End


Thank You...
Histograms that tracks issues on browser start have been landed to chromium. These are following histograms:
- Chrome.ProcessSingleton.RemoteHungProcessTerminateReason
- Chrome.ProcessSingleton.RemoteProcessInteractionResult
- Chrome.ProcessSingleton.TerminateProcessErrorCode.Posix
- Chrome.ProcessSingleton.TerminateProcessErrorCode.Windows
- Chrome.ProcessSingleton.TerminateProcessTime
- Chrome.ProcessSingleton.TerminationWaitErrorCode.Windows

This issue can be closed
Status: Fixed (was: Unconfirmed)

Sign in to add a comment