New issue
Advanced search Search tips

Issue 720258 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

getUserMedia: adding a video track to a stream with an audio-only srcObject does not show video

Project Member Reported by philipp....@googlemail.com, May 10 2017

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Ubuntu Chromium/58.0.3029.96 Chrome/58.0.3029.96 Safari/537.36

Steps to reproduce the problem:
1. go to https://jsfiddle.net/ukwx8fz0/1/ -- this calls getUserMedia and attaches a clone of the stream only having an audio track to a video element. Verify you can hear stuff (and use headphones, there will be echo)
2. click 'add video'

What is the expected behavior?
the video is shown

What went wrong?
the video is not shown. It is shown after clicking 'set srcobject again'.
This means the addition of the video track is not reflected which is rather unexpected.

Firefox immediately shows the video as does Edge.

A good way to test is probably to check that the video onresize handler is called.

Did this work before? N/A 

Does this work in other browsers? N/A

Chrome version: 58.0.3029.96  Channel: n/a
OS Version: 
Flash Version: Shockwave Flash 16.0 r0

originally from
https://webrtc.github.io/samples/src/content/peerconnection/pc1/
but this repro has less moving parts.

 issue 595326  unflagged srcObject.
 
meh. Can someone change the title to "getUserMedia: adding a video track to a stream with an audio-only srcObject does not show video" please?

Comment 2 by foolip@chromium.org, May 10 2017

Summary: getUserMedia: adding a video track to a stream with an audio-only srcObject does not show video (was: getUserMedia: adding to a)
https://jsfiddle.net/f4uqtgn7/2/ is putting this into the wpt harness (thanks foolip!)
Had to add a workaround for  issue 601470  :-/
Labels: Needs-Triage-M58

Comment 5 by guidou@chromium.org, May 11 2017

Owner: guidou@chromium.org
Status: Assigned (was: Unconfirmed)
I can reproduce.

Comment 6 by guidou@chromium.org, May 12 2017

Status: Started (was: Assigned)
i've made a PR with a sample: https://github.com/webrtc/samples/pull/906
Including workarounds because the Edge behaviour for remote streams is odd too :-)
ping -- I am considering adding a really ugly workaround in adapter since that is less evil than spreading a document.querySelectorAll('video') srcObject re-setter everywhere.

Comment 9 by guidou@chromium.org, Jul 19 2017

philipp.hancke@: see https://codereview.chromium.org/2969093002/
woho, thanks!
Project Member

Comment 11 by bugdroid1@chromium.org, Aug 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9612ba8bf66e48a32301e35425dd3384f48a3d8

commit c9612ba8bf66e48a32301e35425dd3384f48a3d8
Author: guidou <guidou@chromium.org>
Date: Tue Aug 01 07:42:47 2017

Make rendering of MediaStreams reflect changes to its set of tracks.

Before this CL, MediaStreams assigned to a media element required
reassignment of the stream to the element in order to make changes
to the set of tracks visible.

This CL fixes this problem by making WebMediaPlayerMS subscribe to
changes in the set of tracks of a MediaStream, and correspondingly
update audio and video renderers.

BUG= 720258 

Review-Url: https://codereview.chromium.org/2969093002
Cr-Commit-Position: refs/heads/master@{#490906}

[modify] https://crrev.com/c9612ba8bf66e48a32301e35425dd3384f48a3d8/content/browser/webrtc/webrtc_getusermedia_browsertest.cc
[modify] https://crrev.com/c9612ba8bf66e48a32301e35425dd3384f48a3d8/content/renderer/media/webmediaplayer_ms.cc
[modify] https://crrev.com/c9612ba8bf66e48a32301e35425dd3384f48a3d8/content/renderer/media/webmediaplayer_ms.h
[modify] https://crrev.com/c9612ba8bf66e48a32301e35425dd3384f48a3d8/content/shell/test_runner/mock_web_user_media_client.cc
[modify] https://crrev.com/c9612ba8bf66e48a32301e35425dd3384f48a3d8/content/test/data/media/getusermedia.html

Project Member

Comment 12 by bugdroid1@chromium.org, Aug 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b35b4c271b7819e3661942ab2c72083673722910

commit b35b4c271b7819e3661942ab2c72083673722910
Author: jkrcal <jkrcal@chromium.org>
Date: Tue Aug 01 08:55:08 2017

Revert of Make rendering of MediaStreams reflect changes to its set of tracks. (patchset #6 id:120001 of https://codereview.chromium.org/2969093002/ )

Reason for revert:
Breaking build https://uberchromegw.corp.google.com/i/chromium.linux/builders/Cast%20Audio%20Linux/builds/3356

Original issue's description:
> Make rendering of MediaStreams reflect changes to its set of tracks.
>
> Before this CL, MediaStreams assigned to a media element required
> reassignment of the stream to the element in order to make changes
> to the set of tracks visible.
>
> This CL fixes this problem by making WebMediaPlayerMS subscribe to
> changes in the set of tracks of a MediaStream, and correspondingly
> update audio and video renderers.
>
> BUG= 720258 
>
> Review-Url: https://codereview.chromium.org/2969093002
> Cr-Commit-Position: refs/heads/master@{#490906}
> Committed: https://chromium.googlesource.com/chromium/src/+/c9612ba8bf66e48a32301e35425dd3384f48a3d8

TBR=dalecurtis@chromium.org,emircan@chromium.org,foolip@chromium.org,mkwst@chromium.org,guidou@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 720258 

Review-Url: https://codereview.chromium.org/2985393002
Cr-Commit-Position: refs/heads/master@{#490920}

[modify] https://crrev.com/b35b4c271b7819e3661942ab2c72083673722910/content/browser/webrtc/webrtc_getusermedia_browsertest.cc
[modify] https://crrev.com/b35b4c271b7819e3661942ab2c72083673722910/content/renderer/media/webmediaplayer_ms.cc
[modify] https://crrev.com/b35b4c271b7819e3661942ab2c72083673722910/content/renderer/media/webmediaplayer_ms.h
[modify] https://crrev.com/b35b4c271b7819e3661942ab2c72083673722910/content/shell/test_runner/mock_web_user_media_client.cc
[modify] https://crrev.com/b35b4c271b7819e3661942ab2c72083673722910/content/test/data/media/getusermedia.html

Project Member

Comment 13 by bugdroid1@chromium.org, Aug 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92561aec1fac0748d4e0ac3618ed7d2eb6ea9cb0

commit 92561aec1fac0748d4e0ac3618ed7d2eb6ea9cb0
Author: guidou <guidou@chromium.org>
Date: Wed Aug 02 12:03:53 2017

Reland of Make rendering of MediaStreams reflect changes to its set of tracks. (patchset #1 id:1 of https://codereview.chromium.org/2985393002/ )

Reason for revert:
BUILD files have been fixed in a separate CL, so this is safe to reland.

Original issue's description:
> Revert of Make rendering of MediaStreams reflect changes to its set of tracks. (patchset #6 id:120001 of https://codereview.chromium.org/2969093002/ )
>
> Reason for revert:
> Breaking build https://uberchromegw.corp.google.com/i/chromium.linux/builders/Cast%20Audio%20Linux/builds/3356
>
> Original issue's description:
> > Make rendering of MediaStreams reflect changes to its set of tracks.
> >
> > Before this CL, MediaStreams assigned to a media element required
> > reassignment of the stream to the element in order to make changes
> > to the set of tracks visible.
> >
> > This CL fixes this problem by making WebMediaPlayerMS subscribe to
> > changes in the set of tracks of a MediaStream, and correspondingly
> > update audio and video renderers.
> >
> > BUG= 720258 
> >
> > Review-Url: https://codereview.chromium.org/2969093002
> > Cr-Commit-Position: refs/heads/master@{#490906}
> > Committed: https://chromium.googlesource.com/chromium/src/+/c9612ba8bf66e48a32301e35425dd3384f48a3d8
>
> TBR=dalecurtis@chromium.org,emircan@chromium.org,foolip@chromium.org,mkwst@chromium.org,guidou@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG= 720258 
>
> Review-Url: https://codereview.chromium.org/2985393002
> Cr-Commit-Position: refs/heads/master@{#490920}
> Committed: https://chromium.googlesource.com/chromium/src/+/b35b4c271b7819e3661942ab2c72083673722910

TBR=dalecurtis@chromium.org,emircan@chromium.org,foolip@chromium.org,mkwst@chromium.org,jkrcal@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 720258 

Review-Url: https://codereview.chromium.org/2994473002
Cr-Commit-Position: refs/heads/master@{#491341}

[modify] https://crrev.com/92561aec1fac0748d4e0ac3618ed7d2eb6ea9cb0/content/browser/webrtc/webrtc_getusermedia_browsertest.cc
[modify] https://crrev.com/92561aec1fac0748d4e0ac3618ed7d2eb6ea9cb0/content/renderer/media/webmediaplayer_ms.cc
[modify] https://crrev.com/92561aec1fac0748d4e0ac3618ed7d2eb6ea9cb0/content/renderer/media/webmediaplayer_ms.h
[modify] https://crrev.com/92561aec1fac0748d4e0ac3618ed7d2eb6ea9cb0/content/shell/test_runner/mock_web_user_media_client.cc
[modify] https://crrev.com/92561aec1fac0748d4e0ac3618ed7d2eb6ea9cb0/content/test/data/media/getusermedia.html

Status: Fixed (was: Started)

Sign in to add a comment