ext4crypto migration: Migrated file creation may not be synced to the disk as a directory entry |
|||||||||
Issue descriptionhttps://chromium.git.corp.google.com/chromiumos/platform2/+/b7d12cd87f02305a809f35bc5ca83fc03e0cb96c/cryptohome/dircrypto_data_migrator/migration_helper.cc#346 bool MigrationHelper::MigrateFile(...) { ... if (!platform_->SyncDirectory(to.DirName())) ... } |to| here is the root destination directory of the migration, not the currently migrated file. |to_child| looks to be the one we really wanted.
,
May 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/0a8b980c1d344fdfbdda5b5e5cb0662d565ddb57 commit 0a8b980c1d344fdfbdda5b5e5cb0662d565ddb57 Author: Kazuhiro Inaba <kinaba@chromium.org> Date: Thu May 11 01:59:36 2017 cryptohome: Make sure to sync the immediate parent of files newly migrated. BUG= chromium:720251 TEST=Migration success (the real failure case is hard to repro and not tested.) Change-Id: I8df677418515b20325a1d12aa45e40253d21e702 Reviewed-on: https://chromium-review.googlesource.com/501550 Tested-by: Kazuhiro Inaba <kinaba@chromium.org> Trybot-Ready: Kazuhiro Inaba <kinaba@chromium.org> Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Kazuhiro Inaba <kinaba@chromium.org> [modify] https://crrev.com/0a8b980c1d344fdfbdda5b5e5cb0662d565ddb57/cryptohome/dircrypto_data_migrator/migration_helper.cc
,
May 11 2017
,
May 11 2017
This bug can potentially lead to user-data loss so we highly want this to be in. The change is pretty small and should be safe to merge.
,
May 11 2017
,
May 12 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 15 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 16 2017
Blocked by a merge conflict until Bug 722225 is merge-approved (or rejected, in the latter case I'll try manual conflict resolution.)
,
May 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/290bce23787781b0f2bad7e9424b39a647891c42 commit 290bce23787781b0f2bad7e9424b39a647891c42 Author: Kazuhiro Inaba <kinaba@chromium.org> Date: Tue May 16 11:29:36 2017 cryptohome: Make sure to sync the immediate parent of files newly migrated. BUG= chromium:720251 TEST=Migration success (the real failure case is hard to repro and not tested.) Change-Id: I8df677418515b20325a1d12aa45e40253d21e702 Reviewed-on: https://chromium-review.googlesource.com/501550 Tested-by: Kazuhiro Inaba <kinaba@chromium.org> Trybot-Ready: Kazuhiro Inaba <kinaba@chromium.org> Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Kazuhiro Inaba <kinaba@chromium.org> (cherry picked from commit 0a8b980c1d344fdfbdda5b5e5cb0662d565ddb57) Reviewed-on: https://chromium-review.googlesource.com/505981 Reviewed-by: Kazuhiro Inaba <kinaba@chromium.org> [modify] https://crrev.com/290bce23787781b0f2bad7e9424b39a647891c42/cryptohome/dircrypto_data_migrator/migration_helper.cc
,
May 16 2017
,
May 16 2017
,
May 19 2017
Verified on Kevin cros:9567.0.0/60.0.3103.0 |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by kinaba@chromium.org
, May 10 2017