New issue
Advanced search Search tips

Issue 720248 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

bluetooth: "Turn on Bluetooth to allow pairing" chooser link is not valid

Project Member Reported by fbeaufort@chromium.org, May 10 2017

Issue description

Chrome Version       : 60.0.3092.0
OS Version: 9532.0.0

What steps will reproduce the problem?
1. Turn off Bluetooth
2. Go to https://googlechrome.github.io/samples/web-bluetooth/device-info.html
3. Bluetooth chooser shows up and contains "Turn on Bluetooth to allow pairing" link 
4. Click link

What is the expected result?
I should land on chrome settings page dedicated to Bluetooth

What happens instead of that?
I get Chrome settings page and I have to search manually for Bluetooth


In other words, chrome://settings/#bluetooth should be replaced by chrome://settings/?search=bluetooth

Or chrome://settings/#bluetooth should be handled by the "new" Material Design settings router.

 

Comment 1 by juncai@chromium.org, May 10 2017

Cc: -juncai@chromium.org
Owner: juncai@chromium.org

Comment 2 by juncai@chromium.org, May 11 2017

Status: Started (was: Unconfirmed)
Project Member

Comment 3 by bugdroid1@chromium.org, May 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/74728942d3888f8ca976f71a8f90390237540d09

commit 74728942d3888f8ca976f71a8f90390237540d09
Author: juncai <juncai@chromium.org>
Date: Fri May 12 00:05:03 2017

Fix "Turn on Bluetooth" chooser url link on ChromeOS

This CL changes the url string to "chrome://settings/#Bluetooth".

BUG= 720248 

Review-Url: https://codereview.chromium.org/2873963007
Cr-Commit-Position: refs/heads/master@{#471130}

[modify] https://crrev.com/74728942d3888f8ca976f71a8f90390237540d09/chrome/common/url_constants.cc

The URL string should be:

 chrome://settings/?search=bluetooth

Not 

  chrome://settings/#Bluetooth


Comment 5 by juncai@chromium.org, May 12 2017

ah, right! I actually tested it and due to the delay of chrome://settings/?search=bluetooth, its webpage initially had the same look as chrome://settings/#Bluetooth and I thought they are the same. Now after waiting for a while, the chrome://settings/?search=bluetooth lists only bluetooth setting, which chrome://settings/#Bluetooth doesn't.

Thanks! I'll submit a new CL to do that.
Project Member

Comment 6 by bugdroid1@chromium.org, May 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ec3781845fc302ff276f1bcd3f95d1499ba4494

commit 7ec3781845fc302ff276f1bcd3f95d1499ba4494
Author: juncai <juncai@chromium.org>
Date: Fri May 12 20:08:36 2017

Update "Turn on Bluetooth" chooser URL link on ChromeOS

The "Turn on Bluetooth" chooser URL link on ChromeOS should be:
chrome://settings/?search=bluetooth
instead of
chrome://settings/#Bluetooth

BUG= 720248 

Review-Url: https://codereview.chromium.org/2878913002
Cr-Commit-Position: refs/heads/master@{#471425}

[modify] https://crrev.com/7ec3781845fc302ff276f1bcd3f95d1499ba4494/chrome/common/url_constants.cc

Comment 7 by juncai@chromium.org, May 12 2017

Status: Fixed (was: Started)

Comment 8 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 9 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment