New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 720246 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Nothing happens after clicking on 'Edit' button in chrome://md-settings/content/cookies.

Reported by rp...@etouch.net, May 10 2017

Issue description

Version: 59.0.3071.47 11e144fef00160b11b4149197763e8c4387791fb-refs/branch-heads/3071@{#475}
OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.11.6,10.12.3)

What steps will reproduce the problem?
1. Launch chrome, navigate to chrome://md-settings/content/cookies.
2. Now click on 'Add' button and open 'incognito' window and minimize it and then type text and 'Add a site'
3. Now click on 'More actions' iron icon and click on 'Edit' option and close the minimized 'incognito' window and click on 'Edit' button,observe

Actual: Nothing happens after clicking on 'Edit' button
Expected: Action should be performed after clicking on 'Edit' button

This is a non-regression issue, seen from M-58 series as 'Edit' button appears from build # 58.0.3022.0

Kindly review the attached video for reference.
 
Actual_video.mp4
770 KB View Download
Labels: -M-59 M-60
Status: Untriaged (was: Unconfirmed)
Changing the status to Untriaged, so that the issue would get addressed.
Thank You.
Cc: aee@chromium.org
Labels: -M-60 M-68
Status: Available (was: Untriaged)
I am still able to reproduce this. Also note that upon clicking "edit" in the dialog a runtime error is thrown in the console, (see attachment).

Uncaught TypeError: Cannot read property 'origin' of null
    at HTMLElement.onActionButtonTap_ (lazy_load.crisper.js:128)
    at HTMLElement.handler (polymer-extracted.js:491)
cookies_runtime_error.png
15.3 KB View Download

Comment 3 by aee@chromium.org, May 1 2018

Cc: -aee@chromium.org
Owner: aee@chromium.org
Status: Assigned (was: Available)

Comment 4 by aee@chromium.org, May 7 2018

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, May 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1ecf57c5951b283dc8f4b008aa025a24e02a24a

commit d1ecf57c5951b283dc8f4b008aa025a24e02a24a
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Tue May 08 22:32:34 2018

Settings: close dialog on incognito status change

Bug:  720246 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I299f27870787919eabd9553d21d026e447cd470f
Reviewed-on: https://chromium-review.googlesource.com/1047971
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556987}
[modify] https://crrev.com/d1ecf57c5951b283dc8f4b008aa025a24e02a24a/chrome/browser/resources/settings/site_settings/edit_exception_dialog.js
[modify] https://crrev.com/d1ecf57c5951b283dc8f4b008aa025a24e02a24a/chrome/browser/resources/settings/site_settings/site_list.js
[modify] https://crrev.com/d1ecf57c5951b283dc8f4b008aa025a24e02a24a/chrome/test/data/webui/settings/site_list_tests.js

Comment 6 by aee@chromium.org, May 9 2018

Status: Fixed (was: Started)

Sign in to add a comment