New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 720242 link

Starred by 1 user
Status: Untriaged
Owner: ----
Cc:
qyears...@chromium.org
█ mcgreevy@chromium.org
dpranke@chromium.org
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Layout Tests runs content shell with '--register-font-files="e:\b\s\w\ir\out\Release\/AHEM____.TTF"' on Windows

Project Member Reported by tansell@chromium.org, May 10 2017 
Layout Tests runs the content shell with the following command line argument;

"e:\b\s\w\ir\out\Release\content_shell.exe" --type=gpu-process --disable-gpu-rasterization --enable-logging --run-layout-test --enable-crash-reporter --crash-dumps-dir="e:\b\s\w\ir\out\Release\crash-dumps" --register-font-files="e:\b\s\w\ir\out\Release\/AHEM____.TTF" --use-gl=osmesa --supports-dual-gpus=false --gpu-vendor-id=0x0000 --gpu-device-id=0x0000 --gpu-driver-vendor --gpu-driver-version=9.0.3 --gpu-driver-date --run-layout-test --enable-crash-reporter --crash-dumps-dir="e:\b\s\w\ir\out\Release\crash-dumps" --register-font-files="e:\b\s\w\ir\out\Release\/AHEM____.TTF" --enable-logging --service-request-channel-token=328ECF4896E35D5F946F41ABA5805E55 --mojo-platform-channel-handle=1980 --ignored=" --type=renderer " /prefetch:2

This part doesn't seem right;
 --register-font-files="e:\b\s\w\ir\out\Release\/AHEM____.TTF"

The 'Release\/AHEM' part.

(Also why is /prefetch:2 different from the other arguments?)

Comment 1 by dpranke@chromium.org, May 11 2017 

To be clear: that's not run-webkit-tests invoking content_shell, that's the content_shell browser process invoking the content_shell gpu process.

I believe we pass the font paths around like this in order to work around the limitations of the sandbox, as per https://cs.chromium.org/chromium/src/content/test/layouttest_support.cc?l=154 

Unless you're asking about the "out\Release\/" part and the inconsistent use of forward/backward, in which case that's probably just a dumb bug that works fine.

As to why we have "/prefetch:2" instead of something like "--prefetch=2", I have no idea but it looks to be correct. I'd probably ask jam@ or rockot@.

Comment 2 by tansell@chromium.org, May 22 2017 

Yes, I'm concerned about the backslash+forwardslash between the Release and AHEM part.

Does Windows just ignore the forward slash?

Comment 3 by dpranke@chromium.org, May 22 2017 

> Yes, I'm concerned about the backslash+forwardslash between the Release 
> and AHEM part.
>
> Does Windows just ignore the forward slash?

I believe so.

Comment 4 by jsb...@chromium.org, Oct 19 2017

Status: Available (was: Untriaged)
Yeah, harmless but someone could fix.
Project Member

Comment 5 by sheriffbot@chromium.org, Oct 22

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by dpranke@chromium.org, Nov 6

Components: -Blink>Infra Blink
Moving this out of Blink>Infra; (a) that's not really an active component and (b) I don't think this is infra-specific.

Comment 8 by tkent@chromium.org, Nov 7

Components: -Blink Blink>Infra

Comment 9 by dpranke@chromium.org, Nov 7 

@tkent - did you see my comment in #c7?

Comment 10 by foolip@chromium.org, Nov 13

Components: -Blink>Infra
Trying again :)
►

Sign in to add a comment