Face Detection: Close() handle before finalize() to avoid spamming adb logs |
|||
Issue descriptionChrome: 60.0.3094.0 Device name: Pixel 7.1.2 My adb logs are full of warnings when I call faceDetector.detect(): 05-04 08:17:55.990 11907 11925 W HandleImpl: Handle was not closed. 05-04 08:17:55.992 11907 11925 W HandleImpl: Handle was not closed. 05-04 08:17:56.340 11907 11925 W HandleImpl: Handle was not closed. 05-04 08:17:56.340 11907 11925 W HandleImpl: Handle was not closed. 05-04 08:17:56.471 11907 11925 W HandleImpl: Handle was not closed. 05-04 08:17:56.471 11907 11925 W HandleImpl: Handle was not closed. mcasas@ said: the warning is because the Handle goes to finalize() without me having close()d it; it's inoffensive, but annoying, I should do something about it :-/
,
May 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/672bf2b83170847857eea5ac6d0e2f1f71dacac4 commit 672bf2b83170847857eea5ac6d0e2f1f71dacac4 Author: mcasas <mcasas@chromium.org> Date: Thu May 11 17:16:51 2017 Shape Detection Android: unmap() and close() SharedBufferHandles explicitly This CL unmap()s and close()s the handle after it has been used, preventing the harmless but annoying Log [1] 05-10 12:05:23.985 30381 30389 W HandleImpl: Handle was not closed. and optimising resource usage by not having to wait until Handle finalize() to release them. [1] https://cs.chromium.org/chromium/src/mojo/android/system/src/org/chromium/mojo/system/impl/HandleBase.java?type=cs&l=133 BUG= 720234 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2873093003 Cr-Commit-Position: refs/heads/master@{#470990} [modify] https://crrev.com/672bf2b83170847857eea5ac6d0e2f1f71dacac4/services/shape_detection/android/java/src/org/chromium/shape_detection/SharedBufferUtils.java
,
May 11 2017
,
May 12 2017
Verified in Chromium 60.3097.0 |
|||
►
Sign in to add a comment |
|||
Comment 1 by mcasas@chromium.org
, May 10 2017Status: Started (was: Unconfirmed)