The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f6e95c3d37313a5de99cfadcb5ffd7a3595a1653

commit f6e95c3d37313a5de99cfadcb5ffd7a3595a1653
Author: ramyasharma <ramyasharma@chromium.org>
Date: Sat May 13 16:53:47 2017

Implements logging in the new compact translate UI.

1. Adds enumerated logging events.
2. Adds language code information in separate histograms
 for user events, by re-using the
 CLD3LanguageCode enums for logging.

BUG= 720231 
TBR=groby@chromium.org

Review-Url: https://codereview.chromium.org/2873103003
Cr-Commit-Position: refs/heads/master@{#471593}

[modify] https://crrev.com/f6e95c3d37313a5de99cfadcb5ffd7a3595a1653/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java
[modify] https://crrev.com/f6e95c3d37313a5de99cfadcb5ffd7a3595a1653/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateInfoBar.java
[modify] https://crrev.com/f6e95c3d37313a5de99cfadcb5ffd7a3595a1653/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateLanguagePanel.java
[modify] https://crrev.com/f6e95c3d37313a5de99cfadcb5ffd7a3595a1653/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateOptions.java
[modify] https://crrev.com/f6e95c3d37313a5de99cfadcb5ffd7a3595a1653/chrome/android/javatests/src/org/chromium/chrome/browser/translate/TranslateOptionsTest.java
[modify] https://crrev.com/f6e95c3d37313a5de99cfadcb5ffd7a3595a1653/chrome/browser/translate/android/translate_utils.cc
[modify] https://crrev.com/f6e95c3d37313a5de99cfadcb5ffd7a3595a1653/chrome/browser/translate/android/translate_utils.h
[modify] https://crrev.com/f6e95c3d37313a5de99cfadcb5ffd7a3595a1653/chrome/browser/ui/android/infobars/translate_compact_infobar.cc
[modify] https://crrev.com/f6e95c3d37313a5de99cfadcb5ffd7a3595a1653/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/f6e95c3d37313a5de99cfadcb5ffd7a3595a1653/tools/metrics/histograms/histograms.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e56466a77adc37fef96e5069293c0b22ad2c49d

commit 1e56466a77adc37fef96e5069293c0b22ad2c49d
Author: ramyasharma <ramyasharma@chromium.org>
Date: Wed May 17 06:29:39 2017

Adds logging metrics to translate infobar.

Adds the following:
1. Differenciate between always translate and undo always translate
from the options menu,
2. Translate decline and close infobar events.
3. Count of number of times a page was translated.

BUG= 720231 

Review-Url: https://codereview.chromium.org/2878363002
Cr-Commit-Position: refs/heads/master@{#472351}

[modify] https://crrev.com/1e56466a77adc37fef96e5069293c0b22ad2c49d/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java
[modify] https://crrev.com/1e56466a77adc37fef96e5069293c0b22ad2c49d/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/1e56466a77adc37fef96e5069293c0b22ad2c49d/tools/metrics/histograms/histograms.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9121a4ac27246ad626607d10ae1009b29b20f858

commit 9121a4ac27246ad626607d10ae1009b29b20f858
Author: martiw <martiw@chromium.org>
Date: Thu May 18 04:08:07 2017

Add logging events for auto-always, auto-never (new translate infobar)
1. log the auto-always event. (triggered when translated counter reaches
   a threshold)
2. log the auto-never event. (triggered when denied counter reaches a
   threshold)
3. log the cancel clicks of the 2 events above.

BUG= 720231 

Review-Url: https://codereview.chromium.org/2886873006
Cr-Commit-Position: refs/heads/master@{#472655}

[modify] https://crrev.com/9121a4ac27246ad626607d10ae1009b29b20f858/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java
[modify] https://crrev.com/9121a4ac27246ad626607d10ae1009b29b20f858/tools/metrics/histograms/enums.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c378166dd1a360be0ccf9359631e5765dc544209

commit c378166dd1a360be0ccf9359631e5765dc544209
Author: ramyasharma <ramyasharma@chromium.org>
Date: Fri May 26 08:11:26 2017

Adds translate infobar impression in the old Translate UI on Android

This is added so that we can compare the impressions in old UI and
the new one.

BUG= 720231 

Review-Url: https://codereview.chromium.org/2897233002
Cr-Commit-Position: refs/heads/master@{#474961}

[modify] https://crrev.com/c378166dd1a360be0ccf9359631e5765dc544209/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateInfoBar.java
[modify] https://crrev.com/c378166dd1a360be0ccf9359631e5765dc544209/tools/metrics/histograms/histograms.xml

Requesting merge for #5 : https://codereview.chromium.org/2897233002. 

Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07ebfcba02801742f0a4f892898d4c76d69cd219

commit 07ebfcba02801742f0a4f892898d4c76d69cd219
Author: ramyasharma <ramyasharma@chromium.org>
Date: Mon May 29 06:00:01 2017

Adds translate infobar impression in the old Translate UI on Android

This is added so that we can compare the impressions in old UI and
the new one.

BUG= 720231 
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2897233002
Cr-Original-Commit-Position: refs/heads/master@{#474961}
Review-Url: https://codereview.chromium.org/2908993002
Cr-Commit-Position: refs/branch-heads/3112@{#13}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] https://crrev.com/07ebfcba02801742f0a4f892898d4c76d69cd219/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateInfoBar.java
[modify] https://crrev.com/07ebfcba02801742f0a4f892898d4c76d69cd219/tools/metrics/histograms/histograms.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73c615314462fcb1eb0774d9be2cbccfb5c38414

commit 73c615314462fcb1eb0774d9be2cbccfb5c38414
Author: ramyasharma <ramyasharma@chromium.org>
Date: Wed Jun 14 06:27:52 2017

Changes to metrics logging on translate UI in Android.

Based on discussions with the PM, following changes are being made:

1) Rename "Tab language clicked" to "Translation accepted by clicking
on tab language".
2) Make sure that when a language is picked from more languages,
it's logged in the Translate.CompactInfobar.Event histogram as
"Translation accepted by clicking on language in more languages"
3) Rename "Translate services declined" to "X is clicked without
a prior translation and without a choice of never translate"
4) Always translate clicked, Never translate clicked, Never
translate site clicked, Undo always translate -
update all 4 to end in "in the options menu"
5) Always translate snackbar impression, Never translate snackbar
impression, Never translate site snackbar impression, Cancel
clicked on always translate snackbar, Cancel clicked on never
translate this site snackbar, Cancel clicked on never translate
snackbar - update all 6 to end in
"when triggered from the options menu"
6) "Infobar closed" get rid off
7) Rename description "Translate.InfobarShown" to indicate
it's for the old UI
8) Add logic for translate declined (this was removed in another cl
by mistake).

BUG= 720231 

Review-Url: https://codereview.chromium.org/2938453004
Cr-Commit-Position: refs/heads/master@{#479306}

[modify] https://crrev.com/73c615314462fcb1eb0774d9be2cbccfb5c38414/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java
[modify] https://crrev.com/73c615314462fcb1eb0774d9be2cbccfb5c38414/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/73c615314462fcb1eb0774d9be2cbccfb5c38414/tools/metrics/histograms/histograms.xml

Requesting merge request for #10, improvements in metrics, so we can track the new feature better.

This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

amineer@ can I get an approval for this?

Approved for M60 branch 3112.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21618e7dc6ce5148fd09bdb6abb3f6191a70ad63

commit 21618e7dc6ce5148fd09bdb6abb3f6191a70ad63
Author: ramyasharma <ramyasharma@chromium.org>
Date: Mon Jun 19 01:04:18 2017

Changes to metrics logging on translate UI in Android.

Based on discussions with the PM, following changes are being made:

1) Rename "Tab language clicked" to "Translation accepted by clicking
on tab language".
2) Make sure that when a language is picked from more languages,
it's logged in the Translate.CompactInfobar.Event histogram as
"Translation accepted by clicking on language in more languages"
3) Rename "Translate services declined" to "X is clicked without
a prior translation and without a choice of never translate"
4) Always translate clicked, Never translate clicked, Never
translate site clicked, Undo always translate -
update all 4 to end in "in the options menu"
5) Always translate snackbar impression, Never translate snackbar
impression, Never translate site snackbar impression, Cancel
clicked on always translate snackbar, Cancel clicked on never
translate this site snackbar, Cancel clicked on never translate
snackbar - update all 6 to end in
"when triggered from the options menu"
6) "Infobar closed" get rid off
7) Rename description "Translate.InfobarShown" to indicate
it's for the old UI
8) Add logic for translate declined (this was removed in another cl
by mistake).

BUG= 720231 
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2938453004
Cr-Original-Commit-Position: refs/heads/master@{#479306}
Review-Url: https://codereview.chromium.org/2949433002
Cr-Commit-Position: refs/branch-heads/3112@{#378}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] https://crrev.com/21618e7dc6ce5148fd09bdb6abb3f6191a70ad63/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java
[modify] https://crrev.com/21618e7dc6ce5148fd09bdb6abb3f6191a70ad63/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/21618e7dc6ce5148fd09bdb6abb3f6191a70ad63/tools/metrics/histograms/histograms.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9042646a88a043a9918ffec4851320df1bda6fe2

commit 9042646a88a043a9918ffec4851320df1bda6fe2
Author: ramyasharma <ramyasharma@chromium.org>
Date: Thu Jul 06 13:00:06 2017

Adds logging to indicate infobar creation in the native library,
before the control goes to Android.

This is added to get a better idea about the metrics we are seeing.

BUG= 720231 
TBR=mdjones@chromium.org

Review-Url: https://codereview.chromium.org/2968103002
Cr-Commit-Position: refs/heads/master@{#484562}

[modify] https://crrev.com/9042646a88a043a9918ffec4851320df1bda6fe2/chrome/browser/ui/android/infobars/translate_infobar.cc
[modify] https://crrev.com/9042646a88a043a9918ffec4851320df1bda6fe2/components/translate/core/browser/translate_browser_metrics.h
[modify] https://crrev.com/9042646a88a043a9918ffec4851320df1bda6fe2/tools/metrics/histograms/enums.xml

Requesting merge for #18. This will give a clearer idea of whats going on with the experiment, and help us make decision regarding stable launch.

This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

We only have a single beta left and this is not critical - it should not have been requested for a merge, please read the guidelines at https://chromium.googlesource.com/chromium/src.git/+/master/docs/process/merge_request.md.

Rejected for M60.

Hey Alex, can we make an exception for this merge? We can't make sense of our experiment in 60 without these additional metrics.