New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 720215 link

Starred by 2 users

Issue metadata

Status: Closed
Owner: ----
Closed: Sep 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Migrate to &access_token= and remove ShareDialog.WebViewAuthorizer class.

Project Member Reported by mtomasz@chromium.org, May 10 2017

Issue description

We no longer need to inject an oauth token as a http request header using hooks. This was a tricky part of the share dialog, which we can remove now.

https://cs.chromium.org/chromium/src/ui/file_manager/file_manager/foreground/js/ui/share_dialog.js?rcl=04b4874993cea9341a2d3446bcc486f52916477c&l=113
 
Cc: -yamaguchi@chromium.org
Labels: CleanUp
Owner: yamaguchi@chromium.org
Status: Assigned (was: Available)
yamaguchi@, could you take a look as a side task? I think you can get help from mtomasz@
Cc: mtomasz@chromium.org

Comment 3 by sashab@chromium.org, Feb 24 2018

Labels: CrOS-FilesApp-CodeHealth

Comment 4 by sashab@chromium.org, Feb 24 2018

Labels: -CleanUp

Comment 5 by sashab@chromium.org, Feb 28 2018

Labels: -CrOS-FilesApp-CodeHealth CrOSFilesCategory-CodeHealth

Comment 6 by sashab@chromium.org, Feb 28 2018

Labels: CrOS-FilesApp-FileIntents

Comment 7 by sashab@chromium.org, Feb 28 2018

Labels: -CrOS-FilesApp-FileIntents CrOSFilesFeature-FileIntents
Cc: yamaguchi@chromium.org
Owner: ----
Status: Available (was: Assigned)
Status: Closed (was: Available)
Code's been deleted.

Sign in to add a comment