New issue
Advanced search Search tips

Issue 720210 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

Some tests from telemetry_perf_unittests are failing flakily

Project Member Reported by chromium...@appspot.gserviceaccount.com, May 10 2017

Issue description

"benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop.load:social:twitter" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyfgsSBUZsYWtlInNiZW5jaG1hcmtzLnN5c3RlbV9oZWFsdGhfc21va2VfdGVzdC5TeXN0ZW1IZWFsdGhCZW5jaG1hcmtTbW9rZVRlc3Quc3lzdGVtX2hlYWx0aC5tZW1vcnlfZGVza3RvcC5sb2FkOnNvY2lhbDp0d2l0dGVyDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 

Comment 1 by yutak@chromium.org, May 10 2017

 Issue 720211  has been merged into this issue.

Comment 2 by yutak@chromium.org, May 10 2017

 Issue 720196  has been merged into this issue.

Comment 3 by yutak@chromium.org, May 10 2017

 Issue 720182  has been merged into this issue.

Comment 4 by yutak@chromium.org, May 10 2017

Labels: OS-Windows
Summary: Some tests from telemetry_perf_unittests are failing flakily (was: "benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop.load:social:twitter" is flaky)
The following tests from telemetry_perf_unittests are sometimes failing.

* benchmarks.benchmark_smoke_unittest.BenchmarkSmokeTest.blink_perf.shadow_dom
* benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop.browse:search:google
* benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop.load:media:flickr
* benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop.load:news:wikipedia
* benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop.load:social:twitter
* benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop.play:media:pandora
* measurements.clock_domain_test.ClockDomainTest.testTelemetryUsesChromeClockDomain

Crash log looks like:

  Stack Trace:
  ********************************************************************************
  	Last event: da4.388: Break instruction exception - code 80000003 (first/second chance not available)
  	  debugger time: Tue May  9 02:13:54.096 2017 (UTC - 7:00)
  	ChildEBP RetAddr  Args to Child              
  	004ce5dc 6fbe9b57 004ce604 6fbe95f9 714be0f8 chrome_6f330000!base::debug::BreakDebugger+0x9
  	004ce5e4 6fbe95f9 714be0f8 000000f2 024ec872 chrome_6f330000!?Run@?$Invoker@U?$BindState@P6AXPBDHV?$BasicStringPiece@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@base@@1@Z$$V@internal@base@@$$A6AXPBDHV?$BasicStringPiece@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@3@1@Z@internal@base@@SAXPAVBindStateBase@23@$$QAPBD$$QAH$$QAV?$BasicStringPiece@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@3@3@Z+0x27
  	004ce604 6fbe9b4a 6fbe9b4f 004ce778 004ce77c chrome_6f330000!base::internal::FunctorTraits<void (__cdecl*)(char const *,int,base::BasicStringPiece<std::basic_string<char,std::char_traits<char>,std::allocator<char> > >,base::BasicStringPiece<std::basic_string<char,std::char_traits<char>,std::allocator<char> > >),void>::Invoke<char const *,int,base::BasicStringPiece<std::basic_string<char,std::char_traits<char>,std::allocator<char> > >,base::BasicStringPiece<std::basic_string<char,std::char_traits<char>,std::allocator<char> > > >+0x20
  	004ce620 6fc09d98 025def58 004ce778 004ce77c chrome_6f330000!?Run@?$Invoker@U?$BindState@P6AXPBDHV?$BasicStringPiece@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@base@@1@Z$$V@internal@base@@$$A6AXPBDHV?$BasicStringPiece@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@3@1@Z@internal@base@@SAXPAVBindStateBase@23@$$QAPBD$$QAH$$QAV?$BasicStringPiece@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@3@3@Z+0x1a
  	004ceba8 6fc6a4e4 025ca9f0 025ccff0 024bca80 chrome_6f330000!logging::LogMessage::~LogMessage+0x328
  	004cec8c 6fba6c03 7136a040 025ccff0 024c8078 chrome_6f330000!base::win::RegKey::DeleteKey+0x64
  	004cf07c 6fba5171 025ccff0 00000000 00000000 chrome_6f330000!ChromeBrowserMainParts::SetupFieldTrials+0x5aa
  	004cf300 6fba4712 025ccff0 025ca968 00000001 chrome_6f330000!ChromeBrowserMainParts::PreCreateThreadsImpl+0x967
  	004cf48c 6fb8d2aa 025f3618 71a8ea6c 00000000 chrome_6f330000!ChromeBrowserMainParts::PreCreateThreads+0x72
  	004cf4e4 6f6b12cd 00000000 025d0db8 025d0d88 chrome_6f330000!ChromeBrowserMainPartsWin::PreCreateThreads+0x129
  	004cf564 6f90ec1e 025d6af0 025f3618 025f36c8 chrome_6f330000!content::BrowserMainLoop::PreCreateThreads+0x7a
  	004cf580 6f6af459 00000000 0ef0dee8 00000000 chrome_6f330000!content::StartupTaskRunner::RunAllTasksNow+0x23
  	004cf5e0 6f6b2662 025ca978 025f0620 00000000 chrome_6f330000!content::BrowserMainLoop::CreateStartupTasks+0x18a
  	004cf704 6f6ae0b2 004cf8b8 00000000 025ca978 chrome_6f330000!content::BrowserMainRunnerImpl::Initialize+0x2c0
  	004cf720 6fb19c50 004cf8b8 00000000 00000003 chrome_6f330000!content::BrowserMain+0x75
  	004cf7e4 6fb19b6f 004cf900 004cf8b8 004cfc34 chrome_6f330000!content::RunNamedProcessTypeMain+0xb0
  	004cf91c 6fb2aa20 007227f8 71e3910f 00000000 chrome_6f330000!content::ContentMainRunnerImpl::Run+0x19d
  	004cfb40 6fb1939b 004cfb6c 71e3910f 71486a38 chrome_6f330000!service_manager::Main+0x20c
  	004cfb70 6f3f97e9 004cfc50 00000000 006f7ad0 chrome_6f330000!content::ContentMain+0x27
  	*** WARNING: Unable to verify checksum for chrome.exe
  	004cfc68 00264f13 00260000 004cfc8c 0eeb9cc0 chrome_6f330000!ChromeMain+0xb4
  	004cfcf0 00262cbd 00260000 0eeb9cc0 00000000 chrome!MainDllLoader::Launch+0x1bc
  	004cfe14 002b6398 00260000 00000000 00752556 chrome!wWinMain+0x17f
  	*** WARNING: Unable to verify checksum for kernel32.dll
  	*** ERROR: Symbol file could not be found.  Defaulted to export symbols for kernel32.dll - 
  	(Inline) -------- -------- -------- -------- chrome!invoke_main+0x1a
  	004cfe60 74ec336a fffde000 004cfeac 77459882 chrome!__scrt_common_main_seh+0xf6
  	WARNING: Stack unwind information not available. Following frames may be wrong.
  	004cfe6c 77459882 fffde000 771d1d6a 00000000 kernel32!BaseThreadInitThunk+0x12
  	004cfeac 77459855 002b6410 fffde000 00000000 ntdll!RtlInitializeExceptionChain+0x63
  	004cfec4 00000000 002b6410 fffde000 00000000 ntdll!RtlInitializeExceptionChain+0x36
  	

Comment 5 by yutak@chromium.org, May 10 2017

Cc: yutak@chromium.org
Owner: fdoray@chromium.org
Status: Assigned (was: Untriaged)
This seems to come from a DCHECK in RegKey::DeleteKey() which checks if the key is
not null.

The following code does not check if RegKey is successfully created:

https://cs.chromium.org/chromium/src/chrome/browser/chrome_browser_main.cc?q=chrome/browser/chrome_browser_main.cc+package:%5Echromium$&dr&l=774

So this sounds like the offender. fdoray, do you have any idea about this?

Comment 6 by yutak@chromium.org, May 10 2017

 Issue 720265  has been merged into this issue.

Comment 7 by yutak@chromium.org, May 10 2017

 Issue 720266  has been merged into this issue.

Comment 8 by fdoray@chromium.org, May 10 2017

Fix under review https://codereview.chromium.org/2875633002/

Comment 9 by fdoray@chromium.org, May 10 2017

Cc: fdoray@chromium.org iclell...@chromium.org
 Issue 720069  has been merged into this issue.

Comment 10 by grt@chromium.org, May 10 2017

Labels: -Sheriff-Chromium
Status: Started (was: Assigned)
Removing Sheriff-Chromium label since this has an owner.
Project Member

Comment 11 by bugdroid1@chromium.org, May 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f57af188a5c2c4ac67aa6ed198a37e39cb7f6d6

commit 2f57af188a5c2c4ac67aa6ed198a37e39cb7f6d6
Author: fdoray <fdoray@chromium.org>
Date: Thu May 11 10:23:11 2017

Remove code that deletes the PreReadFieldTrial registry key.

The code that deletes the PreReadFieldTrial registry key landed in M55.
The key should now have been deleted from every client and the deletion
code should no longer be needed.

BUG= 720210 ,557984

Review-Url: https://codereview.chromium.org/2875633002
Cr-Commit-Position: refs/heads/master@{#470901}

[modify] https://crrev.com/2f57af188a5c2c4ac67aa6ed198a37e39cb7f6d6/chrome/browser/chrome_browser_main.cc

Comment 12 by wnwen@chromium.org, May 11 2017

This is also failing:
benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_mobile.browse:news:toi

Comment 13 by wnwen@chromium.org, May 11 2017

Although that one is on Android.
Status: Fixed (was: Started)
The Windows crash has been fixed.

Sign in to add a comment