New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 720207 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 730661
Owner: ----
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

minimum font size on <canvas> too big when zoom

Reported by zcyzcy88...@gmail.com, May 10 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:53.0) Gecko/20100101 Firefox/53.0

Steps to reproduce the problem:
0. All DSF are same, because #enable-use-zoom-for-dsf

1. Set minimum font size as 16px
2. Open a webpage with <canvas> (e.g. Google Sheet)
3. Zoom to 100%, look the DOM text and the <canvas> text, they are both inflated by minimum font size.

What is the expected behavior?

What went wrong?
4. Zoom to 200%, the DOM text is not inflated since the are 16px+ in real size, the <canvas> text is too big.

Seen like <canvas> has implemented `minimum font size` but forget that page can zoom.

Did this work before? No 

Chrome version: 60.0.3094.0  Channel: canary
OS Version: 10.0
Flash Version: 

Please fix it.
Or consider don't implement `minimum font size` on <canvas>.
 
100.png
191 KB View Download
200.png
203 KB View Download

Comment 1 by ajha@chromium.org, May 10 2017

Labels: Needs-Triage-M60

Comment 2 by ajha@chromium.org, May 11 2017

Cc: ajha@chromium.org
Labels: Needs-Feedback
@reporter: Could you please share any such sheet which exhibit this behavior. Somehow I was unable to repro this at 100% zoom level and on google sheet with text content.
Project Member

Comment 4 by sheriffbot@chromium.org, May 12 2017

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding requester "ajha@chromium.org" to the cc list and removing "Needs-Feedback" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: kkaluri@chromium.org
Labels: Needs-Feedback
Unable to reproduce this issue on Windows 10 with chrome #61.0.3114.0

Observed that both DOM and Canvas texts are inflated according to page zoom.

Attaching a screen-cast for reference.

zcyzcy88888126.com@ Could you please look into it and let us know your observations.

Thank You...


Issue 720207.mp4
1.1 MB View Download
You forget to set {{minimum}} font size as 16px.
You are interesting.
2017-05-30 22_47_02-720207 - minimum font size on _canvas_ too big when zoom - chromium - Monorail.png
220 KB View Download
Project Member

Comment 7 by sheriffbot@chromium.org, May 30 2017

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding requester "kkaluri@chromium.org" to the cc list and removing "Needs-Feedback" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: Needs-Feedback
Retested this issue on Windows 10 with chrome #61.0.3115.0 as per comment #6

Observed that both DOM and Canvas texts are inflated according to page zoom.

Attaching a screen-cast for reference.

zcyzcy88888126.com@ Could you retry this issue on clean profile with no apps/extensions and let us know your observations.

Thank You...
Issue 720207-1.mp4
1.6 MB View Download
Oh... This is obviously enough.

off.png
272 KB View Download
off_zoom.png
299 KB View Download
on_zoom.png
364 KB View Download
Project Member

Comment 10 by sheriffbot@chromium.org, May 31 2017

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding requester "kkaluri@chromium.org" to the cc list and removing "Needs-Feedback" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Or, this is pseudo code:


canvas_rendering_font_size = zoom( Math.max(declared_font_size, minimum_font_size), zoom_rate )

DOM_rendering_font_size = Math.max( zoom(declared_font_size, zoom_rate), minimum_font_size )
Cc: krajshree@chromium.org
Components: UI>Browser>Zoom
Labels: Needs-Feedback
Unable to reproduce the issue on Win-10 using chrome reported version #60.0.3094.0 and latest canary #61.0.3122.0.

Attached a screen cast for reference.

Following are the steps followed to reproduce the issue.
------------
1. Enabled the #enable-use-zoom-for-dsf flag and set minimum font size as 16px.
2. Opened https://docs.google.com/spreadsheets/d/1pF7a0_49myX5PqAPJKirq4UH_vw46t6ClOV37ITBpEY/edit?usp=sharing webpage provided in comment #3.
3. Zoomed to 200%.
4. Observed that both DOM and Canvas texts are inflated according to page zoom.

Reporter@ - Could you please check this issue on latest canary #61.0.3122.0 by creating a new profile without any apps and extensions and please let us know if the issue still persist or not.

Could anyone from UI>Browser>Zoom team please have a look into this issue.

Thanks...!!
Attaching screen cast.
720207.mp4
1.7 MB View Download
Well, may my English is too bad too understand, I repeat again.

This issue keyword is:
too big / twice inflate / unnecessary inflate

The logic for DOM:
Firstly apply `minimum font size`, then zoom.

The logic for <canvas>:
Firstly zoom, then apply `minimum font size`.

--------------------------

Solution:
I finally find under the hood:  Issue 730661 

Project Member

Comment 15 by sheriffbot@chromium.org, Jun 7 2017

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding requester "krajshree@chromium.org" to the cc list and removing "Needs-Feedback" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Components: Blink>Canvas
Mergedinto: 730661
Status: Duplicate (was: Unconfirmed)
duping into 730661, please undupe it if anybody feel so.

Sign in to add a comment