New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 720199 link

Starred by 3 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Optimize FaviconCache for low end devices

Project Member Reported by ssid@chromium.org, May 10 2017

Issue description

The Favicon cache has a limit of 200 in-memory images stored. This uses 200KB of memory on low-end devices. 

Can we remove the cache for low-end devices? What will happen if we do not sync favicon? Where is the favicon used?
If not, can the limit be changed to 10? This would save 200KB of memory.
 

Comment 1 by ssid@chromium.org, May 10 2017

Attaching a trace file.
FaviconCache::GetFaviconInfo() allocates 150KB.
GetImageDataFromSpecifics allocates 50KB.
trace_bookmark_test3.json
9.1 MB View Download

Comment 2 by pav...@chromium.org, May 17 2017

Cc: ew...@chromium.org
Owner: ----
ssid@: How easy is it to detect that we are running on low end device?

Comment 3 by ssid@chromium.org, May 18 2017

You can just call SysInfo::IsLowEndDevice().

Comment 4 by ew...@chromium.org, May 19 2017

What're the user-facing implications of removing the favicon cache? Will the favicons in the bookmark manager just take longer to load, since they'll have to be fetched from disk?

Comment 5 by zea@chromium.org, May 19 2017

This only affects favicons in the history page/recent tabs. Bookmarks will continue to work fine.

Comment 6 by ew...@chromium.org, May 19 2017

And the effect would be that favicons would just take longer to load, not that they wouldn't be there at all, correct?

Comment 7 by zea@chromium.org, May 19 2017

Cc: pkotw...@chromium.org
They would only load if the device had been to that same page. If the page was only visited on a foreign device, the favicon would just not load I believe.

+Peter, as there has also been some work about fetching of favicons automatically on the device. Although I don't think that's done yet?

Comment 8 by gangwu@chromium.org, Jun 21 2017

Owner: zea@chromium.org
Fetching favicons on demand for Zine has been implemented by mastiz@ and jkrcal@
There were discussions about expanding the fetching on demand for chrome://settings on the desktop (passwords and search engines) but no one has stepped up to do that work (I haven't stepped up either)
Status: Assigned (was: Untriaged)

Comment 11 by zea@chromium.org, Jan 17 2018

Labels: SyncHandoff2018
Owner: ----
Status: Available (was: Assigned)
We should probably just get rid of the favicons datatype at this point, but leaving this open for the MUC handoff.
Project Member

Comment 12 by sheriffbot@chromium.org, Jan 18 (5 days ago)

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment