New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 720190 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: May 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Do not show the display rotation notification in tablet mode unless it's explicitly changed by a user (shortcut)

Project Member Reported by osh...@chromium.org, May 10 2017

Issue description

internal bug b/37988215
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48358e269fbafbae5df07b4a82f0a7762f1ce19b

commit 48358e269fbafbae5df07b4a82f0a7762f1ce19b
Author: oshima <oshima@chromium.org>
Date: Wed May 10 05:37:11 2017

Don't show rotation change notification in tablet mode unless it's changed by user.

BUG= 720190 
TEST=covered by unit test

Review-Url: https://codereview.chromium.org/2866423002
Cr-Commit-Position: refs/heads/master@{#470482}

[modify] https://crrev.com/48358e269fbafbae5df07b4a82f0a7762f1ce19b/ash/system/screen_layout_observer.cc
[modify] https://crrev.com/48358e269fbafbae5df07b4a82f0a7762f1ce19b/ash/system/screen_layout_observer_unittest.cc

Comment 2 by osh...@chromium.org, May 10 2017

Cc: bhthompson@chromium.org kuscher@chromium.org
Labels: Merge-Request-59
+kuscher@ let me know if you want to merge this to 58.
At this point I would defer to 59 unless there is a strong product request to bring this in to 58. 

Comment 4 by gkihumba@google.com, May 10 2017

Labels: Merge-Approved-59
Project Member

Comment 5 by sheriffbot@chromium.org, May 11 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by bugdroid1@chromium.org, May 11 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7bcca463327ac6a7271475e93887b1da46270baa

commit 7bcca463327ac6a7271475e93887b1da46270baa
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Thu May 11 11:58:55 2017

Don't show rotation change notification in tablet mode unless it's changed by user.

BUG= 720190 
TEST=covered by unit test

Review-Url: https://codereview.chromium.org/2866423002
Cr-Commit-Position: refs/heads/master@{#470482}
(cherry picked from commit 48358e269fbafbae5df07b4a82f0a7762f1ce19b)

Review-Url: https://codereview.chromium.org/2875923002 .
Cr-Commit-Position: refs/branch-heads/3071@{#511}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/7bcca463327ac6a7271475e93887b1da46270baa/ash/system/screen_layout_observer.cc
[modify] https://crrev.com/7bcca463327ac6a7271475e93887b1da46270baa/ash/system/screen_layout_observer_unittest.cc

Comment 7 by osh...@chromium.org, May 11 2017

Status: Fixed (was: Started)

Comment 8 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment