Handle keyboard modifiers when clicking doc links in the PDF Viewer |
|||||
Issue descriptionWhat steps will reproduce the problem? (1) Open http://www.adobe.com/content/dam/Adobe/en/devnet/acrobat/pdfs/pdf_reference_1-7.pdf (2) Go to page 5, the table of contents. (3) Click the links while using keyboard modifiers link ctrl / shift. What is the expected result? The link should open in a new tab / new window, like they do when ctrl / shift clicking a link on a webpage. What happens instead? The keyboard modifiers are ignored. We fixed web links behavior in bug 628057 and bug 630075 . We should consider doing the same for doc links, if possible.
,
May 10 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 10 2018
,
Jun 22 2018
,
Jun 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d0cada97bf36d36fb37fe254ac7de3c388ae03f6 commit d0cada97bf36d36fb37fe254ac7de3c388ae03f6 Author: Henrique Nakashima <hnakashima@chromium.org> Date: Mon Jun 25 18:46:35 2018 Use WindowOpenDispositions to open internal links in PDF Viewer. When clicking on a link in a PDF to another page/position in the same document, open in a new window (if shift was pressed) or a new tab (if ctrl was pressed or if the click was on the middle button). Use PDF open params to do so, specifying page and y position. Bug: 720180 Change-Id: I535b707d592056a020033cbbd00a689f3de8e821 Reviewed-on: https://chromium-review.googlesource.com/1112479 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#570108} [modify] https://crrev.com/d0cada97bf36d36fb37fe254ac7de3c388ae03f6/chrome/browser/pdf/pdf_extension_test.cc [add] https://crrev.com/d0cada97bf36d36fb37fe254ac7de3c388ae03f6/chrome/test/data/pdf/test-internal-link.pdf [modify] https://crrev.com/d0cada97bf36d36fb37fe254ac7de3c388ae03f6/pdf/pdfium/pdfium_engine.cc
,
Jun 25 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by thestig@chromium.org
, May 10 2017