New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 720174 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

PWA splash screen transitions poorly with display: fullscreen

Project Member Reported by dominickn@chromium.org, May 10 2017

Issue description

This can be difficult to catch depending on how fast the device is:

1. Install a PWA with display: fullscreen (e.g. www.progressivewebflap.com)

2. Launch it and observe.

You'll see the splash screen load with the nav and status bars. Then you might see the splash screen icon "jump" slightly right before the splash screen disappears as the nav and status bars animate out and the PWA transitions to immersive fullscreen.

The right thing to do here is possibly enter immersive mode earlier - before initialising the splash screen. I'll investigate.
 
I have a very small CL up that fixes this - https://codereview.chromium.org/2869283002. We just eliminate the delay before entering immersive mode, and enter prior to initialising the splash screen.
Project Member

Comment 2 by bugdroid1@chromium.org, May 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7631c332aae8ba4281325a4955e5a46e8b857f7

commit d7631c332aae8ba4281325a4955e5a46e8b857f7
Author: dominickn <dominickn@chromium.org>
Date: Wed May 10 23:32:54 2017

Remove the initial delay when first entering immersive fullscreen in a PWA.

On first launch, PWAs open a splash screen. If the PWA is set to open in
immersive fullscreen via the manifest property display: fullscreen, the
splash screen currently opens in standalone non-immersive mode before
the PWA transitions to immersive mode. At the point of transition, the
splash screen icon "jumps" as the view resizes.

This CL addresses this problem by transitioning immediately to immersive
fullscreen before loading the splash screen. Now the splash screen opens
directly into immersive fullscreen, removing any resizing.

BUG= 720174 

Review-Url: https://codereview.chromium.org/2869283002
Cr-Commit-Position: refs/heads/master@{#470746}

[modify] https://crrev.com/d7631c332aae8ba4281325a4955e5a46e8b857f7/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java

Status: Fixed (was: Started)

Sign in to add a comment