New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 720173 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

arc: MD Settings - handle ARC events

Project Member Reported by khmel@chromium.org, May 10 2017

Issue description

MD settings has to follow ARC state:

TURN ON button should be available in case ARC is disabled and unmanaged. Once ARC is enabled TURN ON button is hidden and APPS section is shown.

APPS section show link to ARC Settings once Settings app appears in System. While Settings app is not registered link to ARC Settings is hidden.
In case user click on ARC Settings link and Settings app is not ready yet (ARC is still booting) then Settings app is started in deferred mode (spinning animation on shelf).

Disabling ARC hides APPS section and TURN ON button is active again.

Inner bugs: b/37523579, b/29244888
 
Labels: -Proj-MaterialDesign-CrOS Proj-MaterialDesign-WebUI
I assume this is related to WebUI settings (chrome://settings) and not the native system tray, so adjusting labels accordingly.

Comment 2 by khmel@chromium.org, May 10 2017

Thanks for fixing labels. Yes, that is true
Cc: tbuck...@chromium.org bettes@chromium.org
Let me know if you have any questions with the Settings integration, and be sure to loop in tbuckley@ and bettes@ for any UX changes.

Project Member

Comment 4 by bugdroid1@chromium.org, May 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7bb2e7bc7d31c75b0b7f7b384add49df00d69259

commit 7bb2e7bc7d31c75b0b7f7b384add49df00d69259
Author: khmel <khmel@chromium.org>
Date: Fri May 12 03:21:54 2017

arc: Handle ARC events in MD Settings

This provides handling ARC events.
TURN ON button should be available in case ARC is disabled and unmanaged.
Once ARC is enabled TURN ON button is hidden and APPS section is shown.
APPS section shows link to ARC Settings app once Settings app appears in
the system. While Settings app is not registered tehn link to ARC Settings
is hidden. In case user click on ARC Settings link and Settings app is not
ready yet (ARC is still booting) then Settings app is started in deferred
mode (spinning animation on shelf). Disabling ARC hides APPS section and
TURN ON button is active again.

BUG= 720173 , b/37523579, b/29244888
TEST=Browser test extended, manually on device for managed/unmanaged
     cases.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2873853002
Cr-Commit-Position: refs/heads/master@{#471206}

[modify] https://crrev.com/7bb2e7bc7d31c75b0b7f7b384add49df00d69259/chrome/browser/resources/settings/android_apps_page/android_apps_browser_proxy.js
[modify] https://crrev.com/7bb2e7bc7d31c75b0b7f7b384add49df00d69259/chrome/browser/resources/settings/android_apps_page/android_apps_page.html
[modify] https://crrev.com/7bb2e7bc7d31c75b0b7f7b384add49df00d69259/chrome/browser/resources/settings/android_apps_page/android_apps_page.js
[modify] https://crrev.com/7bb2e7bc7d31c75b0b7f7b384add49df00d69259/chrome/browser/resources/settings/android_apps_page/android_apps_subpage.html
[modify] https://crrev.com/7bb2e7bc7d31c75b0b7f7b384add49df00d69259/chrome/browser/resources/settings/android_apps_page/android_apps_subpage.js
[modify] https://crrev.com/7bb2e7bc7d31c75b0b7f7b384add49df00d69259/chrome/browser/ui/webui/settings/chromeos/android_apps_handler.cc
[modify] https://crrev.com/7bb2e7bc7d31c75b0b7f7b384add49df00d69259/chrome/browser/ui/webui/settings/chromeos/android_apps_handler.h
[modify] https://crrev.com/7bb2e7bc7d31c75b0b7f7b384add49df00d69259/chrome/test/data/webui/settings/android_apps_page_test.js

Comment 5 by khmel@chromium.org, May 12 2017

Cc: gkihumba@chromium.org
Labels: Merge-Request-59 ReleaseBlock-Stable
IIUC MD settings is on by default in M59. So this probably release blocker. Requesting to merge to M59.

Comment 6 by gkihumba@google.com, May 12 2017

Labels: Merge-Approved-59
Project Member

Comment 7 by bugdroid1@chromium.org, May 12 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0efcdc84378ac11ad36271be860cccdc40292c08

commit 0efcdc84378ac11ad36271be860cccdc40292c08
Author: khmel <khmel@chromium.org>
Date: Fri May 12 22:12:59 2017

[Merge M59] arg: Handle ARC events in MD Settings

This provides handling ARC events.
TURN ON button should be available in case ARC is disabled and unmanaged.
Once ARC is enabled TURN ON button is hidden and APPS section is shown.
APPS section shows link to ARC Settings app once Settings app appears in
the system. While Settings app is not registered tehn link to ARC Settings
is hidden. In case user click on ARC Settings link and Settings app is not
ready yet (ARC is still booting) then Settings app is started in deferred
mode (spinning animation on shelf). Disabling ARC hides APPS section and
TURN ON button is active again.

BUG= 720173 , b/37523579, b/29244888
TEST=Browser test extended, manually on device for managed/unmanaged
     cases.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
TBR=stevenjb@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2873853002
Cr-Original-Commit-Position: refs/heads/master@{#471206}
Review-Url: https://codereview.chromium.org/2880033002
Cr-Commit-Position: refs/branch-heads/3071@{#540}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/0efcdc84378ac11ad36271be860cccdc40292c08/chrome/browser/resources/settings/android_apps_page/android_apps_browser_proxy.js
[modify] https://crrev.com/0efcdc84378ac11ad36271be860cccdc40292c08/chrome/browser/resources/settings/android_apps_page/android_apps_page.html
[modify] https://crrev.com/0efcdc84378ac11ad36271be860cccdc40292c08/chrome/browser/resources/settings/android_apps_page/android_apps_page.js
[modify] https://crrev.com/0efcdc84378ac11ad36271be860cccdc40292c08/chrome/browser/resources/settings/android_apps_page/android_apps_subpage.html
[modify] https://crrev.com/0efcdc84378ac11ad36271be860cccdc40292c08/chrome/browser/resources/settings/android_apps_page/android_apps_subpage.js
[modify] https://crrev.com/0efcdc84378ac11ad36271be860cccdc40292c08/chrome/browser/ui/webui/settings/chromeos/android_apps_handler.cc
[modify] https://crrev.com/0efcdc84378ac11ad36271be860cccdc40292c08/chrome/browser/ui/webui/settings/chromeos/android_apps_handler.h
[modify] https://crrev.com/0efcdc84378ac11ad36271be860cccdc40292c08/chrome/test/data/webui/settings/android_apps_page_test.js

Comment 8 by khmel@chromium.org, May 12 2017

Status: Fixed (was: Started)
Project Member

Comment 9 by sheriffbot@chromium.org, May 13 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 10 by sheriffbot@chromium.org, May 16 2017

Cc: gkihumba@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 11 by khmel@chromium.org, May 16 2017

Labels: -Merge-Approved-59
Status: Verified (was: Fixed)
9460.48.0, 59.0.3071.67

Sign in to add a comment