New issue
Advanced search Search tips

Issue 720166 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Omnibox UI Experiments: Vary total number of autocomplete matches via about:flags

Project Member Reported by tommycli@chromium.org, May 10 2017

Issue description

Omnibox UI Experiments: Vary total number of autocomplete matches via about:flags

Whole plan here:

https://docs.google.com/a/google.com/document/d/1krPjee88Wj_sIXE1rhTyPMT0-Chi-MdfHwo8sbl5pno/edit?usp=sharing


 
Screenshots of CL here: https://codereview.chromium.org/2873423002/
Screenshot from 2017-05-10 12:15:51.png
159 KB View Download
Screenshot from 2017-05-10 12:15:23.png
88.1 KB View Download
Project Member

Comment 2 by bugdroid1@chromium.org, May 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5a538f9d1c209828582674ff09a11fe12dce47c

commit a5a538f9d1c209828582674ff09a11fe12dce47c
Author: tommycli <tommycli@chromium.org>
Date: Mon May 15 19:09:38 2017

Omnibox UI Experiments: Add flag to change max autocomplete matches.

Adds an about:flag to change the maximum number of autocomplete matches
total across all providers.

BUG= 720166 

Review-Url: https://codereview.chromium.org/2873423002
Cr-Commit-Position: refs/heads/master@{#471855}

[modify] https://crrev.com/a5a538f9d1c209828582674ff09a11fe12dce47c/chrome/browser/about_flags.cc
[modify] https://crrev.com/a5a538f9d1c209828582674ff09a11fe12dce47c/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/a5a538f9d1c209828582674ff09a11fe12dce47c/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/a5a538f9d1c209828582674ff09a11fe12dce47c/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc
[modify] https://crrev.com/a5a538f9d1c209828582674ff09a11fe12dce47c/components/omnibox/browser/autocomplete_result.cc
[modify] https://crrev.com/a5a538f9d1c209828582674ff09a11fe12dce47c/components/omnibox/browser/autocomplete_result.h
[modify] https://crrev.com/a5a538f9d1c209828582674ff09a11fe12dce47c/components/omnibox/browser/omnibox_field_trial.cc
[modify] https://crrev.com/a5a538f9d1c209828582674ff09a11fe12dce47c/components/omnibox/browser/omnibox_field_trial.h
[modify] https://crrev.com/a5a538f9d1c209828582674ff09a11fe12dce47c/components/omnibox/browser/search_provider.cc
[modify] https://crrev.com/a5a538f9d1c209828582674ff09a11fe12dce47c/tools/metrics/histograms/enums.xml

Status: Fixed (was: Untriaged)
Could you add the name of the flag, relevant parameters, or other testing instructions to this bug? Thanks!
Flag at: chrome://flags/#omnibox-ui-max-autocomplete-matches

1. Go to chrome://flags/#omnibox-ui-max-autocomplete-matches
2. Change the select box to the number of matches desired. Disabled, Enabled, or Default all trigger the default behavior.
3. Confirm restarting Chrome.
4. Type something into the omnibox.
5. Observe changed number of max matches.

Comment 6 by woxxom@gmail.com, Sep 30 2017

This is a very useful feature, especially for users with big displays.

I think the ability to customize the number of matches could be and should be exposed in a more natural way, for example, as a button in the suggest dropdown like "Show more". Pressing the button would reveal "Show less" and "Remember". Of course the buttons could be simply icons e.g. + —. Or maybe a number input field with ▲▼ spinners.

Sign in to add a comment