New issue
Advanced search Search tips

Issue 720164 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

New translate UI hangs if network is disconnected

Project Member Reported by napper@google.com, May 9 2017

Issue description

Steps to reproduce the problem:
1. Navigage to a page in a non-UI language with the new Android translate UI enabled
2. Enable aeroplane mode
3. Click translate

What is the expected behavior?
An error is generated indicating that the is no network

What went wrong?
The translate spinner continues indefinitely

Did this work before? N/A 

Chrome version:   Channel: dev
OS Version: 
Flash Version:
 

Comment 1 by napper@chromium.org, May 10 2017

Components: -UI UI>Browser>Language
Labels: -Pri-2 Hotlist-TranslateAndroid Pri-1
Owner: goog...@chromium.org

Comment 2 by napper@chromium.org, May 10 2017

Note that this issue was fixed previously in this CL: https://codereview.chromium.org/2822383002/
Status: Assigned (was: Unconfirmed)
Issue 722545 has been merged into this issue.
Project Member

Comment 5 by bugdroid1@chromium.org, May 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e65dd51e10accc80aa2be79129912f47357cb958

commit e65dd51e10accc80aa2be79129912f47357cb958
Author: googleo <googleo@chromium.org>
Date: Tue May 23 03:21:50 2017

Replace OnPageTranslate Observer by a responder of delegate.

In order to be notified that page is translated, we simply implement CompactInfobar as observer of Translate Driver.
But now we found from the translate button is clicked to the page is translated, there are many steps. If any step is returned, we are not be notified at all.

In order to fix the loose relationship, we create a responder inside the delegate.
So no matter what delegate is going to do, we will be notified, which keep infobar always consistent with delegate.

What's more, on some corner cases listed in bug/723426, the relationship between infobar and translate driver causes crash. And the new strong relationship will fix it.

BUG= 720164 , 703887 ,723426, 724428
TBR=dfalcantara@chromium.org

Review-Url: https://codereview.chromium.org/2894553002
Cr-Commit-Position: refs/heads/master@{#473799}

[modify] https://crrev.com/e65dd51e10accc80aa2be79129912f47357cb958/chrome/browser/ui/android/infobars/translate_compact_infobar.cc
[modify] https://crrev.com/e65dd51e10accc80aa2be79129912f47357cb958/chrome/browser/ui/android/infobars/translate_compact_infobar.h
[modify] https://crrev.com/e65dd51e10accc80aa2be79129912f47357cb958/components/translate/core/browser/translate_infobar_delegate.cc
[modify] https://crrev.com/e65dd51e10accc80aa2be79129912f47357cb958/components/translate/core/browser/translate_infobar_delegate.h

Status: Fixed (was: Assigned)
Should be fixed, Please help me verify it.

Thanks

Sign in to add a comment