New issue
Advanced search Search tips

Issue 720142 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

FFmpeg av_packet_split_side_data() is deprecated

Project Member Reported by jrumm...@chromium.org, May 9 2017

Issue description

With the latest version of FFmpeg, av_packet_split_side_data() is marked as deprecated. However, it is used in the following Chromium code:

media/filters/audio_file_reader_unittest.cc:73
media/filters/ffmpeg_demuxer.cc:411
media/filters/audio_decoder_unittest.cc:254

FFmpeg commit message where it was deprecated: https://patchwork.ffmpeg.org/patch/2948/
 
Hmm, that thread doesn't offer a recommendation on a fix? Do you know how we should resolve this? These types of issues are expected to be resolved during the roll.
Labels: -Pri-3 M-60 Pri-2
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa674817243bee8ab9a8f47677e1d271e1413f32

commit fa674817243bee8ab9a8f47677e1d271e1413f32
Author: Dale Curtis <dalecurtis@chromium.org>
Date: Tue Oct 24 01:51:26 2017

Re-deprecated av_packet_split_side_data()

These calls can be replaced by adding a AVFMT_FLAG_KEEP_SIDE_DATA
flag to the AVFormatContext. I've verified tests fail without this
flag and without the split_side_data() call, but pass with just
the flag (CQ will double check).

https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/e4859f9094f2..f9e8b4275837

$ git log e4859f909..f9e8b4275 --date=short --no-merges --format='%ad %ae %s'
2017-10-23 dalecurtis Revert chromium patch removing deprecation for av_packet_split_side_data()

Created with:
  roll-dep src/third_party/ffmpeg

BUG= 720142 
TEST=media_unitests, CQ.

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I2dfc539baa1d908e9c26a17e8351fbe10c1c58e7
Reviewed-on: https://chromium-review.googlesource.com/734168
Commit-Queue: Chrome Cunningham <chcunningham@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511000}
[modify] https://crrev.com/fa674817243bee8ab9a8f47677e1d271e1413f32/DEPS
[modify] https://crrev.com/fa674817243bee8ab9a8f47677e1d271e1413f32/media/filters/audio_decoder_unittest.cc
[modify] https://crrev.com/fa674817243bee8ab9a8f47677e1d271e1413f32/media/filters/audio_file_reader_unittest.cc
[modify] https://crrev.com/fa674817243bee8ab9a8f47677e1d271e1413f32/media/filters/ffmpeg_demuxer.cc
[modify] https://crrev.com/fa674817243bee8ab9a8f47677e1d271e1413f32/media/filters/ffmpeg_glue.cc

Status: Fixed (was: Available)

Sign in to add a comment