New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 720114 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Chrome "Context lost because SwapBuffers failed" should be an error

Project Member Reported by jamescook@chromium.org, May 9 2017

Issue description

Right now ToT Chrome in a VM shows a black screen (issue 719983). However, VMTests are passing and bots are green.

Green build:
https://uberchromegw.corp.google.com/i/chromeos.chrome/builders/lumpy-tot-chrome-pfq-informational/builds/22431

The logs are full of:
[17614:17614:0509/145649.712475:ERROR:gles2_cmd_decoder.cc(15622)] Context lost because SwapBuffers failed.
[17614:17614:0509/145649.712507:ERROR:gles2_cmd_decoder.cc(5326)] Error: 5 for Command kPostSubBufferCHROMIUM
[17614:17614:0509/145649.731075:ERROR:gles2_cmd_decoder.cc(4287)]   GLES2DecoderImpl: Trying to make lost context current.
[17614:17614:0509/145649.768916:ERROR:gles2_cmd_decoder.cc(15622)] Context lost because SwapBuffers failed.
[17614:17614:0509/145649.768949:ERROR:gles2_cmd_decoder.cc(5326)] Error: 5 for Command kPostSubBufferCHROMIUM
[17614:17614:0509/145649.791133:ERROR:gles2_cmd_decoder.cc(4287)]   GLES2DecoderImpl: Trying to make lost context current.
[17614:17614:0509/145649.938236:ERROR:gles2_cmd_decoder.cc(15622)] Context lost because SwapBuffers failed.
[17614:17614:0509/145649.938294:ERROR:gles2_cmd_decoder.cc(5326)] Error: 5 for Command kPostSubBufferCHROMIUM
[17614:17614:0509/145649.938392:ERROR:gles2_cmd_decoder.cc(4287)]   GLES2DecoderImpl: Trying to make lost context current.
[17614:17614:0509/145649.938448:ERROR:gles2_cmd_decoder.cc(4287)]   GLES2DecoderImpl: Trying to make lost context current.
[17614:17614:0509/145649.938534:ERROR:gles2_cmd_decoder.cc(4287)]   GLES2DecoderImpl: Trying to make lost context current.

https://00e9e64bac22132978cf05d1fdb9e960228402e9d8fdd48033-apidata.googleusercontent.com/download/storage/v1/b/chromeos-image-archive/o/lumpy-tot-chrome-pfq-informational%2FR60-9535.0.0-b22431%2Fvm_test_results_1%2Fsmoke_suite%2Ftest_harness%2Fall%2FSimpleTestVerify%2F1_autotest_tests%2Fresults-20-login_Cryptohome%2Flogin_Cryptohome%2Fsysinfo%2Fvar%2Flog_diff%2Fui%2Fui.20170509-145648?qk=AD5uMEuGMQpoebvv0Hu3iRtwKKtSLADTsZh0if40MihXL8HdAErgwsx1vhyL1x489MonpA1xycuAD8bC-xGdh69OMej3h0oq7q9ac7283IF2vn3Jgp25XSUXskkMBVfDO9ABwsfTjwIcWjQ01k2d1-cJe5JxoVPLperpzfiF13t9G5nyuS3aMv1aefJrZbwVeliQDfM9JJ7Mv2NNtddwYecrkoU_ttBe2taGw1V3Fs8tghahiWpS0VNQH7MhNupTBi8jKatR0p-FLEBSFX4MmHmMErpiiMMA1jZeCqOYlagzwny2E1IrJxGrzPFah7ymBaDZIDftbiEKbDZkCcZDLhUATCwdklXFe5IlX10Mysgu-rxlEpS-64rKABj-zuCZBOEA0SjmJheH5fuaKUvd7hnnZtj-vXu3_RKCeXku1M2tNIBVXd8otAStKxRUl_LZGx-SeOt8QolvZ3B2jcdmdcvFNq0YYXotUARqpHfIpq7xx1vgVLmOFk_a0TMlY7WbNe8m3d-JVlNOf8kJ4eJMtwrRv9pdZ0i_wySnrE12pysVxz3yk1YETYsUY7VyxK4Oo6vkxI0JMZLca-S0simewJP9kdcP7mcF6a_tjmAZwilVPZ58Wc0dFbjnwGfqTauucouprLjJ3J_rTkHqwc9EimazP0IaB5MQGrnNfm4x3qM_zSrTTFqNxshAjg9yQB4-DMU8mqOZGCggQlZyeGDKz67PO9iSBPqoDOy062m7H9Yg2vSJvJFnac9mG6guRN9W63QEaKPXE9PniLU-lufelhYF4nr4Vc4BK_rqPvCV7Fpj9kuqlOWKo7l_9DpKvmgNDWBjv0vcaTkCANIJ4qato0M0D8vrLfw5wdd1mJqxKzSRj2BY2M1WeKDHyAhVLe29Pl1XNRO5_ARXy72c0xQkAshpaB7U2pTU0qOoWQ6_P1SgcIE2-ynO2M61mFK6R01_0KMOvL_VmYw4Pds__jXD9CQt8Ml1orc6w8FReQ8oQWcEly28qQhZcJq_2NEf2Q55NrSsBUvGeiEqjReRV_YPIIFChSrFy0gpVoNzwypHzq0PZ9Up74zhxXyNo5s-acNIxuI03M0rgCnn8YvszJOg-xo6S7khsWMpkQ

Per chat with marcheu@, "we should make those chrome errors fatal. "Context lost because SwapBuffers failed." is never a good thing"

Can you make one of those things into an error, or find someone to do it?

 
Cc: achuith@chromium.org
This is P1 since May, can you please have a look dscastagna?
Status: Started (was: Assigned)
Some discussion is going on in crrev.com/c/753932 about this.
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03f0b85da3ca997decd06331c700282d2639663a

commit 03f0b85da3ca997decd06331c700282d2639663a
Author: Daniele Castagna <dcastagna@chromium.org>
Date: Tue Nov 07 04:19:49 2017

ozone/drm: Make SchedulePageFlip failures fatal.

Failures to schedule a page flip have gone unnoticed in the past.
ozone would report SWAP_FAIL, and gles2 cmd decoder tried to
recover from that state.

This patch adds a CHECK on ozone drm platform to verify that pageflips
always succeed.
A GPU crash will be reported when pageflipping fails.

Bug:  720114 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I039e72bfc2dfeb16a3902a8ac80556ed75c9fb08
Reviewed-on: https://chromium-review.googlesource.com/753932
Commit-Queue: David Reveman <reveman@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Michael Spang <spang@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514386}
[modify] https://crrev.com/03f0b85da3ca997decd06331c700282d2639663a/ui/ozone/platform/drm/gpu/drm_thread.cc
[modify] https://crrev.com/03f0b85da3ca997decd06331c700282d2639663a/ui/ozone/platform/drm/gpu/drm_window.cc
[modify] https://crrev.com/03f0b85da3ca997decd06331c700282d2639663a/ui/ozone/platform/drm/gpu/drm_window.h
[modify] https://crrev.com/03f0b85da3ca997decd06331c700282d2639663a/ui/ozone/platform/drm/gpu/hardware_display_controller.cc
[modify] https://crrev.com/03f0b85da3ca997decd06331c700282d2639663a/ui/ozone/platform/drm/gpu/hardware_display_controller.h

Status: Fixed (was: Started)

Comment 6 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 7 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment