New issue
Advanced search Search tips

Issue 720109 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

MD Settings: Wrong message when disabling proxy settings

Project Member Reported by sdantul...@chromium.org, May 9 2017

Issue description

Google Chrome	60.0.3092.0 (Official Build) dev (32-bit)
Revision	0
Platform	9534.0.0 (Official Build) dev-channel elm

What steps will reproduce the problem?
1. Open Network settings -> click on a network -> Open proxy section
2. Enable Allow proxies for shared networks.
3. Now disable the setting. Check the message in dialog box

What happens?
The message still reads "Confirm change to allow proxies for shared networks"

Attached screenshot.
 
Screenshot 2017-05-09 at 14.23.09.png
140 KB View Download
Cc: bettes@chromium.org tbuck...@chromium.org
Owner: steve...@chromium.org
Status: Assigned (was: Untriaged)
This is WAI. The user is changing the "allow proxies for shared networks" setting.

Maybe we can clarify this a bit? Tom, Alan, suggestions?

(We show this dialog whenever the user changes the "allow proxies for shared networks" toggle, either to true or to false. The toggle is a security measure, it defaults to false since using a proxy from a shared network allows other users of the device to change that proxy).

Ah, that makes sense. Having "allow" when disabling the setting is a bit confusing.

How about "Confirm change to proxies for shared networks"?
The problem with that message is that it implies that the user is changing the proxies for shared networks, but we they are not, they are only changing the toggle that *allows* proxies for shared networks.

The problem with that message is that it implies that the user is changing the proxies for shared networks, but we they are not, they are only changing the toggle that *allows* proxies for shared networks.

Ah, got it. Could we have it depend on the setting value?

Toggling on: "Allow proxies for shared networks"
Toggling off: "Disallow proxies for shared networks"
So, specifically:

Confirm change to allow proxies for shared networks

or

Confirm change to disallow proxies for shared networks

?

That seems OK to me.

Labels: -Pri-2 Pri-3
Labels: -M-60 M-61
Labels: M-62
Labels: -M-61
Labels: Hotlist-MD-Settings-Internet-Config
Labels: -M-62 M-63
Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
10032.21.0, 63.0.3239.26

Sign in to add a comment