MD Settings: Wrong message when disabling proxy settings |
|||||||||
Issue descriptionGoogle Chrome 60.0.3092.0 (Official Build) dev (32-bit) Revision 0 Platform 9534.0.0 (Official Build) dev-channel elm What steps will reproduce the problem? 1. Open Network settings -> click on a network -> Open proxy section 2. Enable Allow proxies for shared networks. 3. Now disable the setting. Check the message in dialog box What happens? The message still reads "Confirm change to allow proxies for shared networks" Attached screenshot.
,
May 10 2017
Ah, that makes sense. Having "allow" when disabling the setting is a bit confusing. How about "Confirm change to proxies for shared networks"?
,
May 10 2017
The problem with that message is that it implies that the user is changing the proxies for shared networks, but we they are not, they are only changing the toggle that *allows* proxies for shared networks.
,
May 10 2017
The problem with that message is that it implies that the user is changing the proxies for shared networks, but we they are not, they are only changing the toggle that *allows* proxies for shared networks.
,
May 15 2017
Ah, got it. Could we have it depend on the setting value? Toggling on: "Allow proxies for shared networks" Toggling off: "Disallow proxies for shared networks"
,
May 15 2017
So, specifically: Confirm change to allow proxies for shared networks or Confirm change to disallow proxies for shared networks ? That seems OK to me.
,
May 17 2017
,
May 25 2017
,
Jun 26 2017
,
Jun 26 2017
,
Jul 24 2017
,
Sep 19 2017
,
Oct 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0cc1b49f5ed22850a601e37e4b300f4a2768c2d3 commit 0cc1b49f5ed22850a601e37e4b300f4a2768c2d3 Author: Steven Bennetts <stevenjb@chromium.org> Date: Tue Oct 10 17:55:04 2017 CrOS Settings: Network: Update 'allow shared proxies' dialog title Bug: 720109 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I47d27ff98a89682dd979e69fc3e52fd381488585 Reviewed-on: https://chromium-review.googlesource.com/703987 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#507711} [modify] https://crrev.com/0cc1b49f5ed22850a601e37e4b300f4a2768c2d3/chrome/app/settings_strings.grdp [modify] https://crrev.com/0cc1b49f5ed22850a601e37e4b300f4a2768c2d3/chrome/browser/resources/settings/internet_page/network_proxy_section.html [modify] https://crrev.com/0cc1b49f5ed22850a601e37e4b300f4a2768c2d3/chrome/browser/resources/settings/internet_page/network_proxy_section.js [modify] https://crrev.com/0cc1b49f5ed22850a601e37e4b300f4a2768c2d3/chrome/browser/ui/webui/chromeos/network_element_localized_strings_provider.cc
,
Oct 13 2017
,
Nov 8 2017
10032.21.0, 63.0.3239.26 |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by steve...@chromium.org
, May 9 2017Owner: steve...@chromium.org
Status: Assigned (was: Untriaged)