Pass in the NQE threshold for LoFi/WebLite instead of checking it in a helper |
|||||
Issue descriptionDataReductionProxyConfig::ShouldEnableLoFiInternal should determine the correct Effective Connection Type threshold based on flags/field trial and pass it to the PreviewsDecider instead of checking itself. This could be moved outside of DRP code (into ChromeResourceDispatcherHost) potentially.
,
May 9 2017
I think we want to refactor how that method looks in general, but we are waiting on CPAT, maybe.
,
May 10 2017
I agree. We probably won't want to do the work of passing in the actual ECT and having PreviewsDecider::ShouldAllowPreviewAtECT decide the ECT because of CPAT. We could move the blacklist logic to a PreviewsDecider::IsPreviewBlacklisted method that is available for DRPConfig to check and that ShouldAllowPreviewAtECT also calls.
,
May 19 2017
+1 for a new PreviewsDecider::IsPreviewBlacklisted() method that does not check ECT at all.
,
May 19 2017
previews_io_data()->previews_black_list()->IsLoadedAndAllowed() == PreviewsEligibilityReason::ALLOWED should do that right now I believe. If anyone needs that as part of PreviewsDecider, feel free to wrap and io method around it.
,
Nov 29 2017
Refreshed during triage.
,
Nov 29 2017
This feels like a clean-up bug that should be addressed when it is needed I'm closing as WontFix because of that.
,
Dec 5 2017
,
Dec 5 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bengr@chromium.org
, May 9 2017