New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 720093 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Mac
Pri: 1
Type: Bug



Sign in to add a comment

CPU throttling rate is lower than it was set to

Project Member Reported by alph@chromium.org, May 9 2017

Issue description

The actual CPU throttling rate tends to be lower than the requested one. E.g. on a Linux box if the slowdown rate is set to 10x, the actual slowdown is around 4x.
 
Cc: chenwilliam@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, May 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df33f5f39300a46b43eefb4f8940fac99b37b491

commit df33f5f39300a46b43eefb4f8940fac99b37b491
Author: alph <alph@chromium.org>
Date: Thu May 11 03:14:08 2017

DevTools: More precise CPU throttling rate on Linux

There seems to be some delay during POSIX signal propagation
to the target thread.
Move the run/sleep logic to the signal handler and make it adaptive.

BUG= 720093 

Review-Url: https://codereview.chromium.org/2880493002
Cr-Commit-Position: refs/heads/master@{#470790}

[modify] https://crrev.com/df33f5f39300a46b43eefb4f8940fac99b37b491/content/renderer/devtools/devtools_cpu_throttler.cc

Comment 3 by alph@chromium.org, May 13 2017

Labels: -OS-All Merge-Request-59 OS-Linux OS-Mac
Project Member

Comment 4 by sheriffbot@chromium.org, May 13 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by gov...@chromium.org, May 15 2017

Please merge your change to M59 branch 3071 by 4:00 PM PT, Monday (05/15) so we can take it in for next week beta release. Thank you.
Project Member

Comment 6 by bugdroid1@chromium.org, May 15 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/601d38ead4cf9e6e4f28be94a938ea930b61aa62

commit 601d38ead4cf9e6e4f28be94a938ea930b61aa62
Author: Alexei Filippov <alph@chromium.org>
Date: Mon May 15 17:26:09 2017

DevTools: More precise CPU throttling rate on Linux

There seems to be some delay during POSIX signal propagation
to the target thread.
Move the run/sleep logic to the signal handler and make it adaptive.

BUG= 720093 

Review-Url: https://codereview.chromium.org/2880493002
Cr-Original-Commit-Position: refs/heads/master@{#470790}
Review-Url: https://codereview.chromium.org/2879313002 .
Cr-Commit-Position: refs/branch-heads/3071@{#556}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/601d38ead4cf9e6e4f28be94a938ea930b61aa62/content/renderer/devtools/devtools_cpu_throttler.cc

Comment 7 by alph@chromium.org, May 15 2017

Status: Fixed (was: Started)
It looks like the current Linux dev release hasn't picked up the fix yet (last release was on 05/11/17 - just before the fix).  Looks like they are cut close to weekly so I should be able to test it in the official build towards the end of the week.

In the meantime I'll see if there is an interim build I can download or just build from source and see (don't usually use my Linux environment for Chrome work so may take a bit)
Status: Verified (was: Fixed)
Tested on 60.0.3100.0 and it's working great.  Thanks for the fix.

Sign in to add a comment