New issue
Advanced search Search tips

Issue 720092 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature

Blocking:
issue 683283



Sign in to add a comment

Implement CRX₃ Parser / Generator

Project Member Reported by waff...@chromium.org, May 9 2017

Issue description

To migrate to CRX₃ we need to be able to verify and create CRX₃ files.

This is a tracking bug for CRX₃ support in Chrome.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5918d5fbdda9a61e2b83735975fcd7ebbf4d4645

commit 5918d5fbdda9a61e2b83735975fcd7ebbf4d4645
Author: waffles <waffles@chromium.org>
Date: Tue May 23 01:45:46 2017

Refactor CRX verification in preparation to support CRX₃ files.

Clarified that the crx_file.* refers to CRX₂, moved verification out of the CRX₂ code to allow callers to specify CRX₃-permissive policies.

Also fixed a potential crash in extension_creator.cc.

BUG= 720092 

Review-Url: https://codereview.chromium.org/2874503002
Cr-Commit-Position: refs/heads/master@{#473780}

[modify] https://crrev.com/5918d5fbdda9a61e2b83735975fcd7ebbf4d4645/chrome/browser/extensions/extension_creator.cc
[modify] https://crrev.com/5918d5fbdda9a61e2b83735975fcd7ebbf4d4645/components/crx_file/BUILD.gn
[add] https://crrev.com/5918d5fbdda9a61e2b83735975fcd7ebbf4d4645/components/crx_file/crx2_file.cc
[add] https://crrev.com/5918d5fbdda9a61e2b83735975fcd7ebbf4d4645/components/crx_file/crx2_file.h
[delete] https://crrev.com/2cbad67882de4eae81e58c0aed19419f2af31803/components/crx_file/crx_file.cc
[delete] https://crrev.com/2cbad67882de4eae81e58c0aed19419f2af31803/components/crx_file/crx_file.h
[add] https://crrev.com/5918d5fbdda9a61e2b83735975fcd7ebbf4d4645/components/crx_file/crx_verifier.cc
[add] https://crrev.com/5918d5fbdda9a61e2b83735975fcd7ebbf4d4645/components/crx_file/crx_verifier.h
[modify] https://crrev.com/5918d5fbdda9a61e2b83735975fcd7ebbf4d4645/components/update_client/component_unpacker.cc
[modify] https://crrev.com/5918d5fbdda9a61e2b83735975fcd7ebbf4d4645/components/update_client/component_unpacker_unittest.cc
[modify] https://crrev.com/5918d5fbdda9a61e2b83735975fcd7ebbf4d4645/components/update_client/update_client_errors.h
[modify] https://crrev.com/5918d5fbdda9a61e2b83735975fcd7ebbf4d4645/extensions/browser/sandboxed_unpacker.cc
[modify] https://crrev.com/5918d5fbdda9a61e2b83735975fcd7ebbf4d4645/extensions/browser/sandboxed_unpacker.h
[modify] https://crrev.com/5918d5fbdda9a61e2b83735975fcd7ebbf4d4645/extensions/browser/sandboxed_unpacker_unittest.cc
[modify] https://crrev.com/5918d5fbdda9a61e2b83735975fcd7ebbf4d4645/tools/metrics/histograms/enums.xml

Project Member

Comment 3 by bugdroid1@chromium.org, May 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4d300354ae819ac782c1938dab436fc66be4c87

commit d4d300354ae819ac782c1938dab436fc66be4c87
Author: waffles <waffles@chromium.org>
Date: Thu May 25 02:12:27 2017

Announce to Omaha that Chrome accepts CRX₂ and CRX₃ files.

Also include the "dedup" parameter according to the protocol spec.

BUG= 720092 

Review-Url: https://codereview.chromium.org/2898243004
Cr-Commit-Position: refs/heads/master@{#474525}

[modify] https://crrev.com/d4d300354ae819ac782c1938dab436fc66be4c87/components/update_client/protocol_builder.cc
[modify] https://crrev.com/d4d300354ae819ac782c1938dab436fc66be4c87/components/update_client/update_query_params.cc

Blocking: 683283
Parsing / accepting the files is done; remaining work is to generate them.
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b8bc9f99ef4ad6223dfdcafd924051561c05ac75

commit b8bc9f99ef4ad6223dfdcafd924051561c05ac75
Author: Joshua Pawlicki <waffles@google.com>
Date: Mon Oct 16 17:23:52 2017

Convert CRX creator to create CRX3 items.

Bug:  720092 
Change-Id: Ia2d43313e5282c55ef587165cf702ec234f8e771
Reviewed-on: https://chromium-review.googlesource.com/702814
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509085}
[modify] https://crrev.com/b8bc9f99ef4ad6223dfdcafd924051561c05ac75/chrome/browser/extensions/BUILD.gn
[modify] https://crrev.com/b8bc9f99ef4ad6223dfdcafd924051561c05ac75/chrome/browser/extensions/extension_creator.cc
[modify] https://crrev.com/b8bc9f99ef4ad6223dfdcafd924051561c05ac75/chrome/browser/extensions/extension_creator.h
[modify] https://crrev.com/b8bc9f99ef4ad6223dfdcafd924051561c05ac75/components/crx_file/BUILD.gn
[delete] https://crrev.com/442d52883540e4f69c4f3d40ab9ac2a9c04cdeab/components/crx_file/crx2_file.cc
[delete] https://crrev.com/442d52883540e4f69c4f3d40ab9ac2a9c04cdeab/components/crx_file/crx2_file.h
[add] https://crrev.com/b8bc9f99ef4ad6223dfdcafd924051561c05ac75/components/crx_file/crx_creator.cc
[add] https://crrev.com/b8bc9f99ef4ad6223dfdcafd924051561c05ac75/components/crx_file/crx_creator.h
[add] https://crrev.com/b8bc9f99ef4ad6223dfdcafd924051561c05ac75/components/crx_file/crx_creator_unittest.cc
[add] https://crrev.com/b8bc9f99ef4ad6223dfdcafd924051561c05ac75/components/crx_file/crx_file.h
[modify] https://crrev.com/b8bc9f99ef4ad6223dfdcafd924051561c05ac75/components/crx_file/crx_verifier.cc
[add] https://crrev.com/b8bc9f99ef4ad6223dfdcafd924051561c05ac75/components/test/data/crx_file/sample.zip

Status: Fixed (was: Started)

Sign in to add a comment