New issue
Advanced search Search tips

Issue 720079 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

SoM: "Link/File bug" should trim whitespace on bug number

Project Member Reported by jamescook@chromium.org, May 9 2017

Issue description

Problem with Sheriff-o-Matic

* Click "Link/File bug"
* Enter " 702930 " (with spaces, because you copy/pasted it from somewhere)

"Invalid bug ' 702930 '"

It ought to trim the number / URL before trying to commit it.

 
Labels: Milestone-UX
Owner: zhangtiff@chromium.org
Status: Assigned (was: Untriaged)
Thanks! This should be an easy fix. 
Project Member

Comment 2 by bugdroid1@chromium.org, May 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/73378655c4cabf47f7427e29e87b473a85479aeb

commit 73378655c4cabf47f7427e29e87b473a85479aeb
Author: Tiff Zhang <zhangtiff@google.com>
Date: Mon May 15 21:24:28 2017

SoM: Trim spaces on linked bug.

Bug:720079

Change-Id: I5eb42284505c502828628f15abf00feecf3eb286
Reviewed-on: https://chromium-review.googlesource.com/506568
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Tiffany Zhang <zhangtiff@chromium.org>

[modify] https://crrev.com/73378655c4cabf47f7427e29e87b473a85479aeb/go/src/infra/appengine/sheriff-o-matic/elements/som-annotations/som-annotations.js

Status: Fixed (was: Assigned)
This will be out with the next deployment this Tuesday. Thanks! :D 

Sign in to add a comment