New issue
Advanced search Search tips

Issue 720058 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Add Dedicated and Shared Thread Modes for Creating SingleThreadTaskRunners

Project Member Reported by robliao@chromium.org, May 9 2017

Issue description

Many callers can make do with a shared thread. Only a few need dedicated threads.

 
Project Member

Comment 3 by bugdroid1@chromium.org, May 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/767ec996d88c8f8719a4648b891b5e10501a7a99

commit 767ec996d88c8f8719a4648b891b5e10501a7a99
Author: robliao <robliao@chromium.org>
Date: Tue May 23 21:36:23 2017

Refactor Environment Config Out of TaskSchedulerImpl

The upcoming shared SingleThreadTaskRunner work will need access to the
same environment config as TaskSchedulerImpl.

BUG= 720058 

Review-Url: https://codereview.chromium.org/2904593002
Cr-Commit-Position: refs/heads/master@{#474066}

[modify] https://crrev.com/767ec996d88c8f8719a4648b891b5e10501a7a99/base/BUILD.gn
[add] https://crrev.com/767ec996d88c8f8719a4648b891b5e10501a7a99/base/task_scheduler/environment_config.cc
[add] https://crrev.com/767ec996d88c8f8719a4648b891b5e10501a7a99/base/task_scheduler/environment_config.h
[modify] https://crrev.com/767ec996d88c8f8719a4648b891b5e10501a7a99/base/task_scheduler/task_scheduler_impl.cc

Project Member

Comment 4 by bugdroid1@chromium.org, May 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b29b8d8833bf2f8fa7c1a33a90cf7d96a44d79ef

commit b29b8d8833bf2f8fa7c1a33a90cf7d96a44d79ef
Author: robliao <robliao@chromium.org>
Date: Thu May 25 14:59:46 2017

Use Dedicated Threads for BrowserThreads Backed by SingleThreadTaskRunners

BUG= 720058 

Review-Url: https://codereview.chromium.org/2906573002
Cr-Commit-Position: refs/heads/master@{#474652}

[modify] https://crrev.com/b29b8d8833bf2f8fa7c1a33a90cf7d96a44d79ef/content/browser/browser_main_loop.cc

Project Member

Comment 5 by bugdroid1@chromium.org, May 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e96185d01c286ffb9892e3f7dff6765bea1dc81b

commit e96185d01c286ffb9892e3f7dff6765bea1dc81b
Author: robliao <robliao@chromium.org>
Date: Thu May 25 21:33:43 2017

Implement Shared SingleThreadTaskRunners in the Task Scheduler

This change provides one shared SingleThreadTaskRunner per Trait+COM
combination by reusing dedicated SingleThreadTaskRunners.

In production, these SingleThreadTaskRunners will never be reclaimed.
In tests, JoinForTesting() cleans these up.

BUG= 720058 

Review-Url: https://codereview.chromium.org/2902753003
Cr-Commit-Position: refs/heads/master@{#474813}

[modify] https://crrev.com/e96185d01c286ffb9892e3f7dff6765bea1dc81b/base/task_scheduler/environment_config.h
[modify] https://crrev.com/e96185d01c286ffb9892e3f7dff6765bea1dc81b/base/task_scheduler/scheduler_single_thread_task_runner_manager.cc
[modify] https://crrev.com/e96185d01c286ffb9892e3f7dff6765bea1dc81b/base/task_scheduler/scheduler_single_thread_task_runner_manager.h
[modify] https://crrev.com/e96185d01c286ffb9892e3f7dff6765bea1dc81b/base/task_scheduler/scheduler_single_thread_task_runner_manager_unittest.cc
[modify] https://crrev.com/e96185d01c286ffb9892e3f7dff6765bea1dc81b/base/task_scheduler/task_scheduler_impl.cc

Status: Fixed (was: Started)

Sign in to add a comment