New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 720043 link

Starred by 1 user
Status: Fixed
Owner:
█ ti...@chromium.org
Email to this user bounced
Closed: May 2017
Cc:
boliu@chromium.org
█ sgu...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Register JNI part of ContextSelectionProvider

Reported by ti...@chromium.org, May 9 2017 
The JNI registration of ContextSelectionProvider seems to be missing in
browser_jni_registrar.cc
https://cs.chromium.org/chromium/src/content/browser/android/browser_jni_registrar.cc?rcl=b6c7ed30b72bf250cc2f9d7954e0f44a5a9bcaf3&l=39

This bug is created for the merge into a release branch.
Project Member

Comment 1 by bugdroid1@chromium.org, May 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a49d64dd06d785995c20b36eb2d7cf7f6a5bef61

commit a49d64dd06d785995c20b36eb2d7cf7f6a5bef61
Author: timav <timav@chromium.org>
Date: Tue May 09 19:49:53 2017

Fix ContextSelectionClient JNI registration

Should have been be part of http://crrev.com/2740103006/

BUG=685420,  720043 

Review-Url: https://codereview.chromium.org/2869113002
Cr-Commit-Position: refs/heads/master@{#470411}

[modify] https://crrev.com/a49d64dd06d785995c20b36eb2d7cf7f6a5bef61/content/browser/android/browser_jni_registrar.cc

Comment 2 by ti...@chromium.org, May 9 2017

Labels: Merge-Request-59 M-59
Project Member

Comment 3 by sheriffbot@chromium.org, May 9 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, May 9 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb5c27bd64a0aa59266dabe193d1675838cb72a8

commit bb5c27bd64a0aa59266dabe193d1675838cb72a8
Author: Tima Vaisburd <timav@chromium.org>
Date: Tue May 09 21:30:15 2017

Fix ContextSelectionClient JNI registration

Should have been be part of http://crrev.com/2740103006/

BUG=685420,  720043 

Review-Url: https://codereview.chromium.org/2869113002
Cr-Commit-Position: refs/heads/master@{#470411}
(cherry picked from commit a49d64dd06d785995c20b36eb2d7cf7f6a5bef61)

Review-Url: https://codereview.chromium.org/2867303005 .
Cr-Commit-Position: refs/branch-heads/3071@{#488}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/bb5c27bd64a0aa59266dabe193d1675838cb72a8/content/browser/android/browser_jni_registrar.cc

Comment 5 by ti...@chromium.org, May 9 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment