New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 720040 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 661608



Sign in to add a comment

Remove setManifest and getManifest related codes for service worker based payment app

Project Member Reported by gogerald@chromium.org, May 9 2017

Issue description

setManifest and getManifest have been removed from the new spec, so we should remove related codes.

 
I uploaded two CLs for this.
 - https://codereview.chromium.org/2873903003/
 - https://codereview.chromium.org/2875493003/

I'll request reviews when GetAllPaymentApps() implementation is resolved.

Thanks.
Project Member

Comment 2 by bugdroid1@chromium.org, May 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9ade04245b96eb7ca8be76b2224711f4a832e82d

commit 9ade04245b96eb7ca8be76b2224711f4a832e82d
Author: jinho.bang <jinho.bang@samsung.com>
Date: Mon May 15 19:41:31 2017

PaymentHandler: Stop using GetAllManifests() in content side tests.

The GetAllManifests() was already deprecated. Instead we should use new
GetAllPaymentApps().

BUG= 661608 , 720040 

Review-Url: https://codereview.chromium.org/2873903003
Cr-Commit-Position: refs/heads/master@{#471870}

[modify] https://crrev.com/9ade04245b96eb7ca8be76b2224711f4a832e82d/content/browser/payments/payment_app_browsertest.cc
[modify] https://crrev.com/9ade04245b96eb7ca8be76b2224711f4a832e82d/content/browser/payments/payment_app_provider_impl_unittest.cc
[modify] https://crrev.com/9ade04245b96eb7ca8be76b2224711f4a832e82d/content/test/data/payments/payment_app_invocation.html

Project Member

Comment 3 by bugdroid1@chromium.org, May 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6403f30a37f9ac07a05c4591ad8aabe202c96f05

commit 6403f30a37f9ac07a05c4591ad8aabe202c96f05
Author: jinho.bang <jinho.bang@samsung.com>
Date: Wed May 17 11:36:43 2017

PaymentHandler: Remove PaymentAppManifest and PaymentAppOption.

They were already removed from the spec. Therefore, we should remove the related
implementation. (including get/setManifest() methods in payment manager.)

Spec:
  https://w3c.github.io/payment-handler/#paymentmanager-interface

BUG= 661608 ,  720040 

Review-Url: https://codereview.chromium.org/2875493003
Cr-Commit-Position: refs/heads/master@{#472423}

[modify] https://crrev.com/6403f30a37f9ac07a05c4591ad8aabe202c96f05/components/payments/mojom/payment_app.mojom
[modify] https://crrev.com/6403f30a37f9ac07a05c4591ad8aabe202c96f05/content/browser/payments/payment_app.proto
[modify] https://crrev.com/6403f30a37f9ac07a05c4591ad8aabe202c96f05/content/browser/payments/payment_app_content_unittest_base.cc
[modify] https://crrev.com/6403f30a37f9ac07a05c4591ad8aabe202c96f05/content/browser/payments/payment_app_content_unittest_base.h
[modify] https://crrev.com/6403f30a37f9ac07a05c4591ad8aabe202c96f05/content/browser/payments/payment_app_context_impl.h
[modify] https://crrev.com/6403f30a37f9ac07a05c4591ad8aabe202c96f05/content/browser/payments/payment_app_database.cc
[modify] https://crrev.com/6403f30a37f9ac07a05c4591ad8aabe202c96f05/content/browser/payments/payment_app_database.h
[modify] https://crrev.com/6403f30a37f9ac07a05c4591ad8aabe202c96f05/content/browser/payments/payment_app_provider_impl.cc
[modify] https://crrev.com/6403f30a37f9ac07a05c4591ad8aabe202c96f05/content/browser/payments/payment_app_provider_impl.h
[modify] https://crrev.com/6403f30a37f9ac07a05c4591ad8aabe202c96f05/content/browser/payments/payment_app_provider_impl_unittest.cc
[modify] https://crrev.com/6403f30a37f9ac07a05c4591ad8aabe202c96f05/content/browser/payments/payment_manager.cc
[modify] https://crrev.com/6403f30a37f9ac07a05c4591ad8aabe202c96f05/content/browser/payments/payment_manager.h
[modify] https://crrev.com/6403f30a37f9ac07a05c4591ad8aabe202c96f05/content/browser/payments/payment_manager_unittest.cc
[modify] https://crrev.com/6403f30a37f9ac07a05c4591ad8aabe202c96f05/content/public/browser/payment_app_provider.h
[modify] https://crrev.com/6403f30a37f9ac07a05c4591ad8aabe202c96f05/third_party/WebKit/LayoutTests/http/tests/payments/payment-app-interfaces.html
[delete] https://crrev.com/ec987e5daec026525a096c0c4a6fbb32e87eddd6/third_party/WebKit/LayoutTests/http/tests/payments/payment-manager.html
[modify] https://crrev.com/6403f30a37f9ac07a05c4591ad8aabe202c96f05/third_party/WebKit/LayoutTests/http/tests/payments/resources/payment-app.js
[modify] https://crrev.com/6403f30a37f9ac07a05c4591ad8aabe202c96f05/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/6403f30a37f9ac07a05c4591ad8aabe202c96f05/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/6403f30a37f9ac07a05c4591ad8aabe202c96f05/third_party/WebKit/Source/modules/modules_idl_files.gni
[delete] https://crrev.com/ec987e5daec026525a096c0c4a6fbb32e87eddd6/third_party/WebKit/Source/modules/payments/PaymentAppManifest.idl
[delete] https://crrev.com/ec987e5daec026525a096c0c4a6fbb32e87eddd6/third_party/WebKit/Source/modules/payments/PaymentAppOption.idl
[modify] https://crrev.com/6403f30a37f9ac07a05c4591ad8aabe202c96f05/third_party/WebKit/Source/modules/payments/PaymentManager.cpp
[modify] https://crrev.com/6403f30a37f9ac07a05c4591ad8aabe202c96f05/third_party/WebKit/Source/modules/payments/PaymentManager.h
[modify] https://crrev.com/6403f30a37f9ac07a05c4591ad8aabe202c96f05/third_party/WebKit/Source/modules/payments/PaymentManager.idl

Comment 4 by zino@chromium.org, May 21 2017

Status: Fixed (was: Untriaged)
Blocking: 661608

Sign in to add a comment