New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 720007 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

message_center_unittests failing on chromium.mac/Mac10.12 Tests

Project Member Reported by iclell...@chromium.org, May 9 2017

Issue description

message_center_unittests failing on chromium.mac/Mac10.12 Tests

Builders failed on: 
- Mac10.12 Tests: 
  https://build.chromium.org/p/chromium.mac/builders/Mac10.12%20Tests


This test appears to be flaky on the test bot. (Wild speculation --
 perhaps the timeouts are too close (1ms, 3ms, 5ms) that occasionally multiple timouts fire in a single iteration of the runloop?) I can't reproduce on my MacBook, but the test bot is on a VM, so timing variance may be much higher there.

Flakiness dashboard:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=message_center_unittests&tests=PopupTimersControllerStartMultipleTimers

Recent failures:
https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.12%20Tests/builds/341
https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.12%20Tests/builds/340
https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.12%20Tests/builds/325

Failure (from most recent build)
[ RUN      ] MessageCenterImplTest.PopupTimersControllerStartMultipleTimers
../../ui/message_center/message_center_impl_unittest.cc:326: Failure
Value of: "test2"
Expected: popup_timers_controller->last_id()
Which is: "test3"
[  FAILED  ] MessageCenterImplTest.PopupTimersControllerStartMultipleTimers (4 ms)

(Same failure on all three retries as well -- always sees "test3"; presumably test2 and test3 have both fired)
 
Cc: yoshiki@chromium.org
Cc: -yoshiki@chromium.org yhanada@chromium.org
Owner: yoshiki@chromium.org
Status: Started (was: Assigned)
I also think this is due to slowness. Let me fix.
Labels: M-60 Pri-2 Type-Bug
Project Member

Comment 4 by bugdroid1@chromium.org, May 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9880581d62ccb38559e5d8503c802e78c414ef22

commit 9880581d62ccb38559e5d8503c802e78c414ef22
Author: yoshiki <yoshiki@chromium.org>
Date: Thu May 11 00:46:40 2017

Fix flakiness of message_center_unittests in mac

BUG= 720007 

Review-Url: https://codereview.chromium.org/2874673002
Cr-Commit-Position: refs/heads/master@{#470764}

[modify] https://crrev.com/9880581d62ccb38559e5d8503c802e78c414ef22/ui/message_center/message_center_impl_unittest.cc

Status: fic (was: Started)
Status: Fixed (was: fic)

Sign in to add a comment