New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 720002 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 728003
issue 728006

Blocking:
issue 713222
issue 717394
issue 737105



Sign in to add a comment

Explicitly name stories for Telemetry story sets

Project Member Reported by rnep...@chromium.org, May 9 2017

Issue description

We do not currently always explicitly set the name of stories in story sets. It then defaults to using the URL (which sometimes gets transformed to be compatible with the perf dashboard). 

We want to add explicit names to these stories so that we can easily reason about what name to use when disabling tests, sending test data to the dashboard, sending test data to the flakiness dashboard, and reading the output of the test in the logs.

Doing this will require migration of data on the perf dashboard so we do not lose historical data when we switch names.

Simon/Annie can you give us some information on the cost of doing these data migrations? We would ideally only limit this naming to benchmarks/story sets we know for sure we will not be turning down in the near future. A good example of this would be the loading.mobile benchmark.

 
I think this should be okay to do for 5-10 benchmarks that only run on chromium.perf waterfall. I'm not sure how to give a time estimate for a migration though. Simon, any ideas?
Haven't done a migration yet, so I'm not sure how long it'd take. In crbug.com/713335 they're looking to migrate a small test, so we may be able to get an idea from that.
FYI: That migration didn't seem to work, so I'm investigating and it's probably better to hold off until then.
So that migration ended up taking about 3 hrs 20 mins.

Migration was for:

Old pattern: */*/media.tough_video_cases_extra/seek/*
New pattern: */*/media.tough_video_cases/seek/*


Just want to run something by y'all: If the names we explicitly add to the stories are the same as the story.display_name (which I think is the name being sent to the dashboard, please correct me if I'm wrong), we wouldn't need to do any migrations to avoid losing historical data. Is that correct?
Or is the name being sent to the dashboard being created in code somewhere that we could match to prevent the need for migrations?
I meant what if, for the time being, we set the name to be the url that is displayed on the dashboard for each of the tests that have no real name
That's less than ideal for the story disabling option in the long run, since we want to make it easy to disable stories based on name and we currently have a restriction on them being 50 characters long for disabling stories. We could remove that limitation, but we chose to put it in place so that it makes us stop and think about how the length of the story name can impact sheriffs and other consumers of telemetry. 

I'll let Ned weigh in on this though, and will make the necessary changes to StoryExpectations if we choose to go the route of using the URLs.
I would keep the name the same for benchmarks that need to be refactored soon, like smoothness, v8.*...

For once that are stable, I think let try to specify shorter name for them. Those that are stable are loading.mobile, blink_perf.*
webrtc benchmark is also another one which is stable.
Project Member

Comment 11 by bugdroid1@chromium.org, May 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a03358b4752b6ca9ee2c92c9dc20aa658bb1a250

commit a03358b4752b6ca9ee2c92c9dc20aa658bb1a250
Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org>
Date: Thu May 25 06:59:43 2017

Roll src/third_party/catapult/ 94990cd51..b6d2c18ca (2 commits)

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/94990cd519e0..b6d2c18cae16

$ git log 94990cd51..b6d2c18ca --date=short --no-merges --format='%ad %ae %s'
2017-05-24 ashleymarie Add flag to require stories in a story set are all named.
2017-05-24 dtu [pinpoint] Make /isolated take a Change instead of a git hash.

Created with:
  roll-dep src/third_party/catapult
BUG= 720002 


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I93f25de101ef7d0289a31eb343e04af8b2d8bb85
Reviewed-on: https://chromium-review.googlesource.com/514653
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#474592}
[modify] https://crrev.com/a03358b4752b6ca9ee2c92c9dc20aa658bb1a250/DEPS

So the plan sounds like it has evolved to keep the url as the name for most benchmarks and use shorter/better names for loading.mobile, blink_perf.*, and webrtc (and do the migrations for those benchmarks). Once the remaining benchmarks have been refactored, shorten/improve the names for those stories, do the migrations, and reinstate the 50 char limit
Yup. Though for legacy benchmarks, we still want to push the responsibility for crafting the name to the call sites, so that we can simplify the code in core Telemetry.
Blockedon: 728003
Blockedon: 728006
Project Member

Comment 17 by bugdroid1@chromium.org, May 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aead6369dea3e206264040f71d66415af55d47b8

commit aead6369dea3e206264040f71d66415af55d47b8
Author: ashleymarie <ashleymarie@chromium.org>
Date: Wed May 31 20:23:10 2017

Explicitly setting story names for the loading_mobile story set.

BUG= chromium:720002 
BUG= chromium:728006 

Review-Url: https://codereview.chromium.org/2907643002
Cr-Commit-Position: refs/heads/master@{#475998}

[modify] https://crrev.com/aead6369dea3e206264040f71d66415af55d47b8/tools/perf/page_sets/loading_mobile.py

Project Member

Comment 18 by bugdroid1@chromium.org, Jun 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ed6aee2484e96b28b55d6774c9e1cf6c308b07d

commit 4ed6aee2484e96b28b55d6774c9e1cf6c308b07d
Author: ashleymarie <ashleymarie@chromium.org>
Date: Thu Jun 01 01:53:07 2017

Explicitly setting story names for the dromaeo story sets.

BUG= chromium:720002 

Review-Url: https://codereview.chromium.org/2914733002
Cr-Commit-Position: refs/heads/master@{#476143}

[modify] https://crrev.com/4ed6aee2484e96b28b55d6774c9e1cf6c308b07d/tools/perf/benchmarks/dromaeo.py

Project Member

Comment 19 by bugdroid1@chromium.org, Jun 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/102f414aacab02ee2d8c0087db26f90d3f484b27

commit 102f414aacab02ee2d8c0087db26f90d3f484b27
Author: ashleymarie <ashleymarie@chromium.org>
Date: Fri Jun 02 15:20:44 2017

Verify story names for blob story set.

BUG= chromium:720002 

Review-Url: https://codereview.chromium.org/2916913003
Cr-Commit-Position: refs/heads/master@{#476658}

[modify] https://crrev.com/102f414aacab02ee2d8c0087db26f90d3f484b27/tools/perf/page_sets/blob_workshop.py

Project Member

Comment 20 by bugdroid1@chromium.org, Jun 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/419395f5fe84ee90f49ac0e9099d979e29994c93

commit 419395f5fe84ee90f49ac0e9099d979e29994c93
Author: ashleymarie <ashleymarie@chromium.org>
Date: Fri Jun 02 15:35:04 2017

Explicitly settings story names for the battor.steady_state story set.

BUG= chromium:720002 
BUG= chromium:728003 

Review-Url: https://codereview.chromium.org/2910673002
Cr-Commit-Position: refs/heads/master@{#476668}

[modify] https://crrev.com/419395f5fe84ee90f49ac0e9099d979e29994c93/tools/perf/page_sets/idle_after_loading_stories.py

Project Member

Comment 21 by bugdroid1@chromium.org, Jun 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3dbde7154ecc2d2e87760e67547d7a76ac9e3739

commit 3dbde7154ecc2d2e87760e67547d7a76ac9e3739
Author: ashleymarie <ashleymarie@chromium.org>
Date: Fri Jun 02 15:37:11 2017

Verify story names for system_health story sets

BUG= chromium:720002 

Review-Url: https://codereview.chromium.org/2918873002
Cr-Commit-Position: refs/heads/master@{#476669}

[modify] https://crrev.com/3dbde7154ecc2d2e87760e67547d7a76ac9e3739/tools/perf/page_sets/system_health/system_health_stories.py

Project Member

Comment 22 by bugdroid1@chromium.org, Jun 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8421b25aa448ba8b5c05d29c251c12d0054d7204

commit 8421b25aa448ba8b5c05d29c251c12d0054d7204
Author: ashleymarie <ashleymarie@chromium.org>
Date: Fri Jun 02 15:39:07 2017

Explicitly set name of jetstream story

BUG= chromium:720002 

Review-Url: https://codereview.chromium.org/2915213002
Cr-Commit-Position: refs/heads/master@{#476672}

[modify] https://crrev.com/8421b25aa448ba8b5c05d29c251c12d0054d7204/tools/perf/benchmarks/jetstream.py

Project Member

Comment 23 by bugdroid1@chromium.org, Jun 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/756477827b562d84e55102f39888c28cede2e6c9

commit 756477827b562d84e55102f39888c28cede2e6c9
Author: ashleymarie <ashleymarie@chromium.org>
Date: Fri Jun 02 15:46:10 2017

Explicitly set a story name for DummyPage

BUG= chromium:720002 

Review-Url: https://codereview.chromium.org/2921523003
Cr-Commit-Position: refs/heads/master@{#476675}

[modify] https://crrev.com/756477827b562d84e55102f39888c28cede2e6c9/tools/perf/page_sets/dummy_story_set.py

Project Member

Comment 24 by bugdroid1@chromium.org, Jun 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13fb844cea0b4c3a701c1bad00d3fce8fc2eb1b6

commit 13fb844cea0b4c3a701c1bad00d3fce8fc2eb1b6
Author: ashleymarie <ashleymarie@chromium.org>
Date: Fri Jun 02 19:30:44 2017

Explicitly setting the story name for the Kraken story set.

BUG= chromium:720002 

Review-Url: https://codereview.chromium.org/2916243003
Cr-Commit-Position: refs/heads/master@{#476753}

[modify] https://crrev.com/13fb844cea0b4c3a701c1bad00d3fce8fc2eb1b6/tools/perf/benchmarks/kraken.py

Project Member

Comment 25 by bugdroid1@chromium.org, Jun 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b1dbc7705043af840dd53f0d944e660d7920460

commit 8b1dbc7705043af840dd53f0d944e660d7920460
Author: ashleymarie <ashleymarie@chromium.org>
Date: Mon Jun 05 15:35:57 2017

Explicitly setting story names for image_decoding_measurement story set.

BUG= chromium:720002 

Review-Url: https://codereview.chromium.org/2919073002
Cr-Commit-Position: refs/heads/master@{#476989}

[modify] https://crrev.com/8b1dbc7705043af840dd53f0d944e660d7920460/tools/perf/page_sets/image_decoding_measurement.py

Project Member

Comment 28 by bugdroid1@chromium.org, Jun 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3976bb9e520387044c0207e12f5a31629e44b91c

commit 3976bb9e520387044c0207e12f5a31629e44b91c
Author: ashleymarie <ashleymarie@chromium.org>
Date: Mon Jun 05 20:05:21 2017

Explicitly setting name for oortonline stories

BUG= chromium:720002 

Review-Url: https://codereview.chromium.org/2918383002
Cr-Commit-Position: refs/heads/master@{#477059}

[modify] https://crrev.com/3976bb9e520387044c0207e12f5a31629e44b91c/tools/perf/page_sets/oortonline.py

Project Member

Comment 29 by bugdroid1@chromium.org, Jun 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea3f86f8e1dc5cec85cd485b160a53ebb20815a9

commit ea3f86f8e1dc5cec85cd485b160a53ebb20815a9
Author: ashleymarie <ashleymarie@chromium.org>
Date: Mon Jun 05 20:18:29 2017

Explicitly setting names for story sets in page_cycler_v2 benchmarks

BUG= chromium:720002 

Review-Url: https://codereview.chromium.org/2924623002
Cr-Commit-Position: refs/heads/master@{#477066}

[modify] https://crrev.com/ea3f86f8e1dc5cec85cd485b160a53ebb20815a9/tools/perf/page_sets/oopif_basic_page_set.py

Project Member

Comment 30 by bugdroid1@chromium.org, Jun 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca6fd7a1d017ac0914ef2e1651c3557812ff52ee

commit ca6fd7a1d017ac0914ef2e1651c3557812ff52ee
Author: ashleymarie <ashleymarie@chromium.org>
Date: Mon Jun 05 20:24:28 2017

Explicitly naming the story in the octane benchmark

BUG= chromium:720002 

Review-Url: https://codereview.chromium.org/2923593002
Cr-Commit-Position: refs/heads/master@{#477070}

[modify] https://crrev.com/ca6fd7a1d017ac0914ef2e1651c3557812ff52ee/tools/perf/benchmarks/octane.py

Project Member

Comment 31 by bugdroid1@chromium.org, Jun 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca6fd7a1d017ac0914ef2e1651c3557812ff52ee

commit ca6fd7a1d017ac0914ef2e1651c3557812ff52ee
Author: ashleymarie <ashleymarie@chromium.org>
Date: Mon Jun 05 20:24:28 2017

Explicitly naming the story in the octane benchmark

BUG= chromium:720002 

Review-Url: https://codereview.chromium.org/2923593002
Cr-Commit-Position: refs/heads/master@{#477070}

[modify] https://crrev.com/ca6fd7a1d017ac0914ef2e1651c3557812ff52ee/tools/perf/benchmarks/octane.py

Project Member

Comment 33 by bugdroid1@chromium.org, Jun 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e90cacb3d538bb42a7f60fb1718093b0f47c3511

commit e90cacb3d538bb42a7f60fb1718093b0f47c3511
Author: ashleymarie <ashleymarie@chromium.org>
Date: Tue Jun 06 01:13:25 2017

Explicitly setting story name for speedometer benchmark

BUG= chromium:720002 

Review-Url: https://codereview.chromium.org/2918413004
Cr-Commit-Position: refs/heads/master@{#477140}

[modify] https://crrev.com/e90cacb3d538bb42a7f60fb1718093b0f47c3511/tools/perf/benchmarks/speedometer.py

Project Member

Comment 36 by bugdroid1@chromium.org, Jun 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db86d7ee45310334b962959f4eafce7348a17b36

commit db86d7ee45310334b962959f4eafce7348a17b36
Author: ashleymarie <ashleymarie@chromium.org>
Date: Tue Jun 06 15:53:54 2017

Revert of Explictly setting story names for rasterize_and_record_micro story sets (patchset #1 id:1 of https://codereview.chromium.org/2921333002/ )

Reason for revert:
key_silk_cases has a few names in the form 'file://key_silk_cases/inbox_app.html?swipe_to_dismiss' which should be 'inbox_app.html?swipe_to_dismiss' instead

Original issue's description:
> Explictly setting story names for rasterize_and_record_micro story sets
>
> BUG= chromium:720002 
>
> Review-Url: https://codereview.chromium.org/2921333002
> Cr-Commit-Position: refs/heads/master@{#477290}
> Committed: https://chromium.googlesource.com/chromium/src/+/0f8c781859c2e2767a543d0238870c105a0ece88

TBR=vmpstr@chromium.org,nednguyen@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= chromium:720002 

Review-Url: https://codereview.chromium.org/2927583002
Cr-Commit-Position: refs/heads/master@{#477302}

[modify] https://crrev.com/db86d7ee45310334b962959f4eafce7348a17b36/tools/perf/page_sets/key_mobile_sites.py
[modify] https://crrev.com/db86d7ee45310334b962959f4eafce7348a17b36/tools/perf/page_sets/key_mobile_sites_pages.py
[modify] https://crrev.com/db86d7ee45310334b962959f4eafce7348a17b36/tools/perf/page_sets/key_silk_cases.py
[modify] https://crrev.com/db86d7ee45310334b962959f4eafce7348a17b36/tools/perf/page_sets/partial_invalidation_cases.py
[modify] https://crrev.com/db86d7ee45310334b962959f4eafce7348a17b36/tools/perf/page_sets/polymer.py
[modify] https://crrev.com/db86d7ee45310334b962959f4eafce7348a17b36/tools/perf/page_sets/top_25_pages.py
[modify] https://crrev.com/db86d7ee45310334b962959f4eafce7348a17b36/tools/perf/page_sets/top_pages.py

Project Member

Comment 37 by bugdroid1@chromium.org, Jun 6 2017

Project Member

Comment 40 by bugdroid1@chromium.org, Jun 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58a1a2d9c9a9f88f4ddce572891a47bdc9e1e330

commit 58a1a2d9c9a9f88f4ddce572891a47bdc9e1e330
Author: ashleymarie <ashleymarie@chromium.org>
Date: Wed Jun 07 15:55:00 2017

Verify names are set for storage benchmark stories

BUG= chromium:720002 

Review-Url: https://codereview.chromium.org/2925923002
Cr-Commit-Position: refs/heads/master@{#477663}

[modify] https://crrev.com/58a1a2d9c9a9f88f4ddce572891a47bdc9e1e330/tools/perf/page_sets/indexeddb_endure_page.py

Project Member

Comment 41 by bugdroid1@chromium.org, Jun 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/986ad291791882d151f951824774a8f1e276df14

commit 986ad291791882d151f951824774a8f1e276df14
Author: ashleymarie <ashleymarie@chromium.org>
Date: Wed Jun 07 17:23:06 2017

Explicitly setting names for scheduler.tough_scheduling_changes stories

BUG= chromium:720002 

Review-Url: https://codereview.chromium.org/2924673002
Cr-Commit-Position: refs/heads/master@{#477693}

[modify] https://crrev.com/986ad291791882d151f951824774a8f1e276df14/tools/perf/page_sets/tough_scheduling_cases.py

Project Member

Comment 42 by bugdroid1@chromium.org, Jun 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/764b927ab650fc1c685f00431be34677fec6630c

commit 764b927ab650fc1c685f00431be34677fec6630c
Author: ashleymarie <ashleymarie@chromium.org>
Date: Thu Jun 08 00:11:35 2017

Verify story name is set for tab switching benchmark

BUG= chromium:720002 

Review-Url: https://codereview.chromium.org/2927843002
Cr-Commit-Position: refs/heads/master@{#477817}

[modify] https://crrev.com/764b927ab650fc1c685f00431be34677fec6630c/tools/perf/benchmarks/tab_switching.py

Project Member

Comment 43 by bugdroid1@chromium.org, Jun 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/410db21ea84860f814ae4017eaf36f61c69acced

commit 410db21ea84860f814ae4017eaf36f61c69acced
Author: ashleymarie <ashleymarie@chromium.org>
Date: Thu Jun 08 00:14:14 2017

Explicitly set names for stories in Top10PageSet

BUG= chromium:720002 

Review-Url: https://codereview.chromium.org/2927823003
Cr-Commit-Position: refs/heads/master@{#477819}

[modify] https://crrev.com/410db21ea84860f814ae4017eaf36f61c69acced/tools/perf/page_sets/top_10.py

Project Member

Comment 45 by bugdroid1@chromium.org, Jun 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e7663cfd51fbf5f3a744351f0ae45df271b0da4

commit 1e7663cfd51fbf5f3a744351f0ae45df271b0da4
Author: ashleymarie <ashleymarie@chromium.org>
Date: Thu Jun 08 00:39:18 2017

Explicitly setting story names for the blink story sets.

BUG= chromium:720002 

Review-Url: https://codereview.chromium.org/2912253002
Cr-Commit-Position: refs/heads/master@{#477835}

[modify] https://crrev.com/1e7663cfd51fbf5f3a744351f0ae45df271b0da4/tools/perf/benchmarks/blink_perf.py

Project Member

Comment 48 by bugdroid1@chromium.org, Jun 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11ffc63960b436ad6a73fcbd1d1621188be057b9

commit 11ffc63960b436ad6a73fcbd1d1621188be057b9
Author: ashleymarie <ashleymarie@chromium.org>
Date: Fri Jun 09 15:24:59 2017

Explicitly setting story names for all smoothness benchmarks

BUG= chromium:720002 

Review-Url: https://codereview.chromium.org/2926633002
Cr-Commit-Position: refs/heads/master@{#478284}

[modify] https://crrev.com/11ffc63960b436ad6a73fcbd1d1621188be057b9/tools/perf/page_sets/image_decoding_cases.py
[modify] https://crrev.com/11ffc63960b436ad6a73fcbd1d1621188be057b9/tools/perf/page_sets/key_desktop_move_cases.py
[modify] https://crrev.com/11ffc63960b436ad6a73fcbd1d1621188be057b9/tools/perf/page_sets/key_mobile_sites_smooth.py
[modify] https://crrev.com/11ffc63960b436ad6a73fcbd1d1621188be057b9/tools/perf/page_sets/maps.py
[modify] https://crrev.com/11ffc63960b436ad6a73fcbd1d1621188be057b9/tools/perf/page_sets/pathological_mobile_sites.py
[modify] https://crrev.com/11ffc63960b436ad6a73fcbd1d1621188be057b9/tools/perf/page_sets/top_25_smooth.py
[modify] https://crrev.com/11ffc63960b436ad6a73fcbd1d1621188be057b9/tools/perf/page_sets/tough_ad_cases.py
[modify] https://crrev.com/11ffc63960b436ad6a73fcbd1d1621188be057b9/tools/perf/page_sets/tough_animation_cases.py
[modify] https://crrev.com/11ffc63960b436ad6a73fcbd1d1621188be057b9/tools/perf/page_sets/tough_canvas_cases.py
[modify] https://crrev.com/11ffc63960b436ad6a73fcbd1d1621188be057b9/tools/perf/page_sets/tough_filters_cases.py
[modify] https://crrev.com/11ffc63960b436ad6a73fcbd1d1621188be057b9/tools/perf/page_sets/tough_image_decode_cases.py
[modify] https://crrev.com/11ffc63960b436ad6a73fcbd1d1621188be057b9/tools/perf/page_sets/tough_path_rendering_cases.py
[modify] https://crrev.com/11ffc63960b436ad6a73fcbd1d1621188be057b9/tools/perf/page_sets/tough_pinch_zoom_cases.py
[modify] https://crrev.com/11ffc63960b436ad6a73fcbd1d1621188be057b9/tools/perf/page_sets/tough_texture_upload_cases.py
[modify] https://crrev.com/11ffc63960b436ad6a73fcbd1d1621188be057b9/tools/perf/page_sets/tough_webgl_cases.py

Project Member

Comment 49 by bugdroid1@chromium.org, Jun 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/87cf59c945df002b0332facc0d93c91bdb7d26d9

commit 87cf59c945df002b0332facc0d93c91bdb7d26d9
Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org>
Date: Mon Jun 12 15:21:28 2017

Roll src/third_party/catapult/ 36e1cdaf2..1c02d65fc (1 commit)

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/36e1cdaf2d99..1c02d65fcbf3

$ git log 36e1cdaf2..1c02d65fc --date=short --no-merges --format='%ad %ae %s'
2017-06-12 ashleymarie Add names to stories used in unittests

Created with:
  roll-dep src/third_party/catapult
BUG= 720002 


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Iccf75155d0e2ecc31f91681a8d1cc764fe4d0169
Reviewed-on: https://chromium-review.googlesource.com/531064
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478628}
[modify] https://crrev.com/87cf59c945df002b0332facc0d93c91bdb7d26d9/DEPS

Project Member

Comment 50 by bugdroid1@chromium.org, Jun 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72b0661cd1fbc0297200f9ca88be19bdeb865508

commit 72b0661cd1fbc0297200f9ca88be19bdeb865508
Author: ashleymarie <ashleymarie@chromium.org>
Date: Mon Jun 12 21:23:52 2017

Deleting unused story sets

BUG= chromium:720002 

Review-Url: https://codereview.chromium.org/2933173002
Cr-Commit-Position: refs/heads/master@{#478770}

[delete] https://crrev.com/927ddf0ccfa6947292f0551c83e427822ac18045/tools/perf/page_sets/alexa1-10000.py
[delete] https://crrev.com/927ddf0ccfa6947292f0551c83e427822ac18045/tools/perf/page_sets/android_acceptance.py
[modify] https://crrev.com/72b0661cd1fbc0297200f9ca88be19bdeb865508/tools/perf/page_sets/blank_page.py
[delete] https://crrev.com/927ddf0ccfa6947292f0551c83e427822ac18045/tools/perf/page_sets/diagonal_scrolling_supported_shared_state.py
[modify] https://crrev.com/72b0661cd1fbc0297200f9ca88be19bdeb865508/tools/perf/page_sets/dummy_story_set.py
[modify] https://crrev.com/72b0661cd1fbc0297200f9ca88be19bdeb865508/tools/perf/page_sets/google_pages.py
[delete] https://crrev.com/927ddf0ccfa6947292f0551c83e427822ac18045/tools/perf/page_sets/key_desktop_sites.py
[modify] https://crrev.com/72b0661cd1fbc0297200f9ca88be19bdeb865508/tools/perf/page_sets/key_mobile_sites_pages.py
[modify] https://crrev.com/72b0661cd1fbc0297200f9ca88be19bdeb865508/tools/perf/page_sets/key_mobile_sites_smooth.py
[delete] https://crrev.com/927ddf0ccfa6947292f0551c83e427822ac18045/tools/perf/page_sets/key_search_mobile.py
[modify] https://crrev.com/72b0661cd1fbc0297200f9ca88be19bdeb865508/tools/perf/page_sets/memory_top_10_mobile.py
[delete] https://crrev.com/927ddf0ccfa6947292f0551c83e427822ac18045/tools/perf/page_sets/mobile_facebook_page.py
[delete] https://crrev.com/927ddf0ccfa6947292f0551c83e427822ac18045/tools/perf/page_sets/mobile_memory.py
[delete] https://crrev.com/927ddf0ccfa6947292f0551c83e427822ac18045/tools/perf/page_sets/page_cycler/__init__.py
[delete] https://crrev.com/927ddf0ccfa6947292f0551c83e427822ac18045/tools/perf/page_sets/page_cycler/alexa_us.py
[delete] https://crrev.com/927ddf0ccfa6947292f0551c83e427822ac18045/tools/perf/page_sets/page_cycler/bloat.py
[delete] https://crrev.com/927ddf0ccfa6947292f0551c83e427822ac18045/tools/perf/page_sets/page_cycler/dom.py
[delete] https://crrev.com/927ddf0ccfa6947292f0551c83e427822ac18045/tools/perf/page_sets/page_cycler/intl1.py
[delete] https://crrev.com/927ddf0ccfa6947292f0551c83e427822ac18045/tools/perf/page_sets/page_cycler/intl2.py
[delete] https://crrev.com/927ddf0ccfa6947292f0551c83e427822ac18045/tools/perf/page_sets/simple_mobile_sites_fling.py
[delete] https://crrev.com/927ddf0ccfa6947292f0551c83e427822ac18045/tools/perf/page_sets/startup_pages_record.py
[modify] https://crrev.com/72b0661cd1fbc0297200f9ca88be19bdeb865508/tools/perf/page_sets/top_10.py
[modify] https://crrev.com/72b0661cd1fbc0297200f9ca88be19bdeb865508/tools/perf/page_sets/top_10_mobile.py
[modify] https://crrev.com/72b0661cd1fbc0297200f9ca88be19bdeb865508/tools/perf/page_sets/top_25_smooth.py
[delete] https://crrev.com/927ddf0ccfa6947292f0551c83e427822ac18045/tools/perf/page_sets/top_7_stress.py
[delete] https://crrev.com/927ddf0ccfa6947292f0551c83e427822ac18045/tools/perf/page_sets/top_desktop_sites_2012Q3.py
[delete] https://crrev.com/927ddf0ccfa6947292f0551c83e427822ac18045/tools/perf/page_sets/tough_layer_cases.py
[modify] https://crrev.com/72b0661cd1fbc0297200f9ca88be19bdeb865508/tools/perf/page_sets/typical_10_mobile.py
[modify] https://crrev.com/72b0661cd1fbc0297200f9ca88be19bdeb865508/tools/perf/page_sets/typical_25.py

Project Member

Comment 51 by bugdroid1@chromium.org, Jun 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/335063f9c6eda65548bda5e27eda2a9d5bce388c

commit 335063f9c6eda65548bda5e27eda2a9d5bce388c
Author: ashleymarie <ashleymarie@chromium.org>
Date: Tue Jun 13 18:50:33 2017

Explicitly setting names for stories in used page_sets

BUG= chromium:720002 

Review-Url: https://codereview.chromium.org/2935783004
Cr-Commit-Position: refs/heads/master@{#479081}

[modify] https://crrev.com/335063f9c6eda65548bda5e27eda2a9d5bce388c/tools/perf/page_sets/desktop_memory.py
[modify] https://crrev.com/335063f9c6eda65548bda5e27eda2a9d5bce388c/tools/perf/page_sets/dual_browser_story.py
[modify] https://crrev.com/335063f9c6eda65548bda5e27eda2a9d5bce388c/tools/perf/page_sets/intl_ar_fa_he.py
[modify] https://crrev.com/335063f9c6eda65548bda5e27eda2a9d5bce388c/tools/perf/page_sets/intl_es_fr_pt-BR.py
[modify] https://crrev.com/335063f9c6eda65548bda5e27eda2a9d5bce388c/tools/perf/page_sets/intl_hi_ru.py
[modify] https://crrev.com/335063f9c6eda65548bda5e27eda2a9d5bce388c/tools/perf/page_sets/intl_ja_zh.py
[modify] https://crrev.com/335063f9c6eda65548bda5e27eda2a9d5bce388c/tools/perf/page_sets/intl_ko_th_vi.py
[modify] https://crrev.com/335063f9c6eda65548bda5e27eda2a9d5bce388c/tools/perf/page_sets/page_reload_cases.py
[modify] https://crrev.com/335063f9c6eda65548bda5e27eda2a9d5bce388c/tools/perf/page_sets/story_set_unittest.py
[modify] https://crrev.com/335063f9c6eda65548bda5e27eda2a9d5bce388c/tools/perf/page_sets/top_10_mobile.py
[modify] https://crrev.com/335063f9c6eda65548bda5e27eda2a9d5bce388c/tools/perf/page_sets/typical_25.py

Project Member

Comment 52 by bugdroid1@chromium.org, Jun 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3c82afc38710daaba052350e225cfb7cbdf81d3

commit c3c82afc38710daaba052350e225cfb7cbdf81d3
Author: ashleymarie <ashleymarie@chromium.org>
Date: Wed Jun 14 02:21:54 2017

Removing verify_names=True now that the default for verify_names is True

BUG= chromium:720002 

Review-Url: https://codereview.chromium.org/2941663002
Cr-Commit-Position: refs/heads/master@{#479257}

[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/benchmarks/blink_perf.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/benchmarks/dromaeo.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/benchmarks/jetstream.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/benchmarks/kraken.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/benchmarks/octane.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/benchmarks/speedometer.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/benchmarks/tab_switching.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/page_sets/blank_page.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/page_sets/blank_page_with_extension_profile.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/page_sets/blank_page_with_large_profile.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/page_sets/blink_memory_mobile.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/page_sets/blob_workshop.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/page_sets/chrome_signin.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/page_sets/desktop_memory.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/page_sets/dual_browser_story.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/page_sets/dummy_story_set.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/page_sets/idle_after_loading_stories.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/page_sets/idle_platform.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/page_sets/image_decoding_cases.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/page_sets/image_decoding_measurement.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/page_sets/indexeddb_endure_page.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/page_sets/infinite_scroll_cases.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/page_sets/intl_ar_fa_he.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/page_sets/intl_es_fr_pt-BR.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/page_sets/intl_hi_ru.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/page_sets/intl_ja_zh.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/page_sets/intl_ko_th_vi.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/page_sets/key_desktop_move_cases.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/page_sets/key_hit_test_cases.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/page_sets/key_idle_power_cases.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/page_sets/key_mobile_sites.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/page_sets/key_mobile_sites_smooth.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/page_sets/key_noop_cases.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/page_sets/key_silk_cases.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/page_sets/loading_desktop.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/page_sets/loading_mobile.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/page_sets/long_running_idle_google_cases.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/page_sets/maps.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/page_sets/media_cns_cases.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/page_sets/memory_top_10_mobile.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/page_sets/mse_cases.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/page_sets/oopif_basic_page_set.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/page_sets/oortonline.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/page_sets/page_reload_cases.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/page_sets/partial_invalidation_cases.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/page_sets/pathological_mobile_sites.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/page_sets/polymer.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/page_sets/service_worker.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/page_sets/service_worker_micro_benchmark.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/page_sets/simple_mobile_sites.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/page_sets/startup_pages.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/page_sets/system_health/system_health_stories.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/page_sets/top_10.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/page_sets/top_10_mobile.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/page_sets/top_25_pages.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/page_sets/top_25_smooth.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/page_sets/tough_ad_cases.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/page_sets/tough_animation_cases.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/page_sets/tough_canvas_cases.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/page_sets/tough_compositor_cases.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/page_sets/tough_filters_cases.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/page_sets/tough_image_decode_cases.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/page_sets/tough_path_rendering_cases.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/page_sets/tough_pinch_zoom_cases.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/page_sets/tough_scheduling_cases.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/page_sets/tough_scrolling_cases.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/page_sets/tough_texture_upload_cases.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/page_sets/tough_video_cases.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/page_sets/tough_webgl_cases.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/page_sets/trivial_sites.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/page_sets/typical_10_mobile.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/page_sets/typical_25.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/page_sets/v8_top_25.py
[modify] https://crrev.com/c3c82afc38710daaba052350e225cfb7cbdf81d3/tools/perf/page_sets/webrtc_cases.py

Project Member

Comment 53 by bugdroid1@chromium.org, Jun 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7aa9b726f574cff3c44c068e49ec71ee6081449

commit d7aa9b726f574cff3c44c068e49ec71ee6081449
Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org>
Date: Wed Jun 14 20:17:10 2017

Roll src/third_party/catapult/ 597f96ee4..c9212cbf5 (8 commits)

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/597f96ee44a5..c9212cbf5220

$ git log 597f96ee4..c9212cbf5 --date=short --no-merges --format='%ad %ae %s'
2017-06-14 ashleymarie Revert of Defaulting verify_names flag to True (patchset #1 id:1 of https://codereview.chromium.org/2924023003/ )
2017-06-13 lchoi Removed if clause from screenshot_supported. After running unit tests locally, was able to verify that screenshotting does indeed work with xvfb. Patching so that we can move forward with screenshotting for Cluster Telemetry purposes:  crbug.com/536285 
2017-06-13 benjhayden Plumb trace start timestamp DateRange diagnostic from telemetry.
2017-06-13 benjhayden Copy improvement directions from telemetry to legacy_unit_info.
2017-06-13 jbudorick [devil] Add system app replacement wrapper script.
2017-06-13 benjhayden Add a slider to histogram-set-controls to control alpha.
2017-06-13 ashleymarie Defaulting verify_names flag to True
2017-06-13 benjhayden Fix overview line charts in results2.

Created with:
  roll-dep src/third_party/catapult
BUG= 720002 , 728404 , 720002 


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I89c70230bd8dc1b4304961e891534abe56c9d79a
Reviewed-on: https://chromium-review.googlesource.com/535062
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#479484}
[modify] https://crrev.com/d7aa9b726f574cff3c44c068e49ec71ee6081449/DEPS

Project Member

Comment 55 by bugdroid1@chromium.org, Jun 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/175bf817dbbb2b3f775127f3b84b4cfd7845fcde

commit 175bf817dbbb2b3f775127f3b84b4cfd7845fcde
Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org>
Date: Fri Jun 16 18:57:03 2017

Roll src/third_party/catapult/ 59a182b2a..e9dc4c57f (16 commits)

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/59a182b2a694..e9dc4c57fb00

$ git log 59a182b2a..e9dc4c57f --date=short --no-merges --format='%ad %ae %s'
2017-06-16 eakuefner [Telemetry] Shim telemetry.internal.util.camel_case
2017-06-16 nednguyen Set default value for TracedMetaClass to avoid import error when trace_event_impl is undefined
2017-06-16 xunjieli Migrate web-page-replay-go files
2017-06-16 mboehme Clip slices to the horizontal bounds of the viewport.
2017-06-15 benjhayden Make common/battor/bin/run_py_tests executable.
2017-06-15 dproy Add function to calculate First Consistently Interactive.
2017-06-15 eakuefner [Tracing] Move Python HistogramSet into tracing.value.histogram_set
2017-06-15 etienneb Add support for fetching symbols from GCS for windows traces
2017-06-15 eakuefner [Telemetry] Delete telemetry.internal.util.classes
2017-06-15 benjhayden Document all the scripts in tracing/bin/.
2017-06-15 ashleymarie Adding names for stories in unittests
2017-06-15 benjhayden Rename valueset2html to histograms2html.
2017-06-15 benjhayden Fix metrics-results-ui-significance-threshold-slider.png
2017-06-15 benjhayden Remove dead code iterObjectFieldsRecursively.
2017-06-15 eakuefner [Telemetry] Move camel_case to common/py_utils
2017-06-15 dskiba [experimental] symbolize_trace: fix include paths

Created with:
  roll-dep src/third_party/catapult
BUG=719969, 720002 


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I044b424973ad6cca6e37f8a39e71e4a2d62975a2
Reviewed-on: https://chromium-review.googlesource.com/538852
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480112}
[modify] https://crrev.com/175bf817dbbb2b3f775127f3b84b4cfd7845fcde/DEPS

Project Member

Comment 56 by bugdroid1@chromium.org, Jun 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e027709aa25e656c45e3aeca3171925e85280c45

commit e027709aa25e656c45e3aeca3171925e85280c45
Author: ashleymarie <ashleymarie@chromium.org>
Date: Mon Jun 26 20:05:57 2017

Setting story names for stories in media_router_perf_pages

As a part of  bug 720002 , we're asserting that all stories be named,
even stories used in tests.

BUG= chromium:720002 

Review-Url: https://codereview.chromium.org/2962553002
Cr-Commit-Position: refs/heads/master@{#482368}

[modify] https://crrev.com/e027709aa25e656c45e3aeca3171925e85280c45/chrome/test/media_router/telemetry/benchmarks/pagesets/media_router_perf_pages.py

Project Member

Comment 57 by bugdroid1@chromium.org, Jun 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/89156c939945376aa4a8e42d6018eda15a7ede5b

commit 89156c939945376aa4a8e42d6018eda15a7ede5b
Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org>
Date: Mon Jun 26 21:12:15 2017

Roll src/third_party/catapult/ 143270ac9..6f3e9c7a2 (3 commits)

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/143270ac9225..6f3e9c7a28b2

$ git log 143270ac9..6f3e9c7a2 --date=short --no-merges --format='%ad %ae %s'
2017-06-26 eakuefner [Telemetry] Delete pydoc
2017-06-26 rnephew [Telemetry] Increase  story name limit to 75 for story expectations.
2017-06-26 ashleymarie Removing deprecated verify_names flag now that it defaults to True

Created with:
  roll-dep src/third_party/catapult
BUG= 720002 


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: If34dd22617dbeb125a29f91e1b4e3c73aecadea7
Reviewed-on: https://chromium-review.googlesource.com/549177
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#482399}
[modify] https://crrev.com/89156c939945376aa4a8e42d6018eda15a7ede5b/DEPS

Project Member

Comment 58 by bugdroid1@chromium.org, Jun 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93f209a7ad51fb30a67ccc5c428424fb0db928f7

commit 93f209a7ad51fb30a67ccc5c428424fb0db928f7
Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org>
Date: Mon Jun 26 22:30:34 2017

Roll src/third_party/catapult/ 6f3e9c7a2..712c23b8f (4 commits)

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/6f3e9c7a28b2..712c23b8f376

$ git log 6f3e9c7a2..712c23b8f --date=short --no-merges --format='%ad %ae %s'
2017-06-26 xunjieli [wpr-go] Pick an availble port to start servers if no port is specified
2017-06-26 benjhayden Display selected statistic in overview line charts.
2017-06-26 ashleymarie Removing verify_names flag
2017-06-26 ashleymarie Assert stories have names

Created with:
  roll-dep src/third_party/catapult
BUG= 720002 , 720002 


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I275cebe44410b820686bb2e2e0c9b71103b54a10
Reviewed-on: https://chromium-review.googlesource.com/549048
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#482437}
[modify] https://crrev.com/93f209a7ad51fb30a67ccc5c428424fb0db928f7/DEPS

Status: Fixed (was: Assigned)
I think we're done here!!
Please reopen if you think I missed something :)
\o/ Thanks for all of your work here Ashley!
Amazing work addressing this, Ashley!

I think we should collapse story.display_name & story.name, but that probably can be done in a separate bug tracker.
Blocking: 737105

Sign in to add a comment