Note that I have crbug/2872143002 out for review for the controller app button part of this (but it needs to rebase with the app button exit for WebVR presentation before it can be submitted).

Perhaps I should have created two bugs (one for the app button exit and one for the ui button addition)?

Should we have a toast telling the user how to exit fullscreen like we have for traditional screens? I imagine it would be similar to the toast we display upon entering WebVR?

On one hand, fullscreen might be less concerning than on traditional displays since the app doesn't occupy the entire display. On the other hand, it would be consistent, explain to users what happened (i.e. if the target they clicked does not clearly indicate fullscreen), and help users that do not know how to exit when the page doesn't provide such UI (until users get used to the idea that app button exits things).

Adding a note from the review, once controller emulation lands in https://codereview.chromium.org/2867243002/ we should add an e2e test to verify the controller app button press exits fullscreen.

I'll be adding the UI button, as I'm currently adding a similar button for CCT. Don't care whether we create separate bugs or both use this one.

Using one issue for both works for me.  The app button change is pretty small and should be landing soon (tagged to this issue).  I'll leave it open for the ui button coming next.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce32493baa1dde9fe3976b80bd128e5560d424d8

commit ce32493baa1dde9fe3976b80bd128e5560d424d8
Author: amp <amp@chromium.org>
Date: Thu May 11 03:29:23 2017

VrShell: Exit fullscreen on app button press.

BUG= 719997 

Review-Url: https://codereview.chromium.org/2872143002
Cr-Commit-Position: refs/heads/master@{#470794}

[modify] https://crrev.com/ce32493baa1dde9fe3976b80bd128e5560d424d8/chrome/browser/android/vr_shell/ui_scene_manager.cc
[modify] https://crrev.com/ce32493baa1dde9fe3976b80bd128e5560d424d8/chrome/browser/android/vr_shell/ui_scene_manager_unittest.cc
[modify] https://crrev.com/ce32493baa1dde9fe3976b80bd128e5560d424d8/chrome/browser/android/vr_shell/vr_browser_interface.h
[modify] https://crrev.com/ce32493baa1dde9fe3976b80bd128e5560d424d8/chrome/browser/android/vr_shell/vr_gl_thread.cc
[modify] https://crrev.com/ce32493baa1dde9fe3976b80bd128e5560d424d8/chrome/browser/android/vr_shell/vr_gl_thread.h
[modify] https://crrev.com/ce32493baa1dde9fe3976b80bd128e5560d424d8/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/ce32493baa1dde9fe3976b80bd128e5560d424d8/chrome/browser/android/vr_shell/vr_shell.h

Re: comment #5 - the controller emulation patch landed, so you can add the e2e tests now.

Sorry, didn't manage to get to this. Passing back over to amp@.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9189aa4473f6915826d070f6e3fb008a2904d8f

commit f9189aa4473f6915826d070f6e3fb008a2904d8f
Author: amp <amp@chromium.org>
Date: Tue Jun 06 21:33:07 2017

[VrShell] Centralize color handling and enable close button on fullscreen

This updates all of the existing hard coded colors to use colors from the scheme instead of hardcoding (so they can change with the mode).

The naming of colors in the scheme was also updated for better
consistency and to differentiate from world environment colors.

BUG= 719997 , 729729 

Review-Url: https://codereview.chromium.org/2914623003
Cr-Commit-Position: refs/heads/master@{#477411}

[modify] https://crrev.com/f9189aa4473f6915826d070f6e3fb008a2904d8f/chrome/browser/android/vr_shell/color_scheme.cc
[modify] https://crrev.com/f9189aa4473f6915826d070f6e3fb008a2904d8f/chrome/browser/android/vr_shell/color_scheme.h
[modify] https://crrev.com/f9189aa4473f6915826d070f6e3fb008a2904d8f/chrome/browser/android/vr_shell/textures/button_texture.cc
[modify] https://crrev.com/f9189aa4473f6915826d070f6e3fb008a2904d8f/chrome/browser/android/vr_shell/textures/button_texture.h
[modify] https://crrev.com/f9189aa4473f6915826d070f6e3fb008a2904d8f/chrome/browser/android/vr_shell/textures/close_button_texture.cc
[modify] https://crrev.com/f9189aa4473f6915826d070f6e3fb008a2904d8f/chrome/browser/android/vr_shell/textures/exit_warning_texture.cc
[modify] https://crrev.com/f9189aa4473f6915826d070f6e3fb008a2904d8f/chrome/browser/android/vr_shell/textures/insecure_content_permanent_texture.cc
[modify] https://crrev.com/f9189aa4473f6915826d070f6e3fb008a2904d8f/chrome/browser/android/vr_shell/textures/insecure_content_transient_texture.cc
[modify] https://crrev.com/f9189aa4473f6915826d070f6e3fb008a2904d8f/chrome/browser/android/vr_shell/textures/loading_indicator_texture.cc
[modify] https://crrev.com/f9189aa4473f6915826d070f6e3fb008a2904d8f/chrome/browser/android/vr_shell/textures/system_indicator_texture.cc
[modify] https://crrev.com/f9189aa4473f6915826d070f6e3fb008a2904d8f/chrome/browser/android/vr_shell/textures/ui_texture.cc
[modify] https://crrev.com/f9189aa4473f6915826d070f6e3fb008a2904d8f/chrome/browser/android/vr_shell/textures/ui_texture.h
[modify] https://crrev.com/f9189aa4473f6915826d070f6e3fb008a2904d8f/chrome/browser/android/vr_shell/textures/url_bar_texture.cc
[modify] https://crrev.com/f9189aa4473f6915826d070f6e3fb008a2904d8f/chrome/browser/android/vr_shell/textures/url_bar_texture.h
[modify] https://crrev.com/f9189aa4473f6915826d070f6e3fb008a2904d8f/chrome/browser/android/vr_shell/ui_elements/screen_dimmer.cc
[modify] https://crrev.com/f9189aa4473f6915826d070f6e3fb008a2904d8f/chrome/browser/android/vr_shell/ui_elements/textured_element.cc
[modify] https://crrev.com/f9189aa4473f6915826d070f6e3fb008a2904d8f/chrome/browser/android/vr_shell/ui_scene.cc
[modify] https://crrev.com/f9189aa4473f6915826d070f6e3fb008a2904d8f/chrome/browser/android/vr_shell/ui_scene.h
[modify] https://crrev.com/f9189aa4473f6915826d070f6e3fb008a2904d8f/chrome/browser/android/vr_shell/ui_scene_manager.cc
[modify] https://crrev.com/f9189aa4473f6915826d070f6e3fb008a2904d8f/chrome/browser/android/vr_shell/ui_scene_manager.h
[modify] https://crrev.com/f9189aa4473f6915826d070f6e3fb008a2904d8f/chrome/browser/android/vr_shell/ui_scene_manager_unittest.cc
[modify] https://crrev.com/f9189aa4473f6915826d070f6e3fb008a2904d8f/chrome/browser/android/vr_shell/vr_shell_gl.cc

Tested on canary 61.0.3123.0.  Requesting merge to 60.

Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed05197a31887a41b469403b2b497e21bff20c54

commit ed05197a31887a41b469403b2b497e21bff20c54
Author: amp <amp@chromium.org>
Date: Wed Jun 07 17:24:55 2017

[VrShell] Centralize color handling and enable close button on fullscreen

This updates all of the existing hard coded colors to use colors from the scheme instead of hardcoding (so they can change with the mode).

The naming of colors in the scheme was also updated for better
consistency and to differentiate from world environment colors.

BUG= 719997 , 729729 
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2914623003
Cr-Original-Commit-Position: refs/heads/master@{#477411}
Review-Url: https://codereview.chromium.org/2926643003
Cr-Commit-Position: refs/branch-heads/3112@{#225}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] https://crrev.com/ed05197a31887a41b469403b2b497e21bff20c54/chrome/browser/android/vr_shell/color_scheme.cc
[modify] https://crrev.com/ed05197a31887a41b469403b2b497e21bff20c54/chrome/browser/android/vr_shell/color_scheme.h
[modify] https://crrev.com/ed05197a31887a41b469403b2b497e21bff20c54/chrome/browser/android/vr_shell/textures/button_texture.cc
[modify] https://crrev.com/ed05197a31887a41b469403b2b497e21bff20c54/chrome/browser/android/vr_shell/textures/button_texture.h
[modify] https://crrev.com/ed05197a31887a41b469403b2b497e21bff20c54/chrome/browser/android/vr_shell/textures/close_button_texture.cc
[modify] https://crrev.com/ed05197a31887a41b469403b2b497e21bff20c54/chrome/browser/android/vr_shell/textures/exit_warning_texture.cc
[modify] https://crrev.com/ed05197a31887a41b469403b2b497e21bff20c54/chrome/browser/android/vr_shell/textures/insecure_content_permanent_texture.cc
[modify] https://crrev.com/ed05197a31887a41b469403b2b497e21bff20c54/chrome/browser/android/vr_shell/textures/insecure_content_transient_texture.cc
[modify] https://crrev.com/ed05197a31887a41b469403b2b497e21bff20c54/chrome/browser/android/vr_shell/textures/loading_indicator_texture.cc
[modify] https://crrev.com/ed05197a31887a41b469403b2b497e21bff20c54/chrome/browser/android/vr_shell/textures/system_indicator_texture.cc
[modify] https://crrev.com/ed05197a31887a41b469403b2b497e21bff20c54/chrome/browser/android/vr_shell/textures/ui_texture.cc
[modify] https://crrev.com/ed05197a31887a41b469403b2b497e21bff20c54/chrome/browser/android/vr_shell/textures/ui_texture.h
[modify] https://crrev.com/ed05197a31887a41b469403b2b497e21bff20c54/chrome/browser/android/vr_shell/textures/url_bar_texture.cc
[modify] https://crrev.com/ed05197a31887a41b469403b2b497e21bff20c54/chrome/browser/android/vr_shell/textures/url_bar_texture.h
[modify] https://crrev.com/ed05197a31887a41b469403b2b497e21bff20c54/chrome/browser/android/vr_shell/ui_elements/screen_dimmer.cc
[modify] https://crrev.com/ed05197a31887a41b469403b2b497e21bff20c54/chrome/browser/android/vr_shell/ui_elements/textured_element.cc
[modify] https://crrev.com/ed05197a31887a41b469403b2b497e21bff20c54/chrome/browser/android/vr_shell/ui_scene.cc
[modify] https://crrev.com/ed05197a31887a41b469403b2b497e21bff20c54/chrome/browser/android/vr_shell/ui_scene.h
[modify] https://crrev.com/ed05197a31887a41b469403b2b497e21bff20c54/chrome/browser/android/vr_shell/ui_scene_manager.cc
[modify] https://crrev.com/ed05197a31887a41b469403b2b497e21bff20c54/chrome/browser/android/vr_shell/ui_scene_manager.h
[modify] https://crrev.com/ed05197a31887a41b469403b2b497e21bff20c54/chrome/browser/android/vr_shell/ui_scene_manager_unittest.cc
[modify] https://crrev.com/ed05197a31887a41b469403b2b497e21bff20c54/chrome/browser/android/vr_shell/vr_shell_gl.cc