New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 719990 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Add ios/web_view unittest target

Project Member Reported by michaeldo@chromium.org, May 9 2017

Issue description

ChromeWebView should be unittested, especially for the features which are not implemented in ios/web_view/shell.
 

Comment 1 Deleted

Project Member

Comment 2 by bugdroid1@chromium.org, May 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ffc03d37d7e7f39ead0994db70dcf0b91fffb4f

commit 8ffc03d37d7e7f39ead0994db70dcf0b91fffb4f
Author: michaeldo <michaeldo@chromium.org>
Date: Wed May 24 17:58:19 2017

Add unittest target to test CWVWebView.

Add test which validates CWVWebView's canGoBack and canGoForward KVO properties.

BUG= 719990 

Review-Url: https://codereview.chromium.org/2892193002
Cr-Commit-Position: refs/heads/master@{#474350}

[modify] https://crrev.com/8ffc03d37d7e7f39ead0994db70dcf0b91fffb4f/ios/BUILD.gn
[add] https://crrev.com/8ffc03d37d7e7f39ead0994db70dcf0b91fffb4f/ios/web_view/test/BUILD.gn
[add] https://crrev.com/8ffc03d37d7e7f39ead0994db70dcf0b91fffb4f/ios/web_view/test/DEPS
[add] https://crrev.com/8ffc03d37d7e7f39ead0994db70dcf0b91fffb4f/ios/web_view/test/boolean_observer.h
[add] https://crrev.com/8ffc03d37d7e7f39ead0994db70dcf0b91fffb4f/ios/web_view/test/boolean_observer.mm
[add] https://crrev.com/8ffc03d37d7e7f39ead0994db70dcf0b91fffb4f/ios/web_view/test/chrome_web_view_kvo_inttest.mm
[add] https://crrev.com/8ffc03d37d7e7f39ead0994db70dcf0b91fffb4f/ios/web_view/test/chrome_web_view_test.h
[add] https://crrev.com/8ffc03d37d7e7f39ead0994db70dcf0b91fffb4f/ios/web_view/test/chrome_web_view_test.mm
[add] https://crrev.com/8ffc03d37d7e7f39ead0994db70dcf0b91fffb4f/ios/web_view/test/web_view_interaction_test_util.h
[add] https://crrev.com/8ffc03d37d7e7f39ead0994db70dcf0b91fffb4f/ios/web_view/test/web_view_interaction_test_util.mm

Status: Fixed (was: Started)

Sign in to add a comment