New issue
Advanced search Search tips

Issue 719989 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Clean up the WebRTC recipes

Project Member Reported by ehmaldonado@chromium.org, May 9 2017

Issue description

Clean up the WebRTC recipes

The goal is to get rid of technical debt as much as possible.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/4ed4219bd19960b21e8bc17f61f775ce2a973562

commit 4ed4219bd19960b21e8bc17f61f775ce2a973562
Author: Edward Lemur <ehmaldonado@chromium.org>
Date: Wed May 10 12:00:10 2017

Move Win8 and Win10 bots over to swarming.

This will allow us to get rid of lines 83, 86-89 of steps.py

Bug: chromium:719989 
Change-Id: I7af1688d5a2db25617afbc015352f5e4b0bc6fff
Reviewed-on: https://chromium-review.googlesource.com/500069
Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

[modify] https://crrev.com/4ed4219bd19960b21e8bc17f61f775ce2a973562/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_win8.json
[modify] https://crrev.com/4ed4219bd19960b21e8bc17f61f775ce2a973562/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_win64_debug__win10_.json
[modify] https://crrev.com/4ed4219bd19960b21e8bc17f61f775ce2a973562/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_win10.json
[modify] https://crrev.com/4ed4219bd19960b21e8bc17f61f775ce2a973562/scripts/slave/recipe_modules/webrtc/builders.py
[modify] https://crrev.com/4ed4219bd19960b21e8bc17f61f775ce2a973562/scripts/slave/recipes/webrtc/standalone.py
[modify] https://crrev.com/4ed4219bd19960b21e8bc17f61f775ce2a973562/scripts/slave/recipe_modules/webrtc/steps.py
[modify] https://crrev.com/4ed4219bd19960b21e8bc17f61f775ce2a973562/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_win64_debug__win8_.json

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/81b140aa0d10961c3d38711a53709499358cd113

commit 81b140aa0d10961c3d38711a53709499358cd113
Author: Edward Lemur <ehmaldonado@chromium.org>
Date: Wed Jul 19 12:47:01 2017

WebRTC: Remove android_experimental.

This bot was introduced to help with the development of the
AppRTCMobileTestStubbedVideoIO test.
This test is now working and it's run on the Android perf bots
via the video_quality_loopback_test.py script.

TBR=kjellander@chromium.org
Bug:  chromium:719989 
Change-Id: Ia671ebf0155d2d205b6fef32f90ec23d6a5c90ec
Reviewed-on: https://chromium-review.googlesource.com/577534
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

[modify] https://crrev.com/81b140aa0d10961c3d38711a53709499358cd113/masters/master.tryserver.webrtc/slaves.cfg
[modify] https://crrev.com/81b140aa0d10961c3d38711a53709499358cd113/scripts/slave/recipe_modules/webrtc/builders.py
[modify] https://crrev.com/81b140aa0d10961c3d38711a53709499358cd113/masters/master.tryserver.webrtc/master.cfg
[modify] https://crrev.com/81b140aa0d10961c3d38711a53709499358cd113/scripts/slave/README.recipes.md
[delete] https://crrev.com/4f0b09caa6f368b0189e160cef9667d9c37de0d9/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_experimental.json
[modify] https://crrev.com/81b140aa0d10961c3d38711a53709499358cd113/scripts/slave/recipe_modules/webrtc/steps.py
[modify] https://crrev.com/81b140aa0d10961c3d38711a53709499358cd113/scripts/slave/recipe_modules/webrtc/api.py

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/cb1b9c8f1cb4b9fdf4dcd575a3c280be149c5a6e

commit cb1b9c8f1cb4b9fdf4dcd575a3c280be149c5a6e
Author: Edward Lemur <ehmaldonado@chromium.org>
Date: Fri Jul 21 18:19:54 2017

WebRTC: Move calls of api.chromium.runtest from api.py to steps.py

I find it confusing to have
the logic to run tests split between steps.py and api.py

Bug:  chromium:719989 
Change-Id: Ic67a57dcdf2f0ae9c22e4fdb0a93c5349afe0934
Reviewed-on: https://chromium-review.googlesource.com/576038
Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

[modify] https://crrev.com/cb1b9c8f1cb4b9fdf4dcd575a3c280be149c5a6e/scripts/slave/README.recipes.md
[modify] https://crrev.com/cb1b9c8f1cb4b9fdf4dcd575a3c280be149c5a6e/scripts/slave/recipe_modules/webrtc/api.py
[modify] https://crrev.com/cb1b9c8f1cb4b9fdf4dcd575a3c280be149c5a6e/scripts/slave/recipe_modules/webrtc/steps.py
[modify] https://crrev.com/cb1b9c8f1cb4b9fdf4dcd575a3c280be149c5a6e/scripts/slave/recipes/webrtc/more_configs.py

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/d334ae6bc699d6531c82ff4469ed87fe67917e2b

commit d334ae6bc699d6531c82ff4469ed87fe67917e2b
Author: Edward Lemur <ehmaldonado@chromium.org>
Date: Fri Jul 28 19:16:40 2017

WebRTC: Remove WebRTCTest class in steps.py.

It is not really useful now.

Bug:  chromium:719989 
Change-Id: Ifee518c44571ed8ac144245f274e9735ec9d89b3
Reviewed-on: https://chromium-review.googlesource.com/586691
Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

[modify] https://crrev.com/d334ae6bc699d6531c82ff4469ed87fe67917e2b/scripts/slave/recipe_modules/webrtc/steps.py

Status: Fixed (was: Started)
I think we can pronounce this done unless you had anything else in mind.

Sign in to add a comment