New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 719988 link

Starred by 0 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Incorrect credit card logo is displayed in Payments

Project Member Reported by srikanthg@chromium.org, May 9 2017

Issue description

App Version: 60.0.3094.0 dev
iOS Version: 10.3.2,
Device: iPhone7 plus
URL: na

Precondition: Choose any account that has Credit card info from Google Payments.
 
Steps to reproduce:
1. Launch Google Chrome 
2. Sign in with the account that has credit cards info from Google Payments
3. Tap Menu → Settings → Autofill Forms → Credit Cards
4. Choose any credit card
 
Observed results: Edit Credit Card screen shows incorrect credit card logo. It shows a logo of Diners Club International, which I think has no connection with the card I have. Credit card in my Google Payments is a Visa Signature card from BOA.
 
Expected results: Correct logo should be displayed
 
Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Chrome Mobile on Android: NA
Bug reproducible on Dolphin/Safari/Atomic: Dolphin: NA, Safari: NA
Bug reproducible on current stable build (App Version, iOS Version):  M58 NA (Nothing displayed)
Bug reproducible on the current beta channel build (App Version, iOS Version): M59 YES
  
Link to video/image: https://drive.google.com/file/d/0B-xmXLQhjeKuX3BwcEJoQ2FhX1k/view 
 
Tapping on EDIT redirects me to payments.google.com and it shows the correct images.
https://drive.google.com/file/d/0B-xmXLQhjeKuRF9pUHlRcW1SVW8/view

Comment 2 by sczs@chromium.org, May 10 2017

Owner: mahmadi@chromium.org
Status: Assigned (was: Untriaged)
mahmadi@ could you please take a look. 
Cc: mahmadi@chromium.org
Owner: jif@chromium.org

Comment 4 by jif@chromium.org, Jun 21 2017

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e19586ba1c5e3e5c837594366b89cb936928fc9

commit 4e19586ba1c5e3e5c837594366b89cb936928fc9
Author: jif <jif@chromium.org>
Date: Mon Jun 26 14:13:35 2017

[iOS] Set credit card icon using the saved network.

When possible, the code stops using the credit card number to obtain the network.
This is because the browser only knows the last four digit or non local cards, which is
not sufficient to know the network.

This CL also changes the label shown for non local credit cards:
Instead of containing "1234", the label contains "Mastercard ... 1234".

BUG= 719988 

Review-Url: https://codereview.chromium.org/2949283002
Cr-Commit-Position: refs/heads/master@{#482265}

[modify] https://crrev.com/4e19586ba1c5e3e5c837594366b89cb936928fc9/ios/chrome/browser/ui/settings/autofill_credit_card_edit_collection_view_controller.mm

Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Comment 7 by jif@chromium.org, Jun 28 2017

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified on:

App Version: 61.0.3148.0 canary
Devices: iPhone6 Plus
iOS Version: 10.3.1

Correct credit card logo is displayed in Payments and label contains type of credit card along with last four digits of credit card number .i.e."Visa....4651". Please see the screenshots attached.
VisaCreditCard.PNG
81.6 KB View Download
MasterCardCreditCard.PNG
83.9 KB View Download

Sign in to add a comment