New issue
Advanced search Search tips

Issue 719982 link

Starred by 0 users

Issue metadata

Status: Verified
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Navigation entry is displayed blank in the History dropdown menu for file:// urls

Project Member Reported by srikanthg@chromium.org, May 9 2017

Issue description

App Version: 60.0.3094.0 dev
iOS Version: 10.3.2, 9.3.5
Device: iPhone, iPad
URL: file://
 
Steps to reproduce:
1. Launch Google Chrome Canary
2. Navigate to file:// and make sure you see an error page
3. Tap on back arrow from toolbar
4. Long tap on forward arrow
 
Observed results: Observe that page url/title is not displayed in the dropdown menu
 
Expected results: Page url/title should always be displayed.
 
Working fine with all other types of webpages.
 
Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Chrome Mobile on Android: NA
Bug reproducible on Dolphin/Safari/Atomic: Dolphin: NA, Safari: NA
Bug reproducible on current stable build (App Version, iOS Version):  M58 NO
Bug reproducible on the current beta channel build (App Version, iOS Version): M59 Yes
  
Link to video/image: 
Screenshot: https://drive.google.com/file/d/0B-xmXLQhjeKuS0NKeGpYeDVkMFU/view
Repro Video: https://drive.google.com/file/d/0B-xmXLQhjeKua1A3RVhkbzc1a28/view 
 
Components: UI>Browser>Navigation
srikanthg@ could you please bisect

Comment 2 by sczs@chromium.org, May 10 2017

Labels: M-60 ReleaseBlock-Stable
Owner: srikanthg@chromium.org
Status: Assigned (was: Untriaged)
Owner: eugene...@chromium.org
Good Version: 59.0.3030.0 #ae57f58
 Bad Version: 59.0.3031.0 #3665df2
Cc: kkhorimoto@chromium.org
Labels: -Pri-2 Pri-1
Regressed after https://codereview.chromium.org/2722983003
Status: Started (was: Assigned)
Fix: https://codereview.chromium.org/2876053002
Project Member

Comment 6 by bugdroid1@chromium.org, May 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6728ff6b6cff9e4d0b5f684d6d8eac068a2d5df6

commit 6728ff6b6cff9e4d0b5f684d6d8eac068a2d5df6
Author: eugenebut <eugenebut@chromium.org>
Date: Thu May 11 23:02:20 2017

Fixed NavigationItemImpl::GetDisplayTitleForURL for 'file://' URL.

Use full URL spec if it ends with /

BUG= 719982 

Review-Url: https://codereview.chromium.org/2876053002
Cr-Commit-Position: refs/heads/master@{#471105}

[modify] https://crrev.com/6728ff6b6cff9e4d0b5f684d6d8eac068a2d5df6/ios/web/navigation/navigation_item_impl.mm
[modify] https://crrev.com/6728ff6b6cff9e4d0b5f684d6d8eac068a2d5df6/ios/web/navigation/navigation_item_impl_unittest.mm

Labels: Merge-Request-60
Status: Fixed (was: Started)
Project Member

Comment 8 by sheriffbot@chromium.org, May 12 2017

Labels: -Merge-Request-60 Hotlist-Merge-Review Merge-Review-60
This bug requires manual review: We don't branch M60 until 2017-05-25.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-60
Right... there is no branch yet :)
Status: Verified (was: Fixed)
Fix looks good on M60.0.3097.0 canary
Verified on iPhone7 plus with iOS 10.3.2

Sign in to add a comment